chore(internal): Use memfs for project.ts test

[Tobbe]

Use memfs to mock the filesystem for faster tests, and to not rely on the global test fixtures

[netlify]

✅ Deploy Preview for cedarjs canceled.

Name	Link
🔨 Latest commit	47a8fcf
🔍 Latest deploy log	https://app.netlify.com/projects/cedarjs/deploys/6922111b2d570e0008da5d73

[greptile-apps]

Greptile Overview

Greptile Summary

Refactored test from using real filesystem fixtures to memfs virtual filesystem, but implementation has critical bugs that will cause tests to fail.

Key Issues

• Missing process.env.RWJS_CWD setup: Both test cases don't set the RWJS_CWD environment variable, causing getConfigPath() to search the real filesystem instead of the mocked memfs virtual filesystem
• Incomplete virtual filesystem: Missing required files (web/src/Routes.*, web/vite.config.*) that getPaths() expects via resolveFile() calls

Why This Matters

The test flow is: getTsConfigs() → getPaths() → getConfigPath() → findUp('redwood.toml', process.env.RWJS_CWD ?? process.cwd()). Without setting RWJS_CWD = '/', the code searches the real filesystem from the actual cwd, completely bypassing the memfs mock.

Reference implementation: packages/cli-helpers/src/lib/__tests__/project.addTomlSetting.test.ts:15-21 shows the correct pattern of setting RWJS_CWD before using memfs.

Confidence Score: 0/5

• This PR contains critical bugs that will cause test failures - tests cannot work without setting process.env.RWJS_CWD
• Score 0 reflects that the tests will definitively fail in their current state. The missing process.env.RWJS_CWD = '/' setup means the code will search the real filesystem instead of the mocked memfs, causing getConfigPath() to fail when it cannot find redwood.toml. This is a fundamental implementation issue, not a minor oversight.
• packages/internal/src/__tests__/project.test.ts - both test cases need process.env.RWJS_CWD = '/' added and additional virtual filesystem files to work correctly

Important Files Changed

File Analysis

Filename	Score	Overview
packages/internal/src/tests/project.test.ts	1/5	refactored test to use memfs but missing critical setup - tests will fail without process.env.RWJS_CWD = '/' and required virtual files

Sequence Diagram

sequenceDiagram
    participant Test as Test Suite
    participant Vitest as Vitest
    participant Memfs as memfs (vol)
    participant FS as fs/node:fs
    participant GetTsConfigs as getTsConfigs()
    participant GetPaths as getPaths()
    participant GetConfigPath as getConfigPath()
    participant FindUp as findUp()

    Test->>Vitest: vi.mock('fs', memfs)
    Test->>Vitest: vi.mock('node:fs', memfs)
    Test->>Memfs: vol.fromNestedJSON({...}, '/')
    Note over Memfs: Creates virtual filesystem at root
    
    Test->>GetTsConfigs: Call getTsConfigs()
    GetTsConfigs->>GetPaths: Call getPaths()
    GetPaths->>GetConfigPath: Call getConfigPath()
    
    Note over GetConfigPath: Uses process.env.RWJS_CWD ?? process.cwd()
    Note over GetConfigPath,FindUp: ⚠️ BUG: RWJS_CWD not set,<br/>uses real filesystem cwd
    
    GetConfigPath->>FindUp: findUp('redwood.toml', process.cwd())
    FindUp->>FS: fs.existsSync(realCwd + '/redwood.toml')
    Note over FS: Checks REAL filesystem,<br/>not memfs virtual filesystem
    
    FS-->>FindUp: false (not found in real fs)
    FindUp-->>GetConfigPath: null
    GetConfigPath-->>GetPaths: throws Error
    GetPaths-->>GetTsConfigs: Error propagates
    GetTsConfigs-->>Test: ❌ Test fails

Loading

[greptile-apps]

_{1 file reviewed, 3 comments}

_{Edit Code Review Agent Settings | Greptile}