Skip to content

Conversation

@Tobbe
Copy link
Member

@Tobbe Tobbe commented Dec 15, 2025

When we push new package versions during the release process two CI checks would try to install the yet-to-be-released packages. They'd both fail with a message similar to this:

Run yarn build:pack
/home/runner/work/cedar/cedar/node_modules/zx/build/core.cjs:587
          const output = new ProcessOutput({
                         ^

Error: sOutput [Error]: 
    at file:///home/runner/work/cedar/cedar/packages/create-cedar-app/scripts/buildPack.js:18:10
    exit code: 1
    details: 
➤ YN0000: · Yarn 4.12.0
➤ YN0000: ┌ Resolution step
Resolution step
➤ YN0082: @cedarjs/api@npm:2.1.0: No candidates found
➤ YN0000: └ Completed in 0s 822ms
➤ YN0000: · Failed with errors in 0s 832ms
    at EventEmitter.end (/home/runner/work/cedar/cedar/node_modules/zx/build/core.cjs:587:26)
    at EventEmitter.emit (node:events:520:35)
    at ChildProcess.<anonymous> (/home/runner/work/cedar/cedar/node_modules/zx/build/vendor-core.cjs:1170:16)
    at Object.onceWrapper (node:events:623:26)
    at ChildProcess.emit (node:events:508:28)
    at maybeClose (node:internal/child_process:1101:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5) {
  [cause]: [Getter]
}

Node.js v24.11.1
Error: Process completed with exit code 1.

This PR skips the tests that'd always fail

@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for cedarjs canceled.

Name Link
🔨 Latest commit 7df7ed5
🔍 Latest deploy log https://app.netlify.com/projects/cedarjs/deploys/694043240a7c8c0008bed5a8

@github-actions github-actions bot added this to the chore milestone Dec 15, 2025
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 15, 2025

Greptile Overview

Greptile Summary

Conditionally skips telemetry-check and create-cedar-app jobs on release branches to prevent CI failures from attempting to install @cedar/* package versions that haven't been published yet.

  • Added if conditions to skip tests when pushing to release/** branches while still running them for pull requests and pushes to the next branch
  • Added explanatory comments documenting why these jobs need to be skipped during releases
  • Minor formatting improvement: changed pull_request: to pull_request: {} with explanatory comment

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward and well-documented. The conditional logic correctly uses github.event_name and startsWith(github.ref, 'refs/heads/release/') to skip tests only on release branches while preserving them for PRs and the next branch. The added comments clearly explain the rationale. No functional changes to the actual test logic.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
.github/workflows/ci.yml 5/5 Added conditional skipping of telemetry-check and create-cedar-app jobs on release branches to prevent failures from unreleased package versions

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Event
    participant CI as CI Workflow
    participant TC as telemetry-check
    participant CCA as create-cedar-app
    
    GH->>CI: Trigger (PR or push to next/release/*)
    CI->>CI: Run detect-changes
    CI->>CI: Run check job
    
    alt Event is Pull Request
        CI->>TC: Run telemetry-check
        TC->>TC: Install unpublished @cedar/* packages
        TC-->>CI: Success
        CI->>CCA: Run create-cedar-app test
        CCA->>CCA: Install unpublished @cedar/* packages
        CCA-->>CI: Success
    else Event is push to release/** branch
        CI->>TC: Skip (unreleased packages unavailable)
        CI->>CCA: Skip (unreleased packages unavailable)
    else Event is push to next branch
        CI->>TC: Run telemetry-check
        TC->>TC: Install unpublished @cedar/* packages
        TC-->>CI: Success
        CI->>CCA: Run create-cedar-app test
        CCA->>CCA: Install unpublished @cedar/* packages
        CCA-->>CI: Success
    end
    
    CI->>CI: Run other jobs
    CI->>CI: Final status check
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@Tobbe Tobbe merged commit fc13a97 into main Dec 15, 2025
38 checks passed
@Tobbe Tobbe deleted the tobbe-skip-version-ci-tests-on-publish branch December 15, 2025 17:38
Tobbe added a commit that referenced this pull request Dec 15, 2025
@Tobbe Tobbe modified the milestones: chore, v2.1.0 Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants