Skip to content

Conversation

@mohdimas
Copy link
Contributor

@mohdimas mohdimas commented Dec 4, 2014

Implementing Invalidate

build.ps1 Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert changes to this file.

@amaitland
Copy link
Member

Also in future please give you PR's a relevant name 👍 Cef/2171 isn't very descriptive.

@amaitland
Copy link
Member

Please checkout #662 as I believe it achieves a similar result. (Was merged into 2171 just recently).

@amaitland amaitland changed the title Cef/2171 WPF Invalidate on Visible Change Dec 4, 2014
@amaitland
Copy link
Member

I think WasHidden has some performance benefits, effectively disabling rendering when hidden and resuming when visible.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer not to make white space changes to sections of code unrelated to the PR.

@amaitland amaitland added this to the 39.0.0 milestone Dec 4, 2014
@amaitland amaitland merged commit db517cc into cefsharp:cef/2171 Dec 8, 2014
@amaitland
Copy link
Member

@myrnazhou I've merged this with a few minor cleanups 👍

When you push more commits to your branch, if you could post a comment to let me know otherwise I'm not notified.

@mohdimas
Copy link
Contributor Author

mohdimas commented Dec 8, 2014

Ah ok got it (y)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants