Rework ResourceHandler

[amaitland]

Includes a few changes around Resource Handling

• Split GetResourceHandler out of IRequestHandler into it's own IResourceHandler interface.
• Also include a DefaultResourceHandler implementation, so LoadHtml can easily be replaced with a ResourceHandler
• Update WPF and WinForms examples to reflect the changes.
• Add license header to CefTerminationStatus (unrelated commit)

[amaitland]

@jankurianski I decided to extract Resouce handling into it's own IResourceHandler interface, so it's easy for users to hook into and override functionality if required. I also replaced LoadHtml.

Thoughts?

[jankurianski]

Cool! Taking a look now.

[jankurianski]

Works great. I tested it out by updating the CefSharp.OffScreen.Example:
https://gist.github.com/jankurianski/e0ac2d1006f3a42216be

The only potential issue could be that UnregisterHandler is never called, but it is hard to know the right time to do this, and as long as the url is distinct it won't matter.

[jankurianski]

Actually, there is a bit of a problem: if you call LoadHtml() twice with the same url, it crashes because the resource handler already exists.

[jankurianski]

Perhaps LoadHtml() should simply unregister any existing handler first?

            handler.UnregisterHandler(url);
            handler.RegisterHandler(url, CefSharp.ResourceHandler.FromString(html));

[amaitland]

The only potential issue could be that UnregisterHandler is never called, but it is hard to know the right time to do this, and as long as the url is distinct it won't matter.

Users can always manually unregister the Url if required.

Actually, there is a bit of a problem: if you call LoadHtml() twice with the same url, it crashes because the resource handler already exists.

Nice pickup, thanks! 👍

[amaitland]

Commit b104cd7 should fix the multiple registration bug

[jankurianski]

Commit b104cd7 should fix the multiple registration bug

That should do the trick! 👍

[amaitland]

@Jayman1305 As you submitted a PR related to ResourceHandler I though I'd give you a heads up about this PR.

[amaitland]

@jornh Do you think a -pre03 package is necessary? I'd like to change the API before officially releasing 37.

[jornh]

@amaitland No let's go straight for the 37 👍