Don't change .Address when popups display

[rassilon]

Ought to be pretty straightforward.

I wasn't sure if just checking IsPopup was good enough.

The existing test wasn't good enough because DevTools is the main frame for the popup DevTools browser.

Bill

[amaitland]

I would have though !browser->IsPopup() would have done the trick. Did it not resolve the issue?

[rassilon]

IsPopup did indeed work just fine apparently.

[amaitland]

Still need the main frame check I believe. Otherwise ifames etc will change the url also.

[amaitland]

Looks like the frame check isn't required anymore 👍 From memory it was added for a reason, just can't remember what for. Also possible the behavior of CEF has changed. CEF usually only passes in a frame object when it's relevant. I tested with regular frames and iframes, and it doesn't seem to be called multiple times anymore. So let's ignore my previous comment.

[rassilon]

Cool. Thank's for checking.