Cleanup OnBeforeResourceLoad #911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to perform Redirect simply set the IRequest.Url
Member
Author
|
Unless anyone has objections to this simplification, I'll merge during the week. |
amaitland
added a commit
that referenced
this pull request
Mar 30, 2015
Cleanup OnBeforeResourceLoad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
IResponseandResponseclasses, to perform Redirect simply set theIRequest.UrlWas reading the code, answering a question and
OnBeforeResourceLoadseemed overly complicated (I know it was leftover fromCefSharp1, when you could return a stream to fulfill a request).This is a breaking change. I've updated the example to demo how this should work.