Experimental support for package tools#675
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements a major refactor of the "extension" system, replacing the concept of "extensions" with "packages" throughout the codebase and documentation. It updates interfaces, service contracts, global usings, resource strings, and developer documentation to use the new terminology and APIs. The changes also introduce new user interface resources for package publishing and installation confirmation dialogs.
The most important changes are:
Core architectural refactor:
GetBundledExtensionFolders→GetBundledPackageFolders,IExtensionService→IPackageService, and related types and parameters. [1] [2] [3] [4] [5] [6]Celbridge.Extensionsnamespace and its types (such asDocumentContribution,Extension,ExtensionInfo, etc.), signaling a complete migration to the newCelbridge.Packagessystem. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]User interface and resource updates:
IConfirmActionCommandinterface andConfirmActionResultrecord to standardize confirmation dialogs in the user interface.Developer documentation:
Dependencies:
Tomlynpackage toCelbridge.Toolsfor TOML manifest parsing, supporting the new package manifest format.These changes collectively modernize and clarify the extension mechanism in the codebase, making it more robust, user-friendly, and aligned with common package management practices.