Merged
Conversation
Contributor
Author
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
dnys1
reviewed
Dec 9, 2023
dnys1
approved these changes
Dec 9, 2023
dnys1
added a commit
that referenced
this pull request
Mar 9, 2025
Fixes a few issues related to flags passed to the `dart` and `flutter_tester` commands. 1. Can't use filepaths on Windows--FE server needs file: URIs. But - only true for some flags, others require paths. ``` [ProcessManager] FINEST: run: c:\hostedtoolcache\windows\flutter\stable-3.22.1-x64\bin\cache\dart-sdk\bin\dartaotruntime c:\hostedtoolcache\windows\flutter\stable-3.22.1-x64\bin\cache\dart-sdk\bin\snapshots\frontend_server_aot.dart.snapshot --sdk-root c:\hostedtoolcache\windows\flutter\stable-3.22.1-x64\bin\cache\artifacts\engine\common\flutter_patched_sdk --platform c:\hostedtoolcache\windows\flutter\stable-3.22.1-x64\bin\cache\artifacts\engine\common\flutter_patched_sdk\platform_strong.dill --link-platform --target flutter --packages D:\a\cloud\cloud\apps\cli\test\fixtures\legacy\flutter\goldens\.dart_tool\package_config.json --output-dill D:\a\cloud\cloud\apps\cli\test\fixtures\legacy\flutter\goldens\functions\dart_ui\lerpColor.dill D:\a\cloud\cloud\apps\cli\test\fixtures\legacy\flutter\goldens\functions\dart_ui\lerpColor.dart ❌ test\fixtures\legacy\fixtures_test.dart: Fixture flutter apis dart_ui lerpColor (setUpAll) (failed) Error generating initial kernel file: result dde93313-620b-4cb7-a85d-8b4a6668d203 Unhandled exception: FileSystemException(uri=c:/hostedtoolcache/windows/flutter/stable-3.22.1-x64/bin/cache/artifacts/engine/common/flutter_patched_sdk/platform_strong.dill; message=StandardFileSystem only supports file:* and data:* URIs) #0 StandardFileSystem.entityForUri (package:front_end/src/api_prototype/standard_file_system.dart:34) #1 ProcessedOptions.validateOptions (package:front_end/src/base/processed_options.dart:328) <asynchronous suspension> #2 CompilerContext.runWithOptions.<anonymous closure> (package:front_end/src/fasta/compiler_context.dart:129) <asynchronous suspension> #3 CompilerContext.clear (package:front_end/src/fasta/compiler_context.dart:139) <asynchronous suspension> #4 kernelForProgramInternal (package:front_end/src/api_prototype/kernel_generator.dart:64) <asynchronous suspension> #5 kernelForProgram (package:front_end/src/api_prototype/kernel_generator.dart:50) <asynchronous suspension> #6 compileToKernel (package:vm/kernel_front_end.dart:469) <asynchronous suspension> #7 FrontendCompiler.compile (package:frontend_server/frontend_server.dart:639) <asynchronous suspension> #8 starter (package:frontend_server/starter.dart:101) <asynchronous suspension> #9 main (file:///C:/b/s/w/ir/x/w/sdk/pkg/frontend_server/bin/frontend_server_starter.dart:13) <asynchronous suspension> ``` 2. Windows does not need isolates paused when using `--no-dds` so we can remove all that code 3. The `--run-forever` flag creates a zombie process that can only be killed with `SIGKILL`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: Update README file
chore: Update README