chore: Use Any type for cross-module protos#312
Merged
Conversation
This was referenced Apr 11, 2025
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dnys1
force-pushed
the
04-10-chore_use_any_type_for_cross-module_protos
branch
from
3440c82 to
5d4cbdc
Compare
Member
Author
dnys1
changed the base branch from
04-10-fix_cloud_auth_correctly_route_users_me_
to
graphite-base/312
Directly using AST protos from Celest Cloud protos means juggling two separate Dart types since Dart's protoc plugin is not module aware like other languages. There is also an AIP [lint](https://linter.aip.dev/215/foreign-type-reference) which is violated doing this. Instead, use the Any type which will allow separate versioning and publishing of AST protos and Cloud protos.
dnys1
force-pushed
the
04-10-chore_use_any_type_for_cross-module_protos
branch
from
5d4cbdc to
57b9da6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directly using AST protos from Celest Cloud protos means juggling two separate Dart types since Dart's protoc plugin is not module aware like other languages. There is also an AIP lint which is violated doing this. Instead, use the Any type which will allow separate versioning and publishing of AST protos and Cloud protos.
Also cleans up a bunch of unused proto files from
package:celest_cloud.