Skip to content

feat: generalize rpc flag#1319

Merged
jcstein merged 1 commit intomainfrom
jcs/opdeploy
Dec 13, 2023
Merged

feat: generalize rpc flag#1319
jcstein merged 1 commit intomainfrom
jcs/opdeploy

Conversation

@jcstein
Copy link
Copy Markdown
Member

@jcstein jcstein commented Dec 12, 2023

Overview

Generalizes the --core.ip string flag to use <rpc-url> instead of a hardcoded endpoint that was for mainnet.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@jcstein jcstein requested a review from tuxcanfly December 12, 2023 16:01
@jcstein jcstein self-assigned this Dec 12, 2023
@github-actions
Copy link
Copy Markdown
Contributor

PR Preview Action v1.4.4
🚀 Deployed preview to https://celestiaorg.github.io/docs/pr-preview/pr-1319/
on branch gh-pages at 2023-12-12 16:02 UTC

@jcstein jcstein requested a review from Bidon15 December 12, 2023 16:06
@jcstein jcstein added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Dec 12, 2023
@jcstein jcstein merged commit c100e1c into main Dec 13, 2023
@jcstein jcstein deleted the jcs/opdeploy branch December 13, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants