Conversation
|
I had this happen to me and added the linting in a PR I have open (not best practice), so thanks for opening this. Just reverted the commit on that PR.
It doesn't look like there is a CI lint on the most recent PRs...so looking into that now. Regardless, I think that we do need to look into the flow of the linting with the pre-commit hook, and whether it should also exist the same way as CI, as I don't see it running on this PR? As for now, it only is used if developer downloads dependencies, otherwise husky won't run the pre-commit EDIT: i think that I took off the CI check when I added husky. So it is time to add it back i think. |
|
NOTE: the changes to UPDATE: done here in an open PR to orchestrator-relayer celestiaorg/orchestrator-relayer#661 |
While working on a different PR, the commit pre-hook failed because
yarn lintresulted in a diff. Since these changes are unrelated to my PR, I included them here.Note: I wonder why CI lint didn't catch these? Do we want an issue to investigate the discrepancy between local lint and CI lint?