Skip to content

feat: update pruning info#1426

Merged
Bidon15 merged 4 commits intomainfrom
jcs/revert-pruning-docss
Mar 11, 2024
Merged

feat: update pruning info#1426
Bidon15 merged 4 commits intomainfrom
jcs/revert-pruning-docss

Conversation

@jcstein
Copy link
Copy Markdown
Member

@jcstein jcstein commented Feb 20, 2024 •
edited by coderabbitai bot
Loading

Overview

From comment:

likely need to revert this as it appears the window was the only thing introduced, and that the release notes say "Light nodes will now only sample blocks within a 30 day window instead of sampling all blocks from genesis." but it does not work this way.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • New Features
    • Implemented a 30-day light node sampling window and introduced pruning for enhanced data retrievability and storage management.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 20, 2024 •
edited
Loading

Walkthrough

The recent update to celestia-node, version v0.13.0, enhances data management by implementing a 30-day light node sampling window and introducing pruning. This change optimizes network efficiency by ensuring light nodes maintain recent data while archival nodes store older data, improving data retrievability and storage management.

Changes

Files Change Summary
learn/retrievability.md Introduced 30-day light node sampling window and pruning.

Related issues

  • celestiaorg/docs#1415 - This issue requests documentation for pruning in v0.13.0, which is directly addressed by the changes in learn/retrievability.md.

Poem

In the realm of bytes and blocks, a rabbit hopped and tweaked the clocks.
"Let's prune," it said, "the old, the stale, and keep our nodes light, quick, and hale."
🌱🐇 For thirty days, the data stays, then off it goes, in the digital haze.
With archival nodes, the past we keep, ensuring history's climb is steep.
So cheers to v0.13.0, a leap toward efficiency, second to none.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 20, 2024 •
edited
Loading

PR Preview Action v1.4.7
🚀 Deployed preview to https://celestiaorg.github.io/docs/pr-preview/pr-1426/
on branch gh-pages at 2024-02-22 12:11 UTC

coderabbitai[bot]
coderabbitai bot reviewed Feb 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7c1985c and 7cf071c.
Files selected for processing (1)
  • learn/retrievability.md (1 hunks)
Additional comments: 1
learn/retrievability.md (1)
  • 38-38: The section on suggested practices for rollups provides valuable guidance for managing historical data access. It's well-structured and offers practical solutions. However, ensuring that these practices are up-to-date and align with the latest developments in the Celestia ecosystem is crucial.

Comment thread learn/retrievability.md
Comment thread learn/retrievability.md Outdated
@jcstein jcstein requested review from a team, Bidon15, ramin, renaynay and walldiss and removed request for a team February 20, 2024 09:02
@jcstein jcstein changed the title feat: update pruning info because light nodes don't prune yet feat: update pruning info Feb 21, 2024
jcstein
jcstein commented Feb 22, 2024
View reviewed changes
Comment thread learn/retrievability.md Outdated
coderabbitai[bot]
coderabbitai bot reviewed Feb 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7cf071c and f0adaee.
Files selected for processing (1)
  • learn/retrievability.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • learn/retrievability.md

jcstein
jcstein commented Feb 22, 2024
View reviewed changes
Comment thread learn/retrievability.md Outdated
coderabbitai[bot]
coderabbitai bot reviewed Feb 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between f0adaee and 111c79f.
Files selected for processing (1)
  • learn/retrievability.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • learn/retrievability.md

jcstein
jcstein commented Feb 22, 2024
View reviewed changes
Comment thread learn/retrievability.md Outdated
coderabbitai[bot]
coderabbitai bot reviewed Feb 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 111c79f and 8242de6.
Files selected for processing (1)
  • learn/retrievability.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • learn/retrievability.md

@jcstein jcstein self-assigned this Feb 22, 2024
@jcstein jcstein removed the request for review from walldiss February 22, 2024 13:06
@jcstein
Copy link
Copy Markdown
Member Author

jcstein commented Mar 8, 2024

do we need this @ramin ?

@jcstein
Copy link
Copy Markdown
Member Author

jcstein commented Mar 8, 2024

IMO the logs are still very misleading, and appear to sample everything from 0 to tip of chain

@Bidon15 Bidon15 merged commit b095db0 into main Mar 11, 2024
@Bidon15 Bidon15 deleted the jcs/revert-pruning-docss branch March 11, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bidon15 Bidon15 Bidon15 approved these changes

@renaynay renaynay Awaiting requested review from renaynay renaynay was automatically assigned from celestiaorg/celestia-node

@ramin ramin Awaiting requested review from ramin

+1 more reviewer

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jcstein jcstein

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jcstein @Bidon15