Skip to content

Add ValiDAO archive endpoints#1427

Merged
jcstein merged 1 commit intocelestiaorg:mainfrom
validaoxyz:main
Feb 21, 2024
Merged

Add ValiDAO archive endpoints#1427
jcstein merged 1 commit intocelestiaorg:mainfrom
validaoxyz:main

Conversation

@murakamikaze
Copy link
Copy Markdown
Contributor

@murakamikaze murakamikaze commented Feb 20, 2024

Overview

Adding ValiDAO's archive RPC endpoints - rest, grpc, json-rpc.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • New Features
    • Added new RPC, REST, and gRPC endpoints for Mainnet Beta to improve network accessibility and interaction.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 20, 2024

Walkthrough

The update introduces new endpoints for the Mainnet Beta, enhancing accessibility through RPC, REST, and gRPC protocols. These additions aim to improve the network's interoperability and efficiency, providing developers and users with more versatile options for interaction with the Mainnet Beta.

Changes

File Path Change Summary
nodes/mainnet.md Added RPC, REST, and gRPC endpoints for Mainnet Beta on celestia.rpc...validao.xyz, celestia.rest...validao.xyz, and celestia.grpc...validao.xyz:9090.

🌟🐇✨
In the digital meadow under the moon's soft glow,
New paths emerge where the data streams flow.
RPC, REST, and gRPC, a trifecta so bright,
Guiding through the network, with newfound light.
So hop along, dear friends, let's explore with delight!
🌌🚀🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7c1985c and 0ad4702.
Files selected for processing (1)
  • nodes/mainnet.md (3 hunks)
Additional comments: 3
nodes/mainnet.md (3)
  • 117-117: The addition of the new JSON-RPC endpoint for ValiDAO's archive services is correctly placed under the "Consensus RPC endpoints" section. This aligns with the PR objectives to enhance Mainnet Beta's accessibility by integrating ValiDAO's archive RPC endpoints.
  • 138-138: The new REST endpoint for ValiDAO's archive services is appropriately added to the "API endpoints" section. This change is consistent with the PR's goal of providing diverse access points for archival data, thereby supporting a broader range of user interactions within the Mainnet Beta infrastructure.
  • 158-158: The addition of the gRPC endpoint for ValiDAO's archive services under the "gRPC endpoints" section is accurate and aligns with the PR's objectives. It enhances the network's infrastructure by offering an additional, efficient access point for archival data.

@jcstein jcstein merged commit 2db9987 into celestiaorg:main Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants