Skip to content

Update mainnet.md with Chainode Tech Archive Endpoints#1448

Merged
jcstein merged 3 commits intocelestiaorg:mainfrom
Chainode:main
Mar 6, 2024
Merged

Update mainnet.md with Chainode Tech Archive Endpoints#1448
jcstein merged 3 commits intocelestiaorg:mainfrom
Chainode:main

Conversation

@Chainode
Copy link
Copy Markdown
Contributor

@Chainode Chainode commented Feb 29, 2024

It would also be good to add a WebSocket section - sometimes such a connection is preffered.

Here is our endpoint for WebSocket: wss://celestia-ws.chainode.tech:33373/websocket

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • New Features
    • Added new RPC, API, gRPC, and WebSocket endpoints for Mainnet Beta participation.

It would also be good to add a WebSocket section - sometimes such a connection is preffered. 

Here is our endpoint for WebSocket: wss://celestia-ws.chainode.tech:33373/websocket
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 29, 2024

Walkthrough

This update introduces new endpoints for Mainnet Beta participation, enhancing connectivity and integration capabilities. The added RPC, API, gRPC, and WebSocket endpoints expand access options and service quality for users and developers engaging with Mainnet Beta.

Changes

File Path Change Summary
nodes/mainnet.md Added new RPC endpoint, API endpoint, gRPC endpoint, and WebSocket endpoint for Mainnet Beta participation.

🌟🐇✨
In the digital meadow, under the moon's bright gaze,
New paths unfold, in the blockchain's intricate maze.
With a hop and a skip, the rabbit declares with delight,
"To the Mainnet Beta, these endpoints take flight!"
Let's connect and explore, in this world so vast,
For in the realm of code, the future is cast.
🚀🌌✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 67c87da and 6ef3f5d.
Files selected for processing (1)
  • nodes/mainnet.md (3 hunks)
Additional comments: 3
nodes/mainnet.md (3)
  • 120-120: The addition of the RPC endpoint celestia-rpc.chainode.tech:33373 is consistent with the PR objectives. However, it's crucial to ensure that the port number and the protocol used (http or https) are correct and match the standard practices for RPC endpoints. If the endpoint is intended to be accessed over HTTPS, specifying the protocol might be necessary for clarity and security.
  • 144-144: The API endpoint celestia-api.chainode.tech has been added without specifying a port number or protocol (http or https). For consistency and to avoid confusion, it might be beneficial to specify the protocol, especially if the endpoint supports secure connections. This clarification will help users understand how to interact with the endpoint securely.
  • 167-167: The addition of the gRPC endpoint celestia-grpc.chainode.tech:443 is clear and includes the port number, which is standard for gRPC connections over HTTPS. This addition aligns with the PR objectives and provides a secure way for users to interact with the Mainnet using gRPC. No further action is required here.

@jcstein
Copy link
Copy Markdown
Member

jcstein commented Mar 1, 2024

thanks for the PR and suggestion. would you like to add a websockets section in this PR?

Comment thread nodes/mainnet.md
Co-authored-by: Josh Stein <46639943+jcstein@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 6ef3f5d and 0b932a4.
Files selected for processing (1)
  • nodes/mainnet.md (3 hunks)
Additional comments: 3
nodes/mainnet.md (3)
  • 120-120: The addition of the RPC endpoint celestia-rpc.chainode.tech:33373 is correctly formatted and follows the existing pattern of listing endpoints. Ensure that the port number and the protocol (assumed to be HTTP/HTTPS) are correct and match the service's configuration.
  • 167-167: The gRPC endpoint celestia-grpc.chainode.tech:443 is correctly added and includes the port number, which is standard for gRPC connections over HTTPS. This addition is consistent with the format of other gRPC endpoints listed.
  • 169-171: The WebSocket endpoint wss://celestia-ws.chainode.tech:33373/websocket is correctly added under a new section titled "WebSocket endpoints." This addition is in response to a comment by jcstein, suggesting the creation of a dedicated section for WebSocket endpoints. The use of wss:// indicates secure WebSocket connections, which is good for security. The formatting and placement of this endpoint are appropriate.

Comment thread nodes/mainnet.md Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 0b932a4 and fbc0255.
Files selected for processing (1)
  • nodes/mainnet.md (3 hunks)
Additional comments: 4
nodes/mainnet.md (4)
  • 120-120: The addition of the new RPC endpoint celestia-rpc.chainode.tech:33373 is correctly formatted and aligns with the PR's objectives to enhance Mainnet connectivity options.
  • 144-144: The addition of the new API endpoint https://celestia-api.chainode.tech correctly specifies the protocol (https://), aligning with the PR's objectives and discussions about endpoint protocol specification.
  • 167-167: The addition of the new gRPC endpoint celestia-grpc.chainode.tech:443 is correctly formatted and uses the standard port for secure connections, enhancing the documentation's completeness and accuracy.
  • 169-171: The addition of the new WebSocket endpoint wss://celestia-ws.chainode.tech:33373/websocket under a dedicated section improves the documentation's structure and clarity. The use of wss:// correctly indicates a secure WebSocket connection.

@jcstein jcstein merged commit 1554acc into celestiaorg:main Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants