Update mainnet.md with Chainode Tech Archive Endpoints#1448
Update mainnet.md with Chainode Tech Archive Endpoints#1448jcstein merged 3 commits intocelestiaorg:mainfrom
Conversation
It would also be good to add a WebSocket section - sometimes such a connection is preffered. Here is our endpoint for WebSocket: wss://celestia-ws.chainode.tech:33373/websocket
WalkthroughThis update introduces new endpoints for Mainnet Beta participation, enhancing connectivity and integration capabilities. The added RPC, API, gRPC, and WebSocket endpoints expand access options and service quality for users and developers engaging with Mainnet Beta. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- nodes/mainnet.md (3 hunks)
Additional comments: 3
nodes/mainnet.md (3)
- 120-120: The addition of the RPC endpoint
celestia-rpc.chainode.tech:33373is consistent with the PR objectives. However, it's crucial to ensure that the port number and the protocol used (httporhttps) are correct and match the standard practices for RPC endpoints. If the endpoint is intended to be accessed over HTTPS, specifying the protocol might be necessary for clarity and security.- 144-144: The API endpoint
celestia-api.chainode.techhas been added without specifying a port number or protocol (httporhttps). For consistency and to avoid confusion, it might be beneficial to specify the protocol, especially if the endpoint supports secure connections. This clarification will help users understand how to interact with the endpoint securely.- 167-167: The addition of the gRPC endpoint
celestia-grpc.chainode.tech:443is clear and includes the port number, which is standard for gRPC connections over HTTPS. This addition aligns with the PR objectives and provides a secure way for users to interact with the Mainnet using gRPC. No further action is required here.
|
thanks for the PR and suggestion. would you like to add a websockets section in this PR? |
Co-authored-by: Josh Stein <46639943+jcstein@users.noreply.github.com>
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- nodes/mainnet.md (3 hunks)
Additional comments: 3
nodes/mainnet.md (3)
- 120-120: The addition of the RPC endpoint
celestia-rpc.chainode.tech:33373is correctly formatted and follows the existing pattern of listing endpoints. Ensure that the port number and the protocol (assumed to be HTTP/HTTPS) are correct and match the service's configuration.- 167-167: The gRPC endpoint
celestia-grpc.chainode.tech:443is correctly added and includes the port number, which is standard for gRPC connections over HTTPS. This addition is consistent with the format of other gRPC endpoints listed.- 169-171: The WebSocket endpoint
wss://celestia-ws.chainode.tech:33373/websocketis correctly added under a new section titled "WebSocket endpoints." This addition is in response to a comment byjcstein, suggesting the creation of a dedicated section for WebSocket endpoints. The use ofwss://indicates secure WebSocket connections, which is good for security. The formatting and placement of this endpoint are appropriate.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- nodes/mainnet.md (3 hunks)
Additional comments: 4
nodes/mainnet.md (4)
- 120-120: The addition of the new RPC endpoint
celestia-rpc.chainode.tech:33373is correctly formatted and aligns with the PR's objectives to enhance Mainnet connectivity options.- 144-144: The addition of the new API endpoint
https://celestia-api.chainode.techcorrectly specifies the protocol (https://), aligning with the PR's objectives and discussions about endpoint protocol specification.- 167-167: The addition of the new gRPC endpoint
celestia-grpc.chainode.tech:443is correctly formatted and uses the standard port for secure connections, enhancing the documentation's completeness and accuracy.- 169-171: The addition of the new WebSocket endpoint
wss://celestia-ws.chainode.tech:33373/websocketunder a dedicated section improves the documentation's structure and clarity. The use ofwss://correctly indicates a secure WebSocket connection.
It would also be good to add a WebSocket section - sometimes such a connection is preffered.
Here is our endpoint for WebSocket: wss://celestia-ws.chainode.tech:33373/websocket
Overview
Checklist
Summary by CodeRabbit