Conversation
WalkthroughThe update broadens Blobstream's capabilities, allowing its light client to be deployed across various blockchain layers, thus facilitating access to Celestia's Data Availability services. A note of caution is also introduced, highlighting the experimental stage of Blobstream. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- developers/blobstream.md (2 hunks)
Additional comments: 6
developers/blobstream.md (6)
- 17-18: The expansion of Blobstream's functionality to allow any ecosystem to deploy a Blobstream light client onchain is clearly stated. This is a significant update that aligns with the PR objectives. However, it would be beneficial to include examples or use cases to illustrate how this functionality can be leveraged by L2s and L3s for accessing Data Availability (DA) from Celestia.
- 27-29: The cautionary note regarding the experimental nature of Blobstream is appropriately added. This is crucial for setting the right expectations for users. To enhance this section, consider linking to a detailed document or page that outlines the known limitations, risks, and the current state of development. This would provide users with a more comprehensive understanding of what "experimental" entails in this context.
- 24-32: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [30-58]
The comparison between Blobstream and data availability committees (DACs) is informative and well-structured, offering insights into decentralization, security, verification mechanisms, flexibility, and scalability. This section effectively highlights the advantages of Blobstream over DACs. To further improve, consider adding a brief section on potential use cases or scenarios where DACs might still be preferred or necessary, providing a balanced view.
- 14-21: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [60-86]
The explanation of Blobstream X, including its implementation and the role of ZK proofs, is detailed and technical. This section does a good job of explaining the technology and its implications for Ethereum and Celestia interoperability. For clarity, consider adding a glossary or a section with definitions for technical terms like "ZK proofs," "Merkle roots," and "CometBFT consensus protocol" for readers who may not be familiar with these concepts.
- 14-21: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [95-157]
The integration guide for Blobstream X is practical and provides clear directions for developers. Including links to repositories, contracts, and additional resources is helpful. To enhance this section, consider adding a troubleshooting guide or FAQ section to address common issues or questions developers might encounter during integration. This could improve the usability of the documentation.
- 14-21: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [161-173]
The listing of deployed contracts on various testnets is a valuable resource for developers. It's good practice to keep this information up-to-date. Ensure that the contract addresses and links are regularly verified to prevent any confusion or issues for developers trying to interact with Blobstream X contracts.
Verification successful
The verification process involved checking the deployment status and details of the Blobstream X contracts on various Ethereum testnets. The verification was conducted by running shell scripts to fetch pages from Etherscan and Arbiscan for the specified contract addresses. The results provided detailed HTML pages for each contract address on the respective block explorers.
From the provided output, it's clear that the contract addresses are accessible on the block explorers, indicating that they are deployed and have associated transactions or information. However, due to the nature of the output (complete HTML pages), specific details about the deployment status, such as whether the contracts are actively being used or their current state, cannot be directly inferred without further processing or manual review.
Given the constraints and the nature of the output, the most accurate conclusion is that the contract addresses are indeed deployed on the specified networks, as they are recognized by the block explorers. However, for detailed analysis regarding their activity, functionality, or any specific contract details, a manual review of the provided block explorer pages or further targeted queries would be necessary.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the contract addresses are still valid and deployed curl https://etherscan.io/address/0xTODO curl https://arbiscan.io/address/0xA83ca7775Bc2889825BcDeDfFa5b758cf69e8794#events curl https://sepolia.arbiscan.io/address/0xc3e209eb245Fd59c8586777b499d6A665DF3ABD2#eventsLength of output: 510123
…stream (#1489) * docs: add documentation on how to build rollups on Celestia * docs: remove question * docs: one -> value * docs: explain more the proofs + reformating * docs: set ETA * docs: expand on protobuf deserialisation * docs: expand on protobuf deserialisation * docs: rewrite, reorganise, explain * docs: review feedback * docs: grammar * docs: remove new lines * docs: add links to inclusion proofs * docs: update blobstream contract addresses (#1485) Replaces #1482 * ci: test removing the CNAME file for clean up of previews. (#1493) * docs: update blobstream (#1495) * docs: update bubs-testnet.md with new URIs * docs: add status page and bridge * docs: comment out thirdweb bc chain is different now * docs: update gm portal and contract guides for bubs * docs: add mocha and namespace * docs: add bridging context * [GH Action] Update release tags and commit SHAs for arabica (#1497) * [automated GH action] update latest release tags & commit sha (arabica) * Update .vitepress/constants/arabica_versions.js --------- Co-authored-by: jcstein <jcstein@users.noreply.github.com> Co-authored-by: Josh Stein <46639943+jcstein@users.noreply.github.com> * [GH Action] Update release tags and commit SHAs for mocha (#1498) * [automated GH action] update latest release tags & commit sha (mocha) * Update .vitepress/constants/mocha_versions.js --------- Co-authored-by: jcstein <jcstein@users.noreply.github.com> Co-authored-by: Josh Stein <46639943+jcstein@users.noreply.github.com> * docs: update go constants for arabiac and mocha * docs: update to make install for all types of machines (#1502) * feat: Update node-tutorial.md (#1478) this is live in v0.13.0 i think, cc @vgonkivs for review * feat: split consensus node page (#1472) * docs: split consensus node page * docs: setup to set up * docs: setup to set up 2 * docs: coderabbit reviews * docs: change to everywhere * docs: add backlink --------- Co-authored-by: jcstein <mail@jcstein.dev> * docs: rollup available link Vitalik (#1505) * docs: rollup link Vitalik * docs: changes follow suggestion for example giving comma * docs: Fix proof query example errors (#1504) * Add missing return statement in toRowProofs function * fix dataRoot slice out of range error * fixes another missing return in toRowProofs * docs: fix blobstream proof queries code (#1506) * docs: initial commit, needs revision * docs: remove old light node config * docs: edits and refactor page * docs: minor copy edit * docs: cleanup for new deployment guide * docs: todos for deployment guide * docs: edit intro * docs: step 1-2 * docs: deploy steps and table * docs: remainder of deploy steps draft * docs: change style of quickstart to Quickstart: Deploy an Orbit rollup * docs: add todos * docs: update contract addresses * docs: using light node, namespace, auth token * docs: add link to arb doc * docs: add todo * docs: resolve build errs * docs: add bridging guide * docs: small revisions * docs: copy edits * docs: deploy revision * docs: fix blobstream address * docs: add alchemy rpc section * docs: note about opening ports in docker * docs: bump celestia-node version * docs: edit l1 to l2 * docs: add newer success logs * feat: add full node page to docs for orbit * feat: write out full node page * docs: more info on validatorfn page * docs: update wasm root * docs: update nitro release * docs: use v2.3.1-rc.1 everywhere for nitro * docs: edit out 'click heres' * fix: links * docs: add eth-rpc variable * docs: coderabbit suggestions * docs: clarify wss * docs: swap steps 6 and 7 for deploy doc * docs: edit wss section * docs: add more context for wss * docs: improve md readabliity in table * docs: update deployui url * docs: update ui url * docs: we'll use in next step * docs: updates * docs: add fn * [GH Action] Update release tags and commit SHAs for mainnet (#1507) * [automated GH action] update latest release tags & commit sha (mainnet) * Update .vitepress/constants/mainnet_versions.js --------- Co-authored-by: jcstein <jcstein@users.noreply.github.com> Co-authored-by: Josh Stein <46639943+jcstein@users.noreply.github.com> * docs: update newmetric endpoints Resolves #1501 * docs: update orbit URL * docs: coderabbit suggestions * docs: add op raspberry testnet * [GH Action] Update release tags and commit SHAs for arabica (#1511) * [automated GH action] update latest release tags & commit sha (arabica) * Apply suggestions from code review --------- Co-authored-by: jcstein <jcstein@users.noreply.github.com> Co-authored-by: Josh Stein <46639943+jcstein@users.noreply.github.com> * docs: add sepolia -> mocha (#1512) * fix typo in arabica-devnet page (#1513) * [WIP] docs: add audits for blobstream x (#1491) * docs: add audits for blobstream x * docs: add veridise audit * Update rollup-overview.md (#1516) * feat: restructure developers category (#1515) * feat: drafting buttons * fix: color of btn * feat: add note text optional * feat: rename to build-whatever.md * fix: copy * feat: category shuffle * fix: suggestions from code review * feat: add vistara * Apply suggestions from code review * fix: typo * feat: add alt texts * fix: typo * feat: aria-labels * docs: shuffle intro * feat: add celestia-node.sh script * fix: clarify section vs. tutorial * feat: exit if dir change fails * Update mocha_versions.js (#1529) * Update mocha_versions.js * Update mocha_versions.js * Add Grove archival endpoints to `nodes/mainnet.md` (#1525) * Add Grove to nodes/mainnet.md * Apply suggestions from code review Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update nodes/mainnet.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Store image in src code * Add description of archival nodes * Apply suggestions from code review * Apply suggestions from code review * Update nodes/mainnet.md --------- Co-authored-by: joshcs.eth <46639943+jcstein@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * docs: fix typos (#1526) * fix typo * fix typo * fix typo * fix typo * fix typos * fix typo * fix typo * fix typos * fix typos * fix typos * fix typos * fix typo * fix typo * fix typo Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Apply suggestions from code review --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: joshcs.eth <46639943+jcstein@users.noreply.github.com> * Update mainnet.md (#1527) Add noders endpoints * Update mocha-testnet.md (#1528) * Update mocha-testnet.md Add noders endpoints * Fixed link to endpoint * Apply suggestions from code review --------- Co-authored-by: joshcs.eth <46639943+jcstein@users.noreply.github.com> * fix: veridise path * feat: add to menu * docs: begin lint * docs: remove duplicate headings * docs: clarify duplicate headings * docs: better headings * docs: mention blobstream rollups docs in the blobstream overview --------- Co-authored-by: Josh Stein <46639943+jcstein@users.noreply.github.com> Co-authored-by: Matthew Sevey <mjsevey@gmail.com> Co-authored-by: jcstein <mail@jcstein.dev> Co-authored-by: celestia-bot <136652805+celestia-bot@users.noreply.github.com> Co-authored-by: jcstein <jcstein@users.noreply.github.com> Co-authored-by: Levai Mackenzie Ágbàrà <levaiagbara@gmail.com> Co-authored-by: Guspan Tanadi <36249910+guspan-tanadi@users.noreply.github.com> Co-authored-by: Kassius <34594014+CryptoKass@users.noreply.github.com> Co-authored-by: Ratan Kaliani <ratankaliani@berkeley.edu> Co-authored-by: Callum Waters <cmwaters19@gmail.com> Co-authored-by: Alex Beckett <75361908+alex-beckett@users.noreply.github.com> Co-authored-by: mindstyle85 <55639830+mindstyle85@users.noreply.github.com> Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: omahs <73983677+omahs@users.noreply.github.com> Co-authored-by: Alex Moskaleu (SeptimA) <dudava45@gmail.com>
2 participants
Overview
Checklist
Summary by CodeRabbit