Skip to content

docs: update newmetric endpoints#1503

Merged
Bidon15 merged 1 commit intomainfrom
jcstein-patch-2
Apr 4, 2024
Merged

docs: update newmetric endpoints#1503
Bidon15 merged 1 commit intomainfrom
jcstein-patch-2

Conversation

@jcstein
Copy link
Copy Markdown
Member

@jcstein jcstein commented Mar 29, 2024

Resolves #1501

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • Chores
    • Updated Celestia node URLs for better connectivity and reliability.

@jcstein jcstein self-assigned this Mar 29, 2024
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 29, 2024

Walkthrough

This update involves transitioning Celestia node endpoints from public-celestia-mocha4-consensus.numia.xyz to a new domain mocha-4-consensus.mesa.newmetric.xyz. The modification affects configurations related to ports 26657 and 9090, ensuring that both ports now point to the updated endpoint across various files.

Changes

Files Affected Change Summary
Various files Replaced public-celestia-mocha4-consensus.numia.xyz with mocha-4-consensus.mesa.newmetric.xyz for ports 26657 and 9090

Assessment against linked issues

Objective Addressed Explanation
docs: add newmetric mocha endpoints (#1501)

Poem

"In the digital meadow, under the byte-sized sun,
A change was made, a new path begun.
From Numia's lands to Newmetric's embrace,
Ports a'flowing, in the cybernetic space.
🐇 CodeRabbit hops along, with a gleeful cheer,
For the nodes are aligned, the data crystal clear.
In unity, they connect, in the vast net's expanse,
A testament to progress, in the digital dance."

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 29, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-04-04 19:04 UTC

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 5a5d43e and 0b7f09a.
Files selected for processing (1)
  • nodes/mocha-testnet.md (3 hunks)
Additional Context Used
Additional comments not posted (4)
nodes/mocha-testnet.md (4)

72-72: The URL public-celestia-mocha4-consensus.numia.xyz has been replaced with mocha-4-consensus.mesa.newmetric.xyz to reflect the new newmetric endpoints. This change is crucial for ensuring users connect to the correct testnet endpoints.


84-84: The RPC endpoint URL has been updated to mocha-4-consensus.mesa.newmetric.xyz:26657, aligning with the new newmetric endpoints. This ensures accurate documentation for users interacting with Celestia's nodes.


126-126: The gRPC endpoint URL mocha-4-consensus.mesa.newmetric.xyz:9090 has been updated, reflecting the transition to the new newmetric endpoints. This update is essential for users utilizing gRPC to interact with Celestia Node.


69-75: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [13-13]

The term "Arabica devnet" is correctly used in the context of Celestia networks. However, ensure that all external links, such as ./arabica-devnet.md, are valid and accessible to prevent broken links in the documentation.

Verification successful

The file arabica-devnet.md exists within the repository, located under the nodes directory. This confirms that the link to ./arabica-devnet.md in the documentation is valid, assuming that the referencing file is also within the nodes directory or has a correct relative path to it. Therefore, the review comment regarding the verification of the existence and accessibility of arabica-devnet.md is supported by the evidence found.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Verify the existence of 'arabica-devnet.md' in the documentation directory.
fd arabica-devnet.md src/docs/

Length of output: 129



Script:

#!/bin/bash
# Search the entire repository for 'arabica-devnet.md' without assuming a specific directory.
fd arabica-devnet.md

Length of output: 46

Comment thread nodes/mocha-testnet.md
Comment on lines 69 to 75
:::

- `public-celestia-mocha4-consensus.numia.xyz`
- `mocha-4-consensus.mesa.newmetric.xyz`
- `full.consensus.mocha-4.celestia-mocha.com`
- `consensus-full-mocha-4.celestia-mocha.com`
- `rpc-mocha.pops.one`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [64-64]

The phrase "Bridge nodes Mentioned below" starts with an uppercase character after a tip block. Consider rephrasing for consistency with the rest of the document's style.

- :::tip Bridge nodes Mentioned below RPC endpoints do not guarantee you the download of full blocks from them.
+ :::tip Bridge nodes mentioned below RPC endpoints do not guarantee you the download of full blocks from them.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [67-67]

The phrase "in order to" could be simplified to "to" for conciseness without losing meaning.

- We advise that if you are running a bridge node, that you also run a local [full consensus node](./consensus-node.md) in order to download full blocks from it.
+ We advise that if you are running a bridge node, you also run a local [full consensus node](./consensus-node.md) to download full blocks from it.

@jcstein jcstein requested a review from Bidon15 April 1, 2024 14:12
@Bidon15 Bidon15 merged commit 0de9d4b into main Apr 4, 2024
@Bidon15 Bidon15 deleted the jcstein-patch-2 branch April 4, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: add newmetric mocha endpoints

2 participants