Skip to content

developers: clarify why grpc endpoint needed for light node#1557

Merged
jcstein merged 4 commits intocelestiaorg:mainfrom
renaynay:clarify-grpc
May 2, 2024
Merged

developers: clarify why grpc endpoint needed for light node#1557
jcstein merged 4 commits intocelestiaorg:mainfrom
renaynay:clarify-grpc

Conversation

@renaynay
Copy link
Copy Markdown
Member

@renaynay renaynay commented May 2, 2024

Summary by CodeRabbit

  • Documentation
    • Enhanced the tutorial on connecting to a public core endpoint for the Celestia Light node, emphasizing access to state queries, transactions, and other state-related queries.
    • Added information about connecting to a public core endpoint using --core.ip string in various node tutorials to provide access to state queries and transactions.

@renaynay renaynay requested a review from jcstein May 2, 2024 06:42
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented May 2, 2024

Warning

Rate Limit Exceeded

@jcstein has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 55 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between bea1ab4 and 6dfc327.

Walkthrough

The update focuses on enhancing the functionality of connecting to public core endpoints across various node types in the Celestia network. It emphasizes enabling access to state queries, transactions, and other state-related functionalities through the utilization of --core.ip string for connecting to public core endpoints.

Changes

File Path Change Description
nodes/bridge-node.md Introduces information on connecting to public core endpoint for state queries.
nodes/full-storage-node.md Adds details on connecting to public core endpoint for state queries.
nodes/light-node.md Enhances light node connectivity to public core endpoints for state queries.

🐰🌟
Through nodes and endpoints, a digital dance,
Celestia's light nodes get a chance.
State queries, transactions, all in line,
Connecting realms, a code divine.
In the world of tech, where rabbits play,
Each update brings a brighter day!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Comment thread developers/node-tutorial.md Outdated
@jcstein
Copy link
Copy Markdown
Member

jcstein commented May 2, 2024

thank you @renaynay - I've added some redundancy for this explanation. one thought, should we just call it a "core endpoint" instead of a "public core endpoint"?

Copy link
Copy Markdown
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add back "public" if you think it is necessary. I am hoping it may reduce confusion for users and make it more clear they can use any "core endpoint", not just public ones

@jcstein jcstein merged commit 9aa57ae into celestiaorg:main May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants