Skip to content

feat: updating prompt scavenger#1581

Merged
jcstein merged 4 commits intomainfrom
prompt-scavenger-update
May 28, 2024
Merged

feat: updating prompt scavenger#1581
jcstein merged 4 commits intomainfrom
prompt-scavenger-update

Conversation

@distractedm1nd
Copy link
Copy Markdown
Contributor

@distractedm1nd distractedm1nd commented May 23, 2024 •
edited by coderabbitai bot
Loading

Updates prompt scavenger tutorial to use the latest version of node, and is pretty much completely reworked from the ground up for API ease. Still unsure on some things though. Especially how to handle the OPENAI_KEY env variable. Setting up a .env is too much imo, but passing it along with the other parameters is just as annoying.

Lots of little things as well with copy or the tutorial itself that I hope can get improved in review!

The final project looks like this:
https://github.com/distractedm1nd/prompt-scavenger/blob/main/main.go

Summary by CodeRabbit

  • Documentation
    • Renamed "Golang client library tutorial" to "Golang Client Library Guide" for better clarity and consistency.
    • Updated commands in the "Prompt Scavenger" guide to reflect the latest network and configuration changes.

@distractedm1nd distractedm1nd added the enhancement New feature or request label May 23, 2024
@distractedm1nd distractedm1nd requested a review from jcstein May 23, 2024 13:41
@distractedm1nd distractedm1nd self-assigned this May 23, 2024
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented May 23, 2024 •
edited
Loading

Walkthrough

The recent updates include renaming a tutorial title for clarity and consistency, and modifying commands in a developer guide to reflect the latest network configurations. These changes ensure better readability and up-to-date instructions for developers working with the Golang client library and the Celestia network.

Changes

Files Change Summary
developers/golang-client-tutorial.md Renamed tutorial title from "Golang client library tutorial" to "Golang Client Library Guide".
developers/prompt-scavenger.md Updated Celestia network commands to use the "arabica" network and revised the command structure.

Poem

In the code's vast, boundless sea,
We tweak and change with subtle glee.
From "tutorial" to "guide," we steer,
With "arabica" commands, we persevere.
A rabbit's touch, so swift and light,
Ensures our code's future is bright. 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to full the review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 23, 2024 •
edited
Loading

PR Preview Action v1.4.7
🚀 Deployed preview to https://celestiaorg.github.io/docs-preview/./pr-1581/
on branch main at 2024-05-28 14:41 UTC

@distractedm1nd distractedm1nd requested a review from YazzyYaz May 23, 2024 13:47
coderabbitai[bot]
coderabbitai bot reviewed May 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

Outside diff range and nitpick comments (2)
developers/golang-client-tutorial.md (2)

Line range hint 23-23: Consider varying the sentence structure to enhance readability.

- To get your auth token, see this [guide](./node-tutorial.md#auth-token). To run your node without an auth token, you can use the `--rpc.skip-auth` flag when starting your node.
+ To obtain your auth token, refer to this [guide](./node-tutorial.md#auth-token). Alternatively, you can run your node without an auth token using the `--rpc.skip-auth` flag.

Line range hint 39-39: Replace hard tabs with spaces for consistency in indentation.

- <hard tabs>
+ <spaces>

Also applies to: 43-43, 44-44, 45-45, 50-50, 51-51, 52-52, 53-53, 55-55, 56-56, 57-57, 58-58, 59-59, 61-61, 62-62, 63-63, 64-64, 65-65, 67-67, 68-68, 69-69, 70-70, 71-71, 73-73, 75-75, 76-76, 77-77, 78-78, 79-79, 81-81, 82-82, 97-97, 98-98, 99-99, 100-100, 102-102, 103-103, 104-104, 105-105, 106-106, 108-108, 109-109, 110-110, 111-111, 112-112, 114-114, 115-115, 116-116, 117-117, 118-118, 119-119, 120-120, 121-121, 123-123, 124-124, 125-125, 126-126, 127-127, 138-138, 139-139, 140-140, 141-141, 143-143, 144-144, 145-145, 146-146, 147-147, 149-149, 150-150

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 0041149 and d8f52d1.
Files selected for processing (2)
  • developers/golang-client-tutorial.md (1 hunks)
  • developers/prompt-scavenger.md (2 hunks)
Additional Context Used
LanguageTool (7)
developers/golang-client-tutorial.md (2)

Near line 23: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... need the node URL and your auth token. To get your auth token, see this [guide](....

Near line 23: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...guide. To run your node without an auth token, yo...

developers/prompt-scavenger.md (5)

Near line 77: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...s command in a different terminal window, because the node has to be running for it to wo...

Near line 82: Consider a shorter alternative to avoid wordiness.
Context: ...o OpenAI](https://platform.openai.com/) in order to sign up for an account and generate an ...

Near line 139: The word “setup” is a noun. The verb is spelled with a space.
Context: ... the retrieved blob data } ``` Here we setup all required libraries we need to use p...

Near line 180: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ...the retrieved blob data } ``` Next, we need to create some utility functions that will...

Near line 288: As a shorter alternative for ‘able to’, consider using “can”.
Context: ... the given height. ::: Now our program is able to create the namespace and blob, then sub...

Markdownlint (219)
developers/golang-client-tutorial.md (71)

39: Column: 1
Hard tabs

40: Column: 1
Hard tabs

41: Column: 1
Hard tabs

43: Column: 1
Hard tabs

44: Column: 1
Hard tabs

45: Column: 1
Hard tabs

50: Column: 1
Hard tabs

51: Column: 1
Hard tabs

52: Column: 1
Hard tabs

53: Column: 1
Hard tabs

55: Column: 1
Hard tabs

56: Column: 1
Hard tabs

57: Column: 1
Hard tabs

58: Column: 1
Hard tabs

59: Column: 1
Hard tabs

61: Column: 1
Hard tabs

62: Column: 1
Hard tabs

63: Column: 1
Hard tabs

64: Column: 1
Hard tabs

65: Column: 1
Hard tabs

67: Column: 1
Hard tabs

68: Column: 1
Hard tabs

69: Column: 1
Hard tabs

70: Column: 1
Hard tabs

71: Column: 1
Hard tabs

73: Column: 1
Hard tabs

75: Column: 1
Hard tabs

76: Column: 1
Hard tabs

77: Column: 1
Hard tabs

78: Column: 1
Hard tabs

79: Column: 1
Hard tabs

81: Column: 1
Hard tabs

82: Column: 1
Hard tabs

97: Column: 1
Hard tabs

98: Column: 1
Hard tabs

99: Column: 1
Hard tabs

100: Column: 1
Hard tabs

102: Column: 1
Hard tabs

103: Column: 1
Hard tabs

104: Column: 1
Hard tabs

105: Column: 1
Hard tabs

106: Column: 1
Hard tabs

108: Column: 1
Hard tabs

109: Column: 1
Hard tabs

110: Column: 1
Hard tabs

111: Column: 1
Hard tabs

112: Column: 1
Hard tabs

114: Column: 1
Hard tabs

115: Column: 1
Hard tabs

116: Column: 1
Hard tabs

117: Column: 1
Hard tabs

118: Column: 1
Hard tabs

119: Column: 1
Hard tabs

120: Column: 1
Hard tabs

121: Column: 1
Hard tabs

123: Column: 1
Hard tabs

124: Column: 1
Hard tabs

125: Column: 1
Hard tabs

126: Column: 1
Hard tabs

127: Column: 1
Hard tabs

138: Column: 1
Hard tabs

139: Column: 1
Hard tabs

140: Column: 1
Hard tabs

141: Column: 1
Hard tabs

143: Column: 1
Hard tabs

144: Column: 1
Hard tabs

145: Column: 1
Hard tabs

146: Column: 1
Hard tabs

147: Column: 1
Hard tabs

149: Column: 1
Hard tabs

150: Column: 1
Hard tabs

developers/prompt-scavenger.md (148)

49: Column: 29
Hard tabs

49: Column: 34
Hard tabs

49: Column: 39
Hard tabs

49: Column: 63
Hard tabs

50: Column: 29
Hard tabs

50: Column: 34
Hard tabs

50: Column: 39
Hard tabs

50: Column: 63
Hard tabs

116: Column: 1
Hard tabs

117: Column: 1
Hard tabs

118: Column: 1
Hard tabs

119: Column: 1
Hard tabs

120: Column: 1
Hard tabs

122: Column: 1
Hard tabs

123: Column: 1
Hard tabs

124: Column: 1
Hard tabs

125: Column: 1
Hard tabs

130: Column: 1
Hard tabs

131: Column: 1
Hard tabs

132: Column: 1
Hard tabs

133: Column: 1
Hard tabs

134: Column: 1
Hard tabs

135: Column: 1
Hard tabs

153: Column: 1
Hard tabs

154: Column: 1
Hard tabs

156: Column: 1
Hard tabs

157: Column: 1
Hard tabs

158: Column: 1
Hard tabs

159: Column: 1
Hard tabs

160: Column: 1
Hard tabs

162: Column: 1
Hard tabs

163: Column: 1
Hard tabs

164: Column: 1
Hard tabs

165: Column: 1
Hard tabs

166: Column: 1
Hard tabs

167: Column: 1
Hard tabs

168: Column: 1
Hard tabs

170: Column: 1
Hard tabs

171: Column: 1
Hard tabs

172: Column: 1
Hard tabs

173: Column: 1
Hard tabs

174: Column: 1
Hard tabs

175: Column: 1
Hard tabs

176: Column: 1
Hard tabs

189: Column: 1
Hard tabs

190: Column: 1
Hard tabs

191: Column: 1
Hard tabs

192: Column: 1
Hard tabs

193: Column: 1
Hard tabs

195: Column: 1
Hard tabs

196: Column: 1
Hard tabs

207: Column: 1
Hard tabs

208: Column: 1
Hard tabs

209: Column: 1
Hard tabs

210: Column: 1
Hard tabs

212: Column: 1
Hard tabs

213: Column: 1
Hard tabs

214: Column: 1
Hard tabs

215: Column: 1
Hard tabs

216: Column: 1
Hard tabs

218: Column: 1
Hard tabs

219: Column: 1
Hard tabs

220: Column: 1
Hard tabs

221: Column: 1
Hard tabs

222: Column: 1
Hard tabs

223: Column: 1
Hard tabs

225: Column: 1
Hard tabs

226: Column: 1
Hard tabs

228: Column: 1
Hard tabs

236: Column: 1
Hard tabs

237: Column: 1
Hard tabs

239: Column: 1
Hard tabs

240: Column: 1
Hard tabs

241: Column: 1
Hard tabs

242: Column: 1
Hard tabs

243: Column: 1
Hard tabs

245: Column: 1
Hard tabs

246: Column: 1
Hard tabs

247: Column: 1
Hard tabs

248: Column: 1
Hard tabs

249: Column: 1
Hard tabs

250: Column: 1
Hard tabs

251: Column: 1
Hard tabs

253: Column: 1
Hard tabs

254: Column: 1
Hard tabs

255: Column: 1
Hard tabs

256: Column: 1
Hard tabs

257: Column: 1
Hard tabs

258: Column: 1
Hard tabs

260: Column: 1
Hard tabs

261: Column: 1
Hard tabs

262: Column: 1
Hard tabs

263: Column: 1
Hard tabs

264: Column: 1
Hard tabs

266: Column: 1
Hard tabs

267: Column: 1
Hard tabs

268: Column: 1
Hard tabs

269: Column: 1
Hard tabs

270: Column: 1
Hard tabs

272: Column: 1
Hard tabs

274: Column: 1
Hard tabs

275: Column: 1
Hard tabs

276: Column: 1
Hard tabs

277: Column: 1
Hard tabs

278: Column: 1
Hard tabs

279: Column: 1
Hard tabs

280: Column: 1
Hard tabs

299: Column: 4
Hard tabs

300: Column: 5
Hard tabs

304: Column: 1
Hard tabs

317: Column: 8
Hard tabs

330: Column: 1
Hard tabs

331: Column: 1
Hard tabs

333: Column: 1
Hard tabs

334: Column: 1
Hard tabs

335: Column: 1
Hard tabs

336: Column: 1
Hard tabs

337: Column: 1
Hard tabs

339: Column: 1
Hard tabs

340: Column: 1
Hard tabs

341: Column: 1
Hard tabs

342: Column: 1
Hard tabs

343: Column: 1
Hard tabs

344: Column: 1
Hard tabs

345: Column: 1
Hard tabs

347: Column: 1
Hard tabs

348: Column: 1
Hard tabs

349: Column: 1
Hard tabs

350: Column: 1
Hard tabs

351: Column: 1
Hard tabs

352: Column: 1
Hard tabs

354: Column: 1
Hard tabs

355: Column: 1
Hard tabs

356: Column: 1
Hard tabs

357: Column: 1
Hard tabs

358: Column: 1
Hard tabs

360: Column: 1
Hard tabs

361: Column: 1
Hard tabs

362: Column: 1
Hard tabs

363: Column: 1
Hard tabs

364: Column: 1
Hard tabs

366: Column: 1
Hard tabs

367: Column: 1
Hard tabs

368: Column: 1
Hard tabs

369: Column: 1
Hard tabs

370: Column: 1
Hard tabs

372: Column: 1
Hard tabs

48: null
Fenced code blocks should have a language specified

Additional comments not posted (1)
developers/golang-client-tutorial.md (1)

7-7: Title change enhances clarity and consistency.

Comment thread developers/prompt-scavenger.md Outdated
Comment thread developers/prompt-scavenger.md
Comment thread developers/prompt-scavenger.md Outdated
Comment thread developers/prompt-scavenger.md Outdated
@distractedm1nd @coderabbitai
Apply suggestions from code review
032949f 
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
coderabbitai[bot]
coderabbitai bot reviewed May 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between d8f52d1 and 032949f.
Files selected for processing (1)
  • developers/prompt-scavenger.md (2 hunks)
Additional Context Used
LanguageTool (1)
developers/prompt-scavenger.md (1)

Near line 288: As a shorter alternative for ‘able to’, consider using “can”.
Context: ... the given height. ::: Now our program is able to create the namespace and blob, then sub...

Markdownlint (148)
developers/prompt-scavenger.md (148)

49: Column: 29
Hard tabs

49: Column: 34
Hard tabs

49: Column: 39
Hard tabs

49: Column: 63
Hard tabs

50: Column: 29
Hard tabs

50: Column: 34
Hard tabs

50: Column: 39
Hard tabs

50: Column: 63
Hard tabs

116: Column: 1
Hard tabs

117: Column: 1
Hard tabs

118: Column: 1
Hard tabs

119: Column: 1
Hard tabs

120: Column: 1
Hard tabs

122: Column: 1
Hard tabs

123: Column: 1
Hard tabs

124: Column: 1
Hard tabs

125: Column: 1
Hard tabs

130: Column: 1
Hard tabs

131: Column: 1
Hard tabs

132: Column: 1
Hard tabs

133: Column: 1
Hard tabs

134: Column: 1
Hard tabs

135: Column: 1
Hard tabs

153: Column: 1
Hard tabs

154: Column: 1
Hard tabs

156: Column: 1
Hard tabs

157: Column: 1
Hard tabs

158: Column: 1
Hard tabs

159: Column: 1
Hard tabs

160: Column: 1
Hard tabs

162: Column: 1
Hard tabs

163: Column: 1
Hard tabs

164: Column: 1
Hard tabs

165: Column: 1
Hard tabs

166: Column: 1
Hard tabs

167: Column: 1
Hard tabs

168: Column: 1
Hard tabs

170: Column: 1
Hard tabs

171: Column: 1
Hard tabs

172: Column: 1
Hard tabs

173: Column: 1
Hard tabs

174: Column: 1
Hard tabs

175: Column: 1
Hard tabs

176: Column: 1
Hard tabs

189: Column: 1
Hard tabs

190: Column: 1
Hard tabs

191: Column: 1
Hard tabs

192: Column: 1
Hard tabs

193: Column: 1
Hard tabs

195: Column: 1
Hard tabs

196: Column: 1
Hard tabs

207: Column: 1
Hard tabs

208: Column: 1
Hard tabs

209: Column: 1
Hard tabs

210: Column: 1
Hard tabs

212: Column: 1
Hard tabs

213: Column: 1
Hard tabs

214: Column: 1
Hard tabs

215: Column: 1
Hard tabs

216: Column: 1
Hard tabs

218: Column: 1
Hard tabs

219: Column: 1
Hard tabs

220: Column: 1
Hard tabs

221: Column: 1
Hard tabs

222: Column: 1
Hard tabs

223: Column: 1
Hard tabs

225: Column: 1
Hard tabs

226: Column: 1
Hard tabs

228: Column: 1
Hard tabs

236: Column: 1
Hard tabs

237: Column: 1
Hard tabs

239: Column: 1
Hard tabs

240: Column: 1
Hard tabs

241: Column: 1
Hard tabs

242: Column: 1
Hard tabs

243: Column: 1
Hard tabs

245: Column: 1
Hard tabs

246: Column: 1
Hard tabs

247: Column: 1
Hard tabs

248: Column: 1
Hard tabs

249: Column: 1
Hard tabs

250: Column: 1
Hard tabs

251: Column: 1
Hard tabs

253: Column: 1
Hard tabs

254: Column: 1
Hard tabs

255: Column: 1
Hard tabs

256: Column: 1
Hard tabs

257: Column: 1
Hard tabs

258: Column: 1
Hard tabs

260: Column: 1
Hard tabs

261: Column: 1
Hard tabs

262: Column: 1
Hard tabs

263: Column: 1
Hard tabs

264: Column: 1
Hard tabs

266: Column: 1
Hard tabs

267: Column: 1
Hard tabs

268: Column: 1
Hard tabs

269: Column: 1
Hard tabs

270: Column: 1
Hard tabs

272: Column: 1
Hard tabs

274: Column: 1
Hard tabs

275: Column: 1
Hard tabs

276: Column: 1
Hard tabs

277: Column: 1
Hard tabs

278: Column: 1
Hard tabs

279: Column: 1
Hard tabs

280: Column: 1
Hard tabs

299: Column: 4
Hard tabs

300: Column: 5
Hard tabs

304: Column: 1
Hard tabs

317: Column: 8
Hard tabs

330: Column: 1
Hard tabs

331: Column: 1
Hard tabs

333: Column: 1
Hard tabs

334: Column: 1
Hard tabs

335: Column: 1
Hard tabs

336: Column: 1
Hard tabs

337: Column: 1
Hard tabs

339: Column: 1
Hard tabs

340: Column: 1
Hard tabs

341: Column: 1
Hard tabs

342: Column: 1
Hard tabs

343: Column: 1
Hard tabs

344: Column: 1
Hard tabs

345: Column: 1
Hard tabs

347: Column: 1
Hard tabs

348: Column: 1
Hard tabs

349: Column: 1
Hard tabs

350: Column: 1
Hard tabs

351: Column: 1
Hard tabs

352: Column: 1
Hard tabs

354: Column: 1
Hard tabs

355: Column: 1
Hard tabs

356: Column: 1
Hard tabs

357: Column: 1
Hard tabs

358: Column: 1
Hard tabs

360: Column: 1
Hard tabs

361: Column: 1
Hard tabs

362: Column: 1
Hard tabs

363: Column: 1
Hard tabs

364: Column: 1
Hard tabs

366: Column: 1
Hard tabs

367: Column: 1
Hard tabs

368: Column: 1
Hard tabs

369: Column: 1
Hard tabs

370: Column: 1
Hard tabs

372: Column: 1
Hard tabs

48: null
Fenced code blocks should have a language specified

Additional comments not posted (3)
developers/prompt-scavenger.md (3)

43-43: Update the network initialization command to reflect the new network name.

82-82: Simplify the sentence for clarity as suggested in previous comments.

63-63: Ensure the --rpc.skip-auth parameter is correctly implemented in the backend to avoid security issues.

jcstein
jcstein reviewed May 24, 2024
View reviewed changes
Comment thread developers/prompt-scavenger.md Outdated
jcstein
jcstein reviewed May 24, 2024
View reviewed changes
Comment thread developers/prompt-scavenger.md

func main() {
// TODO
// TODO:
Copy link
Copy Markdown
Member

@jcstein jcstein May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot!

jcstein
jcstein reviewed May 24, 2024
View reviewed changes
Comment thread developers/golang-client-tutorial.md Outdated
jcstein
jcstein reviewed May 24, 2024
View reviewed changes
Comment thread developers/prompt-scavenger.md Outdated
jcstein
jcstein reviewed May 24, 2024
View reviewed changes
Comment thread developers/prompt-scavenger.md Outdated

```sh
echo $AUTH_TOKEN
celestia state balance
Copy link
Copy Markdown
Member

@jcstein jcstein May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this only on v0.14.x?

Copy link
Copy Markdown
Member

@jcstein jcstein May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/celestiaorg/celestia-node/releases/tag/v0.14.0-rc0

Copy link
Copy Markdown
Contributor Author

@distractedm1nd distractedm1nd May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah its been supported for a few versions i believe, its def pre v0.14.x but idk how old exactly

Copy link
Copy Markdown
Member

@jcstein jcstein May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

celestiaorg/celestia-node#3246 isn't this only included in v0.14.0-rc0?

@distractedm1nd @jcstein
Apply suggestions from code review
84f23c9 
Co-authored-by: joshcs.eth <46639943+jcstein@users.noreply.github.com>
coderabbitai[bot]
coderabbitai bot reviewed May 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Outside diff range and nitpick comments (2)
developers/golang-client-tutorial.md (2)

Line range hint 23-23: Consider varying the sentence structure to enhance readability.

The repeated use of "To" at the beginning of successive sentences could be rephrased for better flow. For example:

- To use the following methods, you will need the node URL and your auth token. To get your auth token, see this [guide](./node-tutorial.md#auth-token). To run your node without an auth token, you can use the `--rpc.skip-auth` flag when starting your node.
+ You will need the node URL and your auth token to use the following methods. For obtaining your auth token, refer to this [guide](./node-tutorial.md#auth-token). Alternatively, you can run your node without an auth token using the `--rpc.skip-auth` flag.

Line range hint 39-39: Replace hard tabs with spaces for consistency in indentation.

The use of hard tabs throughout the code snippets should be replaced with spaces to maintain consistency and improve readability. This is a common practice in many style guides to ensure that the code looks the same in different environments.

- <hard tabs>
+ <spaces>

Also applies to: 40-40, 41-41, 43-43, 44-44, 45-45, 50-50, 51-51, 52-52, 53-53, 55-55, 56-56, 57-57, 58-58, 59-59, 61-61, 62-62, 63-63, 64-64, 65-65, 67-67, 68-68, 69-69, 70-70, 71-71, 73-73, 75-75, 76-76, 77-77, 78-78, 79-79, 81-81, 82-82, 97-97, 98-98, 99-99, 100-100, 102-102, 103-103, 104-104, 105-105, 106-106, 108-108, 109-109, 110-110, 111-111, 112-112, 114-114, 115-115, 116-116, 117-117, 118-118, 119-119, 120-120, 121-121, 123-123, 124-124, 125-125, 138-138, 139-139, 140-140, 141-141, 143-143, 144-144, 145-145, 146-146, 147-147, 149-149, 150-150

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 032949f and 84f23c9.
Files selected for processing (2)
  • developers/golang-client-tutorial.md (1 hunks)
  • developers/prompt-scavenger.md (2 hunks)
Additional Context Used
LanguageTool (3)
developers/golang-client-tutorial.md (2)

Near line 23: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... need the node URL and your auth token. To get your auth token, see this [guide](....
Rule ID: ENGLISH_WORD_REPEAT_BEGINNING_RULE

Near line 23: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...guide. To run your node without an auth token, yo...
Rule ID: ENGLISH_WORD_REPEAT_BEGINNING_RULE

developers/prompt-scavenger.md (1)

Near line 288: As a shorter alternative for ‘able to’, consider using “can”.
Context: ... the given height. ::: Now our program is able to create the namespace and blob, then sub...
Rule ID: BE_ABLE_TO

Markdownlint (219)
developers/golang-client-tutorial.md (71)

39: Column: 1
Hard tabs

40: Column: 1
Hard tabs

41: Column: 1
Hard tabs

43: Column: 1
Hard tabs

44: Column: 1
Hard tabs

45: Column: 1
Hard tabs

50: Column: 1
Hard tabs

51: Column: 1
Hard tabs

52: Column: 1
Hard tabs

53: Column: 1
Hard tabs

55: Column: 1
Hard tabs

56: Column: 1
Hard tabs

57: Column: 1
Hard tabs

58: Column: 1
Hard tabs

59: Column: 1
Hard tabs

61: Column: 1
Hard tabs

62: Column: 1
Hard tabs

63: Column: 1
Hard tabs

64: Column: 1
Hard tabs

65: Column: 1
Hard tabs

67: Column: 1
Hard tabs

68: Column: 1
Hard tabs

69: Column: 1
Hard tabs

70: Column: 1
Hard tabs

71: Column: 1
Hard tabs

73: Column: 1
Hard tabs

75: Column: 1
Hard tabs

76: Column: 1
Hard tabs

77: Column: 1
Hard tabs

78: Column: 1
Hard tabs

79: Column: 1
Hard tabs

81: Column: 1
Hard tabs

82: Column: 1
Hard tabs

97: Column: 1
Hard tabs

98: Column: 1
Hard tabs

99: Column: 1
Hard tabs

100: Column: 1
Hard tabs

102: Column: 1
Hard tabs

103: Column: 1
Hard tabs

104: Column: 1
Hard tabs

105: Column: 1
Hard tabs

106: Column: 1
Hard tabs

108: Column: 1
Hard tabs

109: Column: 1
Hard tabs

110: Column: 1
Hard tabs

111: Column: 1
Hard tabs

112: Column: 1
Hard tabs

114: Column: 1
Hard tabs

115: Column: 1
Hard tabs

116: Column: 1
Hard tabs

117: Column: 1
Hard tabs

118: Column: 1
Hard tabs

119: Column: 1
Hard tabs

120: Column: 1
Hard tabs

121: Column: 1
Hard tabs

123: Column: 1
Hard tabs

124: Column: 1
Hard tabs

125: Column: 1
Hard tabs

126: Column: 1
Hard tabs

127: Column: 1
Hard tabs

138: Column: 1
Hard tabs

139: Column: 1
Hard tabs

140: Column: 1
Hard tabs

141: Column: 1
Hard tabs

143: Column: 1
Hard tabs

144: Column: 1
Hard tabs

145: Column: 1
Hard tabs

146: Column: 1
Hard tabs

147: Column: 1
Hard tabs

149: Column: 1
Hard tabs

150: Column: 1
Hard tabs

developers/prompt-scavenger.md (148)

49: Column: 29
Hard tabs

49: Column: 34
Hard tabs

49: Column: 39
Hard tabs

49: Column: 63
Hard tabs

50: Column: 29
Hard tabs

50: Column: 34
Hard tabs

50: Column: 39
Hard tabs

50: Column: 63
Hard tabs

116: Column: 1
Hard tabs

117: Column: 1
Hard tabs

118: Column: 1
Hard tabs

119: Column: 1
Hard tabs

120: Column: 1
Hard tabs

122: Column: 1
Hard tabs

123: Column: 1
Hard tabs

124: Column: 1
Hard tabs

125: Column: 1
Hard tabs

130: Column: 1
Hard tabs

131: Column: 1
Hard tabs

132: Column: 1
Hard tabs

133: Column: 1
Hard tabs

134: Column: 1
Hard tabs

135: Column: 1
Hard tabs

153: Column: 1
Hard tabs

154: Column: 1
Hard tabs

156: Column: 1
Hard tabs

157: Column: 1
Hard tabs

158: Column: 1
Hard tabs

159: Column: 1
Hard tabs

160: Column: 1
Hard tabs

162: Column: 1
Hard tabs

163: Column: 1
Hard tabs

164: Column: 1
Hard tabs

165: Column: 1
Hard tabs

166: Column: 1
Hard tabs

167: Column: 1
Hard tabs

168: Column: 1
Hard tabs

170: Column: 1
Hard tabs

171: Column: 1
Hard tabs

172: Column: 1
Hard tabs

173: Column: 1
Hard tabs

174: Column: 1
Hard tabs

175: Column: 1
Hard tabs

176: Column: 1
Hard tabs

189: Column: 1
Hard tabs

190: Column: 1
Hard tabs

191: Column: 1
Hard tabs

192: Column: 1
Hard tabs

193: Column: 1
Hard tabs

195: Column: 1
Hard tabs

196: Column: 1
Hard tabs

207: Column: 1
Hard tabs

208: Column: 1
Hard tabs

209: Column: 1
Hard tabs

210: Column: 1
Hard tabs

212: Column: 1
Hard tabs

213: Column: 1
Hard tabs

214: Column: 1
Hard tabs

215: Column: 1
Hard tabs

216: Column: 1
Hard tabs

218: Column: 1
Hard tabs

219: Column: 1
Hard tabs

220: Column: 1
Hard tabs

221: Column: 1
Hard tabs

222: Column: 1
Hard tabs

223: Column: 1
Hard tabs

225: Column: 1
Hard tabs

226: Column: 1
Hard tabs

228: Column: 1
Hard tabs

236: Column: 1
Hard tabs

237: Column: 1
Hard tabs

239: Column: 1
Hard tabs

240: Column: 1
Hard tabs

241: Column: 1
Hard tabs

242: Column: 1
Hard tabs

243: Column: 1
Hard tabs

245: Column: 1
Hard tabs

246: Column: 1
Hard tabs

247: Column: 1
Hard tabs

248: Column: 1
Hard tabs

249: Column: 1
Hard tabs

250: Column: 1
Hard tabs

251: Column: 1
Hard tabs

253: Column: 1
Hard tabs

254: Column: 1
Hard tabs

255: Column: 1
Hard tabs

256: Column: 1
Hard tabs

257: Column: 1
Hard tabs

258: Column: 1
Hard tabs

260: Column: 1
Hard tabs

261: Column: 1
Hard tabs

262: Column: 1
Hard tabs

263: Column: 1
Hard tabs

264: Column: 1
Hard tabs

266: Column: 1
Hard tabs

267: Column: 1
Hard tabs

268: Column: 1
Hard tabs

269: Column: 1
Hard tabs

270: Column: 1
Hard tabs

272: Column: 1
Hard tabs

274: Column: 1
Hard tabs

275: Column: 1
Hard tabs

276: Column: 1
Hard tabs

277: Column: 1
Hard tabs

278: Column: 1
Hard tabs

279: Column: 1
Hard tabs

280: Column: 1
Hard tabs

299: Column: 4
Hard tabs

300: Column: 5
Hard tabs

304: Column: 1
Hard tabs

317: Column: 8
Hard tabs

330: Column: 1
Hard tabs

331: Column: 1
Hard tabs

333: Column: 1
Hard tabs

334: Column: 1
Hard tabs

335: Column: 1
Hard tabs

336: Column: 1
Hard tabs

337: Column: 1
Hard tabs

339: Column: 1
Hard tabs

340: Column: 1
Hard tabs

341: Column: 1
Hard tabs

342: Column: 1
Hard tabs

343: Column: 1
Hard tabs

344: Column: 1
Hard tabs

345: Column: 1
Hard tabs

347: Column: 1
Hard tabs

348: Column: 1
Hard tabs

349: Column: 1
Hard tabs

350: Column: 1
Hard tabs

351: Column: 1
Hard tabs

352: Column: 1
Hard tabs

354: Column: 1
Hard tabs

355: Column: 1
Hard tabs

356: Column: 1
Hard tabs

357: Column: 1
Hard tabs

358: Column: 1
Hard tabs

360: Column: 1
Hard tabs

361: Column: 1
Hard tabs

362: Column: 1
Hard tabs

363: Column: 1
Hard tabs

364: Column: 1
Hard tabs

366: Column: 1
Hard tabs

367: Column: 1
Hard tabs

368: Column: 1
Hard tabs

369: Column: 1
Hard tabs

370: Column: 1
Hard tabs

372: Column: 1
Hard tabs

48: null
Fenced code blocks should have a language specified

Additional comments not posted (1)
developers/golang-client-tutorial.md (1)

7-7: Update the document title to match the new naming convention.

- # Golang client library tutorial {#golang-client-library}
+ # Golang Client Library Guide {#golang-client-library}

Comment thread developers/prompt-scavenger.md
jcstein
jcstein reviewed May 28, 2024
View reviewed changes
Comment thread developers/prompt-scavenger.md Outdated
coderabbitai[bot]
coderabbitai bot reviewed May 28, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 84f23c9 and 6fa51d2.
Files selected for processing (1)
  • developers/prompt-scavenger.md (2 hunks)
Additional Context Used
LanguageTool (1)
developers/prompt-scavenger.md (1)

Near line 288: As a shorter alternative for ‘able to’, consider using “can”.
Context: ... the given height. ::: Now our program is able to create the namespace and blob, then sub...
Rule ID: BE_ABLE_TO

Markdownlint (148)
developers/prompt-scavenger.md (148)

49: Column: 29
Hard tabs

49: Column: 34
Hard tabs

49: Column: 39
Hard tabs

49: Column: 63
Hard tabs

50: Column: 29
Hard tabs

50: Column: 34
Hard tabs

50: Column: 39
Hard tabs

50: Column: 63
Hard tabs

116: Column: 1
Hard tabs

117: Column: 1
Hard tabs

118: Column: 1
Hard tabs

119: Column: 1
Hard tabs

120: Column: 1
Hard tabs

122: Column: 1
Hard tabs

123: Column: 1
Hard tabs

124: Column: 1
Hard tabs

125: Column: 1
Hard tabs

130: Column: 1
Hard tabs

131: Column: 1
Hard tabs

132: Column: 1
Hard tabs

133: Column: 1
Hard tabs

134: Column: 1
Hard tabs

135: Column: 1
Hard tabs

153: Column: 1
Hard tabs

154: Column: 1
Hard tabs

156: Column: 1
Hard tabs

157: Column: 1
Hard tabs

158: Column: 1
Hard tabs

159: Column: 1
Hard tabs

160: Column: 1
Hard tabs

162: Column: 1
Hard tabs

163: Column: 1
Hard tabs

164: Column: 1
Hard tabs

165: Column: 1
Hard tabs

166: Column: 1
Hard tabs

167: Column: 1
Hard tabs

168: Column: 1
Hard tabs

170: Column: 1
Hard tabs

171: Column: 1
Hard tabs

172: Column: 1
Hard tabs

173: Column: 1
Hard tabs

174: Column: 1
Hard tabs

175: Column: 1
Hard tabs

176: Column: 1
Hard tabs

189: Column: 1
Hard tabs

190: Column: 1
Hard tabs

191: Column: 1
Hard tabs

192: Column: 1
Hard tabs

193: Column: 1
Hard tabs

195: Column: 1
Hard tabs

196: Column: 1
Hard tabs

207: Column: 1
Hard tabs

208: Column: 1
Hard tabs

209: Column: 1
Hard tabs

210: Column: 1
Hard tabs

212: Column: 1
Hard tabs

213: Column: 1
Hard tabs

214: Column: 1
Hard tabs

215: Column: 1
Hard tabs

216: Column: 1
Hard tabs

218: Column: 1
Hard tabs

219: Column: 1
Hard tabs

220: Column: 1
Hard tabs

221: Column: 1
Hard tabs

222: Column: 1
Hard tabs

223: Column: 1
Hard tabs

225: Column: 1
Hard tabs

226: Column: 1
Hard tabs

228: Column: 1
Hard tabs

236: Column: 1
Hard tabs

237: Column: 1
Hard tabs

239: Column: 1
Hard tabs

240: Column: 1
Hard tabs

241: Column: 1
Hard tabs

242: Column: 1
Hard tabs

243: Column: 1
Hard tabs

245: Column: 1
Hard tabs

246: Column: 1
Hard tabs

247: Column: 1
Hard tabs

248: Column: 1
Hard tabs

249: Column: 1
Hard tabs

250: Column: 1
Hard tabs

251: Column: 1
Hard tabs

253: Column: 1
Hard tabs

254: Column: 1
Hard tabs

255: Column: 1
Hard tabs

256: Column: 1
Hard tabs

257: Column: 1
Hard tabs

258: Column: 1
Hard tabs

260: Column: 1
Hard tabs

261: Column: 1
Hard tabs

262: Column: 1
Hard tabs

263: Column: 1
Hard tabs

264: Column: 1
Hard tabs

266: Column: 1
Hard tabs

267: Column: 1
Hard tabs

268: Column: 1
Hard tabs

269: Column: 1
Hard tabs

270: Column: 1
Hard tabs

272: Column: 1
Hard tabs

274: Column: 1
Hard tabs

275: Column: 1
Hard tabs

276: Column: 1
Hard tabs

277: Column: 1
Hard tabs

278: Column: 1
Hard tabs

279: Column: 1
Hard tabs

280: Column: 1
Hard tabs

299: Column: 4
Hard tabs

300: Column: 5
Hard tabs

304: Column: 1
Hard tabs

317: Column: 8
Hard tabs

330: Column: 1
Hard tabs

331: Column: 1
Hard tabs

333: Column: 1
Hard tabs

334: Column: 1
Hard tabs

335: Column: 1
Hard tabs

336: Column: 1
Hard tabs

337: Column: 1
Hard tabs

339: Column: 1
Hard tabs

340: Column: 1
Hard tabs

341: Column: 1
Hard tabs

342: Column: 1
Hard tabs

343: Column: 1
Hard tabs

344: Column: 1
Hard tabs

345: Column: 1
Hard tabs

347: Column: 1
Hard tabs

348: Column: 1
Hard tabs

349: Column: 1
Hard tabs

350: Column: 1
Hard tabs

351: Column: 1
Hard tabs

352: Column: 1
Hard tabs

354: Column: 1
Hard tabs

355: Column: 1
Hard tabs

356: Column: 1
Hard tabs

357: Column: 1
Hard tabs

358: Column: 1
Hard tabs

360: Column: 1
Hard tabs

361: Column: 1
Hard tabs

362: Column: 1
Hard tabs

363: Column: 1
Hard tabs

364: Column: 1
Hard tabs

366: Column: 1
Hard tabs

367: Column: 1
Hard tabs

368: Column: 1
Hard tabs

369: Column: 1
Hard tabs

370: Column: 1
Hard tabs

372: Column: 1
Hard tabs

48: null
Fenced code blocks should have a language specified

Additional comments not posted (2)
developers/prompt-scavenger.md (2)

43-43: Update the command to match the new network name.

The command has been correctly updated to use the arabica network as per the latest changes.

63-63: Ensure the new command parameters are correctly used.

The command has been updated to include the new server address and additional flags which disable authentication, aligning with the new network setup.

Comment thread developers/prompt-scavenger.md
Comment thread developers/prompt-scavenger.md
Comment thread developers/prompt-scavenger.md
@jcstein jcstein merged commit 2feb613 into main May 28, 2024
@jcstein jcstein deleted the prompt-scavenger-update branch May 28, 2024 14:54
@coderabbitai coderabbitai bot mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcstein jcstein jcstein approved these changes

@YazzyYaz YazzyYaz Awaiting requested review from YazzyYaz

+1 more reviewer

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@distractedm1nd distractedm1nd

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@distractedm1nd @jcstein