Skip to content

Add Gem Wallet#1590

Merged
jcstein merged 3 commits intocelestiaorg:mainfrom
gememerald8:main
Jun 17, 2024
Merged

Add Gem Wallet#1590
jcstein merged 3 commits intocelestiaorg:mainfrom
gememerald8:main

Conversation

@gememerald8
Copy link
Copy Markdown
Contributor

@gememerald8 gememerald8 commented May 30, 2024

Overview

Add Gem Wallet for Celestia Staking guide.

Summary by CodeRabbit

  • Documentation
    • Expanded the tutorial on how to stake TIA to include detailed instructions for staking with the Gem wallet, in addition to Keplr and Leap wallets.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented May 30, 2024

Walkthrough

The tutorial on how to stake TIA tokens has been updated to include instructions for using the Gem wallet, in addition to the previously covered Keplr and Leap wallets. This enhancement provides users with a comprehensive guide that now encompasses step-by-step instructions for staking TIA tokens using the Gem wallet, thereby broadening the staking options available to users.

Changes

Files Change Summary
learn/how-to-stake-tia.md Expanded the tutorial to include detailed instructions for staking TIA tokens using the Gem wallet, alongside existing instructions for Keplr and Leap wallets.

Poem

In the garden of TIA, where tokens bloom,
A Gem now joins, dispelling gloom.
With Keplr, Leap, and Gem so bright,
Staking's path is clear in the moonlight. 🌙
Stake your tokens, watch them grow,
In this digital Eden, let your wealth flow. 🌿


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 39a803d and 456dd9a.

Files ignored due to path filters (5)
  • public/img/gem.png is excluded by !**/*.png
  • public/img/gem/gem1.gif is excluded by !**/*.gif
  • public/img/gem/gem2.gif is excluded by !**/*.gif
  • public/img/gem/gem3.gif is excluded by !**/*.gif
  • public/img/gem/gem4.gif is excluded by !**/*.gif
Files selected for processing (1)
  • learn/how-to-stake-tia.md (4 hunks)
Additional context used
Markdownlint
learn/how-to-stake-tia.md

125-125: null
Files should end with a single newline character

Additional comments not posted (4)
learn/how-to-stake-tia.md (4)

3-3: Ensure the description is updated to reflect all supported wallets.


15-15: The addition of the Gem wallet link is correctly formatted and consistent with other wallet links.


33-37: The visual representation for the Gem wallet has been added correctly, maintaining consistency with the layout used for other wallets.


101-125: The instructions for using the Gem wallet are clear and follow the same structure as those for the other wallets. This maintains a consistent user experience across different sections.

Comment thread learn/how-to-stake-tia.md Outdated

After your transaction is confirmed, you will have access to a control panel where you can claim rewards, unstake, redelegate, or stake additional tokens.

![Gem4](/img/gem/gem4.gif) No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the file ends with a newline character.

+ 

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
![Gem4](/img/gem/gem4.gif)
![Gem4](/img/gem/gem4.gif)

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 456dd9a and 0a43681.

Files selected for processing (1)
  • learn/how-to-stake-tia.md (4 hunks)
Files skipped from review as they are similar to previous changes (1)
  • learn/how-to-stake-tia.md

@jcstein
Copy link
Copy Markdown
Member

jcstein commented May 31, 2024

is gem open source?

@gemcoder21
Copy link
Copy Markdown

is gem open source?

Yes, just recently open sourced it, finally all the parts now are open source:

  1. Core: https://github.com/gemwalletcom/core
  2. iOS App: https://github.com/gemwalletcom/gem-ios
  3. Android: https://github.com/gemwalletcom/gem-android

@jcstein
Copy link
Copy Markdown
Member

jcstein commented Jun 13, 2024

are there any audits available @gemcoder21 ?

@gemcoder21
Copy link
Copy Markdown

are there any audits available @gemcoder21 ?

Gem Wallet core is build on top of Wallet Core (link to the audit) which has been audited. We do plan to audit our own codebase in the next as well as having reproducible builds, It's on our Gem Wallet Roadmap as we build in public for the public.

Feel free to take a look at our Security page to learn how Gem Wallet handles Security and Privacy.

@jcstein
Copy link
Copy Markdown
Member

jcstein commented Jun 17, 2024

thank you @gemcoder21 !

@jcstein jcstein self-requested a review June 17, 2024 19:34
@jcstein jcstein merged commit 63461aa into celestiaorg:main Jun 17, 2024
@gitpoap-bot
Copy link
Copy Markdown

gitpoap-bot bot commented Jun 17, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Celestia Contributor:

GitPOAP: 2024 Celestia Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants