Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe change enhances documentation on maximum blob size in Celestia transactions, detailing the share grid breakdown and the influence of governance parameters. It includes guidance in the Node tutorial for users to understand blob sizes and references to specific code repositories for further clarity on calculations. Changes
Sequence Diagram(s)No diagrams are needed for these changes. Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (4)
developers/submit-data.md (4)
Line range hint
45-45: Consider adding a comma after "However" for better readability.- However gas price is often specified by users + However, gas price is often specified by users
Line range hint
58-58: A comma may be missing after "Cosmos-SDK". Enhancing readability could be beneficial here.- ...in the Cosmos-SDK this is not always the case. + ...in the Cosmos-SDK, this is not always the case.
Line range hint
167-167: Consider using "resolve" instead of "fix" for a more formal tone.- ...and a willingness to accept changes to fix this issue. + ...and a willingness to accept changes to resolve this issue.
Line range hint
195-238: Replace hard tabs with spaces to adhere to Markdownlint recommendations.- <code with hard tabs> + <equivalent code with spaces>
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- developers/submit-data.md (1 hunks)
Additional context used
LanguageTool
developers/submit-data.md
[uncategorized] ~45-~45: A comma may be missing after the conjunctive/linking adverb ‘However’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
Context: ...by specifying and deducting a flat fee. However gas price is often specified by users i...
[uncategorized] ~58-~58: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...on above of how gas works in the Cosmos-SDK this is not always the case. Notably, i...
[style] ~167-~167: Consider using a different verb for a more formal wording. (FIX_RESOLVE)
Context: ... and a willingness to accept changes to fix this issue. ## API Users can currentl...
Markdownlint
developers/submit-data.md
195-195: Column: 1 (MD010, no-hard-tabs)
Hard tabs
196-196: Column: 1 (MD010, no-hard-tabs)
Hard tabs
197-197: Column: 1 (MD010, no-hard-tabs)
Hard tabs
199-199: Column: 1 (MD010, no-hard-tabs)
Hard tabs
200-200: Column: 1 (MD010, no-hard-tabs)
Hard tabs
201-201: Column: 1 (MD010, no-hard-tabs)
Hard tabs
206-206: Column: 1 (MD010, no-hard-tabs)
Hard tabs
207-207: Column: 1 (MD010, no-hard-tabs)
Hard tabs
208-208: Column: 1 (MD010, no-hard-tabs)
Hard tabs
209-209: Column: 1 (MD010, no-hard-tabs)
Hard tabs
211-211: Column: 1 (MD010, no-hard-tabs)
Hard tabs
212-212: Column: 1 (MD010, no-hard-tabs)
Hard tabs
213-213: Column: 1 (MD010, no-hard-tabs)
Hard tabs
214-214: Column: 1 (MD010, no-hard-tabs)
Hard tabs
215-215: Column: 1 (MD010, no-hard-tabs)
Hard tabs
217-217: Column: 1 (MD010, no-hard-tabs)
Hard tabs
218-218: Column: 1 (MD010, no-hard-tabs)
Hard tabs
219-219: Column: 1 (MD010, no-hard-tabs)
Hard tabs
220-220: Column: 1 (MD010, no-hard-tabs)
Hard tabs
221-221: Column: 1 (MD010, no-hard-tabs)
Hard tabs
223-223: Column: 1 (MD010, no-hard-tabs)
Hard tabs
224-224: Column: 1 (MD010, no-hard-tabs)
Hard tabs
225-225: Column: 1 (MD010, no-hard-tabs)
Hard tabs
226-226: Column: 1 (MD010, no-hard-tabs)
Hard tabs
227-227: Column: 1 (MD010, no-hard-tabs)
Hard tabs
229-229: Column: 1 (MD010, no-hard-tabs)
Hard tabs
231-231: Column: 1 (MD010, no-hard-tabs)
Hard tabs
232-232: Column: 1 (MD010, no-hard-tabs)
Hard tabs
233-233: Column: 1 (MD010, no-hard-tabs)
Hard tabs
234-234: Column: 1 (MD010, no-hard-tabs)
Hard tabs
235-235: Column: 1 (MD010, no-hard-tabs)
Hard tabs
237-237: Column: 1 (MD010, no-hard-tabs)
Hard tabs
238-238: Column: 1 (MD010, no-hard-tabs)
Hard tabs
Additional comments not posted (1)
developers/submit-data.md (1)
15-24: The new section on maximum blob size is clear and informative. The explanation of how the maximum size is determined and its potential variability based on governance decisions is well articulated. However, consider adding a reference or link to where users can participate or view these governance decisions to make this section more actionable.
jcstein
added
P0
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- developers/node-tutorial.md (1 hunks)
- nodes/mainnet.md (1 hunks)
Additional context used
LanguageTool
nodes/mainnet.md
[style] ~94-~94: Consider a shorter alternative to avoid wordiness. (IN_ORDER_TO_PREMIUM)
Context: ...guide will link to the relevant network in order to show you how to connect to them. Learn ...
[style] ~98-~98: Consider a shorter alternative to avoid wordiness. (IN_ORDER_TO_PREMIUM)
Context: ...tions of the types of nodes you can run in order to participate in Mainnet Beta: ### Conse...
[uncategorized] ~261-~261: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...istory of the chain without pruning any data so all data available data is retrievab...developers/node-tutorial.md
[uncategorized] ~102-~102: A comma might be missing here. (AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
Context: ...all Golang celestia-node is written in Golang so we must install Golang to build and ...
[uncategorized] ~178-~178: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...the correct version of Go was installed correctly run:bash go version...
[uncategorized] ~486-~486: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ... ---node.store string- the path to root/home directory of your celestia-node st...
[uncategorized] ~497-~497: Possible missing article found. (AI_HYDRA_LEO_MISSING_THE)
Context: ...se flags in the following order: 1. If user passes auth token, auth token is used. ...
[uncategorized] ~498-~498: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ... If user doesn't pass auth token, check node store flag, create token from node s...
[style] ~502-~502: Consider a shorter alternative to avoid wordiness. (IN_ORDER_TO_PREMIUM)
Context: ...ore. #### Auth token 🔐 {#auth-token} In order to interact with the API using RPC CLI, yo...
[style] ~526-~526: Consider a shorter alternative to avoid wordiness. (IN_ORDER_TO_PREMIUM)
Context: ....network arabica) ``` #### Node store In order to interact with the API using RPC CLI, yo...
[uncategorized] ~595-~595: The preposition “into” seems more likely in this position than the preposition “to”. (AI_EN_LECTOR_REPLACEMENT_PREPOSITION_TO_INTO)
Context: ... plaintext string which will be encoded to base64 ('Hello There!') - Optionally,...
[style] ~860-~860: Consider a shorter alternative to avoid wordiness. (IN_ORDER_TO_PREMIUM)
Context: ...# Get your node ID This is an RPC call in order to get your node's peerId information: ``...
[style] ~888-~888: Consider a shorter alternative to avoid wordiness. (IN_ORDER_TO_PREMIUM)
Context: ...ur account address This is an RPC call in order to get your node's account address: ```ba...
[uncategorized] ~1032-~1032: ‘Amount of’ should usually only be used with uncountable or mass nouns. Consider using “number” if this is not the case. (AMOUNTOF_TO_NUMBEROF)
Context: ...c02gxspa29wmh0d ``` Then, transfer the amount of tokens that you would like, while se...
[grammar] ~1064-~1064: The word ‘help’ is a conjunction. In formal texts, use “to”. (HELP_AND_VB)
Context: ...$NODE_STORE ``` #### Help To get help and view the CLI menu, use the following co...
[uncategorized] ~1070-~1070: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...:bash celestia --helpTo view help menu for a specific method, use the fol...
[style] ~1091-~1091: Consider a shorter alternative to avoid wordiness. (IN_ORDER_TO_PREMIUM)
Context: ...rces ### Submitting a blob using curl In order to post a blob using curl, you will need a...
Additional comments not posted (1)
developers/node-tutorial.md (1)
465-467: Ensure the link tosubmit-data.mdis correct.
|
|
||
| ## Maximum blob size | ||
|
|
||
| The maximum total blob size in a transaction is just under **2 MiB |
There was a problem hiding this comment.
Although this is technically the max blob size, I think we should provide an advisable maximum size of something like 80-90% of the max size to avoid timeouts on users submitting large blobs.
There was a problem hiding this comment.
This doesn't make sense to me yet WHY it happens. I know things would get congested if the entire block gets filled, but I wasn't aware it happens to individual blobs as well?
There was a problem hiding this comment.
if the whole block is filled with just 1 blob then there is no room for any other transactions, so it will most likely take longer to get it included, unless you really jack up the gas
There was a problem hiding this comment.
so i think encouraging people to not try to push the limit would help things get included without wasting gas on beating the lower fees out
distractedm1nd
left a comment
distractedm1nd
left a comment
There was a problem hiding this comment.
Thank you for explaining, makes sense
3 participants
Overview
PREVIEW
Summary by CodeRabbit