Conversation
add NODERS consensus node
add NODERS testnet consensus node
add NODERS mainnet endpoints parser
|
Warning Review failedThe pull request is closed. WalkthroughThe recent update introduces new RPC and gRPC endpoints for both the Celestia Mainnet Beta and Mocha Testnet, enabling more efficient connectivity to DA nodes. For analytics, new website links have been added to track performance metrics for both networks. Changes
Poem
Tip AI model upgrade
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- nodes/mainnet.md (2 hunks)
- nodes/mocha-testnet.md (2 hunks)
Additional context used
LanguageTool
nodes/mocha-testnet.md
[style] ~75-~75: Consider a shorter alternative to avoid wordiness.
Context: ...nsensus node](./full-consensus-node.md) in order to download full blocks from it. ::: - `p...(IN_ORDER_TO_PREMIUM)
[uncategorized] ~119-~119: Possible missing comma found.
Context: ...to interact with the REST API in Cosmos SDK which is implemented using gRPC-gateway...(AI_HYDRA_LEO_MISSING_COMMA)
nodes/mainnet.md
[uncategorized] ~60-~60: Possible missing comma found.
Context: ...ximum square size is 64x64, which gives us 4096 shares. - One share is reserved fo...(AI_HYDRA_LEO_MISSING_COMMA)
[style] ~90-~90: Consider a shorter alternative to avoid wordiness.
Context: ...guide will link to the relevant network in order to show you how to connect to them. Learn ...(IN_ORDER_TO_PREMIUM)
[style] ~94-~94: Consider a shorter alternative to avoid wordiness.
Context: ...tions of the types of nodes you can run in order to participate in Mainnet Beta: ### Conse...(IN_ORDER_TO_PREMIUM)
[uncategorized] ~247-~247: Possible missing comma found.
Context: ....services` - gRPC: port 9080 - RPC: port 26557 DA full and light nodes might ha...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~260-~260: Possible missing comma found.
Context: ...istory of the chain without pruning any data so all data available data is retrievab...(AI_HYDRA_LEO_MISSING_COMMA)
Markdownlint
nodes/mocha-testnet.md
135-135: null
Spaces inside link text(MD039, no-space-in-links)
Additional comments not posted (4)
nodes/mocha-testnet.md (2)
220-220: Addition of an analytics website linkThe newly added link to
https://cosmoslist.co/testnet/celestiafor analytics is a useful resource for users. Ensure the website is live and the content is relevant to the Mocha Testnet.
89-91: New RPC and gRPC endpoints added for the Mocha TestnetThe addition of new endpoints (
celestia-consensus-testnet.noders.serviceswith RPC port 26357 and gRPC port 9070) is consistent with the format of other entries in the document. Ensure to verify that these endpoints are accessible and correctly configured.nodes/mainnet.md (2)
245-247: New RPC and gRPC endpoints added for the Mainnet BetaThe addition of new endpoints (
celestia-consensus-mainnet.noders.serviceswith gRPC port 9080 and RPC port 26557) is consistent with the format of other entries in the document. Ensure to verify that these endpoints are accessible and correctly configured.Verification successful
New RPC and gRPC endpoints added for the Mainnet Beta
The new endpoints (
celestia-consensus-mainnet.noders.serviceswith gRPC port 9080 and RPC port 26557) are accessible, as verified by the HTTP 400 Bad Request responses. This confirms that the endpoints are correctly configured and reachable.
celestia-consensus-mainnet.noders.services
- gRPC: port 9080
- RPC: port 26557
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the accessibility of the new RPC and gRPC endpoints. # Test: Attempt to ping the new endpoints. Expect: Successful response. ping -c 3 celestia-consensus-mainnet.noders.servicesLength of output: 126
Script:
#!/bin/bash # Description: Verify the accessibility of the new RPC and gRPC endpoints using curl. # Test: Attempt to access the gRPC endpoint. Expect: Successful connection or HTTP response. curl -s --head http://celestia-consensus-mainnet.noders.services:9080 # Test: Attempt to access the RPC endpoint. Expect: Successful connection or HTTP response. curl -s --head http://celestia-consensus-mainnet.noders.services:26557Length of output: 465
Tools
LanguageTool
[uncategorized] ~247-~247: Possible missing comma found.
Context: ....services` - gRPC: port 9080 - RPC: port 26557 DA full and light nodes might ha...(AI_HYDRA_LEO_MISSING_COMMA)
294-294: Addition of an analytics website linkThe newly added link to
https://cosmoslist.co/mainnet/celestiafor analytics is a useful resource for users. Ensure the website is live and the content is relevant to the Mainnet Beta.
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Celestia Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
2 participants
This PR includes the addition of Consensus node NODERS for Mainnet and Testnet as well as the celestia and mocha-4 network endpoints parser
Summary by CodeRabbit