Skip to content

Fix font preload path in VitePress config#1889

Merged
jcstein merged 1 commit intocelestiaorg:mainfrom
avorylli:фмн
Feb 10, 2025

Hidden character warning

The head ref may contain hidden characters: "\u0444\u043c\u043d"
Merged

Fix font preload path in VitePress config#1889
jcstein merged 1 commit intocelestiaorg:mainfrom
avorylli:фмн

Conversation

@avorylli
Copy link
Copy Markdown
Contributor

@avorylli avorylli commented Feb 10, 2025

Corrects the font filename pattern in transformHead function from "Unititled-Sans-Medium" to "Untitled-Sans-Medium" to ensure proper font preloading.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed a minor error affecting font loading to ensure the proper display of the custom font throughout the application.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 10, 2025

Walkthrough

The pull request corrects a typo in the regex pattern within the transformHead function of the .vitepress/config.ts file. The faulty pattern "Unititled-Sans-Medium" has been updated to "Untitled-Sans-Medium" to ensure the proper identification and processing of the font file. No other changes or modifications to public exports have been made.

Changes

File(s) Change Summary
.vitepress/config.ts Corrected regex typo in the transformHead function to properly match font file.

Possibly related PRs

Suggested reviewers

  • jcstein
  • lukecd

Poem

I'm a little rabbit with a clever twist,
Hopping through configs in a joyful mist.
A typo fixed, a regex aligned,
In font files now perfectly defined.
Cheers to small changes that help code shine!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9f15c00 and 70f6cb4.

📒 Files selected for processing (1)
  • .vitepress/config.ts (1 hunks)
🔇 Additional comments (1)
.vitepress/config.ts (1)

160-160: LGTM! Font filename pattern corrected.

The typo in the regex pattern has been fixed from Unititled-Sans-Medium to Untitled-Sans-Medium, which will now correctly match the font file for preloading.

Let's verify that the font file exists with the correct name:

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Description: Verify the existence of the font file with the correct name
fd -t f 'Untitled-Sans-Medium' -e woff2

Length of output: 39


Let's gather additional details by searching for any *.woff2 files containing "untitled-sans-medium" in their filename. This will help confirm whether the updated filename exists in the repository.


🏁 Script executed:

#!/bin/bash
find . -type f -iname '*.woff2' | grep -i 'untitled-sans-medium'

Length of output: 120


Verified: Font filename pattern is correctly updated.

  • The regex was fixed to use "Untitled-Sans-Medium" instead of the typo "Unititled-Sans-Medium".
  • The shell script confirmed the existence of the file at "./public/fonts/untitled-sans/untitled-sans-medium.woff2".
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank you @avorylli

Copy link
Copy Markdown
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jcstein jcstein merged commit e5c748c into celestiaorg:main Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants