Skip to content

Update foundation-delegation-program.md#2003

Merged
Bidon15 merged 4 commits intomainfrom
mindstyle85-patch-1
May 27, 2025
Merged

Update foundation-delegation-program.md#2003
Bidon15 merged 4 commits intomainfrom
mindstyle85-patch-1

Conversation

@mindstyle85
Copy link
Copy Markdown
Collaborator

@mindstyle85 mindstyle85 commented Apr 24, 2025

Update of the delegation program, do not merge yet!

Summary by CodeRabbit

  • Documentation
    • Simplified and clarified the cohort structure and renewal process.
    • Updated eligibility criteria regarding validator jailing and added requirements for post mortems if jailed multiple times.
    • Streamlined application requirements by removing the need for a blobstream address and consolidating contribution details.
    • Enhanced formatting for better readability.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 24, 2025

Walkthrough

The changes update the "foundation-delegation-program.md" documentation by simplifying the cohort structure, removing specific program start dates, and streamlining the eligibility and application requirements. The tiered cohort system is replaced with a uniform structure, and eligibility criteria regarding validator jailing are refined. Application requirements are reduced, and the contributions section is consolidated. No code or exported entities are affected; the modifications are limited to documentation content.

Changes

File(s) Change Summary
community/foundation-delegation-program.md Simplified cohort structure, removed specific start date, refined eligibility criteria on jailing, streamlined application requirements, and consolidated contributions section.

Sequence Diagram(s)

Possibly related PRs

Suggested labels

documentation

Suggested reviewers

  • jcstein

Poem

A rabbit hopped through docs today,
Tidying cohorts along the way.
No more tiers or tangled dates,
Just clearer rules for all who wait.
Simpler forms and cleaner lines—
Delegation now by new designs!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 24, 2025

PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-05-27 09:00 UTC

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (5)
community/foundation-delegation-program.md (5)

41-44: Standardize bullet phrasing
Consider using consistent verb tense and phrasing for readability. For example, change “Each Cohort has to renew in 12 months” to “Each cohort renews after 12 months.”

- * Each Cohort has to renew in 12 months.
+ * Each cohort renews after 12 months.

66-68: Add comma for clarity in performance clause
Insert a comma before “so that” to improve readability:

- (for new applicants - on testnet, so that we can evaluate performance)
+ (for new applicants – on testnet, so that we can evaluate performance)
🧰 Tools
🪛 LanguageTool

[typographical] ~67-~67: The conjunction “so that” does not have a comma in front.
Context: ...ics.md) (for new applicants - on testnet, so that we can evaluate performance) * Not jail...

(SO_THAT_UNNECESSARY_COMMA)


68-71: Harmonize jail criteria wording and punctuation
Use a hyphenated adjective (“6-month period”), add a comma before “and,” and hyphenate “post-mortem” for consistency:

- * Not jailed more than once in the 6 months before application deadline
- * If jailed more than once in the 6 months period before application deadline,
-   then we require a public forum post with detailed post mortem and we consider case by case
+ * Not jailed more than once in the 6-month period before the application deadline.
+ * If jailed more than once in the 6-month period before the application deadline,
+   then we require a public forum post with a detailed post-mortem, and we consider each on a case-by-case basis.
🧰 Tools
🪛 LanguageTool

[misspelling] ~70-~70: This expression is normally spelled as one or with a hyphen.
Context: ...quire a public forum post with detailed post mortem and we consider case by case * Not asso...

(EN_COMPOUNDS_POST_MORTEM)


[uncategorized] ~70-~70: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...lic forum post with detailed post mortem and we consider case by case * Not associat...

(COMMA_COMPOUND_SENTENCE)


141-141: Clarify testnet naming and indentation
To maintain consistency with earlier mentions, replace “Mocha-4” with “Mocha testnet” and align the bullet indent with the surrounding list:

-   * If you don't run an active Mainnet Beta validator, please provide us with
-     validator address, bridge node ID on Mocha-4
+ * If you don't run an active Mainnet Beta validator, please provide us with
+   the validator address and bridge node ID on the Mocha testnet.

150-150: Refine contributions bullet for precision
Change “for Celestia and its ecosystem” to “to Celestia and its ecosystem” for grammatical accuracy:

- * Please list all contributions for Celestia and its ecosystem
+ * Please list all contributions to Celestia and its ecosystem
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b5e7b4f and fdf2d18.

📒 Files selected for processing (1)
  • community/foundation-delegation-program.md (5 hunks)
🧰 Additional context used
🪛 LanguageTool
community/foundation-delegation-program.md

[typographical] ~67-~67: The conjunction “so that” does not have a comma in front.
Context: ...ics.md) (for new applicants - on testnet, so that we can evaluate performance) * Not jail...

(SO_THAT_UNNECESSARY_COMMA)


[misspelling] ~70-~70: This expression is normally spelled as one or with a hyphen.
Context: ...quire a public forum post with detailed post mortem and we consider case by case * Not asso...

(EN_COMPOUNDS_POST_MORTEM)


[uncategorized] ~70-~70: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...lic forum post with detailed post mortem and we consider case by case * Not associat...

(COMMA_COMPOUND_SENTENCE)

🔇 Additional comments (3)
community/foundation-delegation-program.md (3)

37-37: Cohort process overview is clear
The simplified description “Here is an overview of how the cohort process will work.” aligns well with the updated documentation.


45-50: Simplified cohort table is concise and informative
The new uniform table for Cohorts 5–7 improves clarity and maintains the necessary details.


63-64: 1-month minimum validator requirement is clearer
Highlighting the “at least 1 month” threshold improves eligibility transparency.

Comment on lines 21 to 23
Prospective validators are welcome to apply to the program starting. The application
is designed to assess a validator’s uptime performance
and contributions to the Celestia ecosystem. Of the 100 total slots in
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

⚠️ Potential issue

Fix incomplete sentence in program launch
Removing the specific start date has left the sentence “Prospective validators are welcome to apply to the program starting.” unfinished. Please clarify the intended launch timeline (e.g., “starting immediately” or specify the application window).

- Prospective validators are welcome to apply to the program starting.
+ Prospective validators are welcome to apply to the program starting immediately.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Prospective validators are welcome to apply to the program starting. The application
is designed to assess a validator’s uptime performance
and contributions to the Celestia ecosystem. Of the 100 total slots in
Prospective validators are welcome to apply to the program starting immediately. The application
is designed to assess a validator’s uptime performance
and contributions to the Celestia ecosystem. Of the 100 total slots in

@jcstein jcstein marked this pull request as draft April 24, 2025 14:44
@mindstyle85 mindstyle85 marked this pull request as ready for review May 22, 2025 13:09
@mindstyle85 mindstyle85 requested a review from jcstein May 22, 2025 13:10
@mindstyle85
Copy link
Copy Markdown
Collaborator Author

@jcstein pls check if all ok, not sure if we merge yet but at least if its all fine and we can push merge once we are there

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (5)
community/foundation-delegation-program.md (5)

21-22: Suggest clarifying application start timeline
Removing the specific start date correctly abstracts the timeline but the sentence “Prospective validators are welcome to apply to the program” could still leave readers wondering when applications open. Consider adding a phrase such as “starting immediately” or “applications are now open” to make it explicit.


63-63: Merge continuation line into bullet for readability
The continuation “for at least 1 month before application deadline” should either be indented under the previous bullet or merged into the same line for consistency. For example:

* Run an active Mainnet Beta validator **or** an active Mocha testnet validator **for at least 1 month before application deadline**

68-71: Refine eligibility jailing criteria for clarity and grammar
Combine the two bullets and apply hyphenation for “post-mortem” and “case-by-case”:

-* Not jailed more than once in the 6 months before application deadline
-* If jailed more than once in the 6 months period before application deadline,
-then we require a public forum post with detailed post mortem and we consider
-case by case
+* Not jailed more than once in the 6 months before application deadline; if jailed more than once, a public forum post with a detailed post-mortem is required, and the application will be considered on a case-by-case basis.
🧰 Tools
🪛 LanguageTool

[misspelling] ~70-~70: This expression is normally spelled as one or with a hyphen.
Context: ...quire a public forum post with detailed post mortem and we consider case by case * Not asso...

(EN_COMPOUNDS_POST_MORTEM)


[uncategorized] ~70-~70: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...lic forum post with detailed post mortem and we consider case by case * Not associat...

(COMMA_COMPOUND_SENTENCE)


141-141: Ensure consistent use of “Mocha” naming
Earlier you refer to “Mocha testnet,” but here “Mocha-4” is used. Consider standardizing on one term (e.g., “Mocha testnet” or “Mocha-4 testnet”) across the document.


150-150: Minor wording improvement
Change “list all contributions for Celestia and its ecosystem” to “list all contributions to Celestia and its ecosystem” for consistency with common phrasing.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fdf2d18 and 01ee00d.

⛔ Files ignored due to path filters (1)
  • public/img/cohort-timeline.jpg is excluded by !**/*.jpg
📒 Files selected for processing (1)
  • community/foundation-delegation-program.md (5 hunks)
🧰 Additional context used
🪛 LanguageTool
community/foundation-delegation-program.md

[typographical] ~67-~67: The conjunction “so that” does not have a comma in front.
Context: ...ics.md) (for new applicants - on testnet, so that we can evaluate performance) * Not jail...

(SO_THAT_UNNECESSARY_COMMA)


[misspelling] ~70-~70: This expression is normally spelled as one or with a hyphen.
Context: ...quire a public forum post with detailed post mortem and we consider case by case * Not asso...

(EN_COMPOUNDS_POST_MORTEM)


[uncategorized] ~70-~70: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...lic forum post with detailed post mortem and we consider case by case * Not associat...

(COMMA_COMPOUND_SENTENCE)

🔇 Additional comments (3)
community/foundation-delegation-program.md (3)

34-37: LGTM: Cohort process description is clear
The reflowed line break and phrasing “Here is an overview of how the cohort process will work.” reads well. No issues found.


41-43: LGTM: Key points simplified and accurate
The updated bullet points concisely capture the program cadence, duration, and slot management.


45-50: LGTM: Cohort table simplification
The new table format clearly presents cohorts, sizes, durations, and renewal mapping.

Copy link
Copy Markdown
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bidon15 Bidon15 merged commit 16dc786 into main May 27, 2025
7 checks passed
@Bidon15 Bidon15 deleted the mindstyle85-patch-1 branch May 27, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants