Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe documentation for Blobstream deployments was updated to add entries for the Scroll and Holesky networks. Each entry includes the contract address and a block explorer link, with "Deployment on Celenium" marked as "N/A" for both. No other changes were made to the document. Additionally, the lychee link checker configuration was updated to exclude URLs matching the pattern for ScrollScan. Changes
Sequence Diagram(s)sequenceDiagram
User->>Documentation: Views Blobstream deployment table
Documentation-->>User: Displays updated table with Scroll and Holesky entries
User->>Block Explorer: Follows provided links for contract details
Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds documentation entries for SP1 Blobstream contracts on the Scroll and Holesky chains.
- Adds a new row for the Scroll network with its corresponding contract link.
- Adds a new row for the Holesky network with its corresponding contract link.
We'll add links to celenium when they're there, this should be good to go for now. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (2)
how-to-guides/blobstream.md (2)
159-159: Clarify the "N/A" placeholder for Celenium deployment
Consider adding a note below the table indicating that "N/A" signifies the contract is not yet deployed on Celenium and will be updated once the deployment is live.
163-163: Clarify the "N/A" placeholder for Celenium deployment
As above, add a footnote below the table explaining that "N/A" indicates pending Celenium deployment.
🧹 Nitpick comments (2)
how-to-guides/blobstream.md (2)
159-159: Ensure consistency in event-log links
Other EVM network entries append#eventsto the block-explorer URL to jump directly to the event logs. Consider adding#eventsto the ScrollScan link for parity:-[`0x5008fa5CC3397faEa90fcde71C35945db6822218`](https://scrollscan.com/address/0x5008fa5CC3397faEa90fcde71C35945db6822218) +[`0x5008fa5CC3397faEa90fcde71C35945db6822218`](https://scrollscan.com/address/0x5008fa5CC3397faEa90fcde71C35945db6822218#events)
163-163: Ensure consistency in event-log links
For consistency with other entries, append#eventsto the Holesky Etherscan URL:-[`0x315A044cb95e4d44bBf6253585FbEbcdB6fb41ef`](https://holesky.etherscan.io/address/0x315A044cb95e4d44bBf6253585FbEbcdB6fb41ef) +[`0x315A044cb95e4d44bBf6253585FbEbcdB6fb41ef`](https://holesky.etherscan.io/address/0x315A044cb95e4d44bBf6253585FbEbcdB6fb41ef#events)
Overview
Adds Blobstream SP1 contracts to docs for:
Scroll: https://scrollscan.com/address/0x5008fa5CC3397faEa90fcde71C35945db6822218
Holesky: https://holesky.etherscan.io/address/0x315A044cb95e4d44bBf6253585FbEbcdB6fb41ef
Note: these don't yet exist on Celenium, so marked as "N/A" for now. cc @vvuwei incase you are planning to add these
Summary by CodeRabbit