Skip to content

Enhance quick-start guide with improved clarity and organization#2031

Merged
jcstein merged 5 commits intomainfrom
gb/onboarding-feedback
May 13, 2025
Merged

Enhance quick-start guide with improved clarity and organization#2031
jcstein merged 5 commits intomainfrom
gb/onboarding-feedback

Conversation

@gbarros
Copy link
Copy Markdown
Contributor

@gbarros gbarros commented May 9, 2025

Overview

This PR improves the quick-start guide with several enhancements:

  • Streamlines the trusted hash retrieval command using a more efficient one-liner (avoids possible errors)
  • Fixes explicit path for config.toml location with home directory
  • Adds TrustedHash configuration step that was previously missing
    • Simplifies the node start command by removing the redundant trusted hash flag
  • Makes it explicit that the output is an example of fully synced node output
  • Adds link to celenium explorer for the example blobl created
  • Reorganizes and improves the "Diving deeper" section
  • Rewrites the (cel-key) key management section for simplicity and clarity
  • Improves overall document organization and flow

These changes make the guide more user-friendly and provide better clarity for new users getting started with Celestia light nodes.

Summary by CodeRabbit

  • Documentation
    • Improved instructions for setting trusted height and hash with a streamlined shell command.
    • Corrected file path references and added missing configuration steps.
    • Simplified the example command for starting the light node.
    • Expanded syncing status information with sample output.
    • Added a link to inspect example data on the Celenium explorer.
    • Introduced a new section detailing node store directory contents.
    • Updated and clarified the key management section, emphasizing advanced usage and external resources.
    • Reorganized advanced client tutorials under a "Next steps" section.
    • Added a new "Troubleshooting" section with helpful references.

@gbarros gbarros requested a review from jcstein May 9, 2025 20:58
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented May 9, 2025

Walkthrough

The quick-start guide was updated to streamline instructions for setting trusted height and hash, correct file paths, add missing configuration steps, and reorganize advanced topics. New sections on node store contents and troubleshooting were introduced, while various examples and references were clarified or expanded for improved guidance.

Changes

File(s) Change Summary
how-to-guides/quick-start.md Updated trusted height/hash setup to use a single command, corrected config path, added config step for Header.TrustedHash, simplified node start command, expanded syncing status tip with example, added node store contents and troubleshooting sections, renamed and rewrote advanced key management, reorganized tutorial content under "Next steps," and added external links for references.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Guide
    participant Node
    participant ConfigFile

    User->>Guide: Follow quick-start instructions
    Guide->>User: Provide concise command to get trusted height/hash
    User->>ConfigFile: Update config.toml with trusted values
    User->>Node: Start node (simplified command)
    Node->>User: Show syncing status and store contents
    User->>Guide: Refer to troubleshooting or advanced key management as needed
Loading

Possibly related PRs

Poem

In the warren of docs, a guide gets a tweak,
Trusted hashes and heights, now simple to seek.
Paths corrected, tips expanded,
Troubleshooting help now candid.
With every hop, clarity grows—
A quick start, as every bunny knows! 🐇✨

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 9, 2025

PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-05-13 13:50 UTC

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🔭 Outside diff range comments (1)
how-to-guides/quick-start.md (1)

99-104: ⚠️ Potential issue

Update guidance text after removing the --headers.trusted-hash flag
The start command no longer includes --headers.trusted-hash, but the paragraph below still references it. Either restore the flag in the command or update the text to note that the trusted hash is now loaded from config.toml. For example:

- The `headers.trusted-hash` flag will set the trusted hash from the previous section.
+ The trusted hash is now read automatically from your `config.toml` (no CLI flag needed).
🧹 Nitpick comments (4)
how-to-guides/quick-start.md (4)

81-83: Enhance error handling and readability of the one-liner for fetching trusted height & hash
The current one-liner is concise but can silently mask failures (e.g., curl or jq errors) and is hard to troubleshoot. Consider:

  • Breaking it into multiple commands (curl → parse → export).
  • Adding set -o errexit -o pipefail so any step failure aborts the script.
  • Logging errors when fetching or parsing fails.

217-219: Standardize Celenium Explorer link formatting
Consider updating the link text to “Celenium Explorer” (capitalized) and ensure it matches other references:

- You can also inspect this example on celenium explorer [here](https://mocha.celenium.io/blob?...).
+ You can also inspect this example on **Celenium Explorer** [here](https://mocha.celenium.io/blob?...).

234-243: Adjust markdown list indentation for “Node store contents” section
The bullet list under “Node store contents” is misaligned with markdownlint rules (MD007). Ensure top-level items start at column 1 and nested items are indented consistently. For example:

- - `config.toml`: Node configuration settings
+ - `config.toml`: Node configuration settings
- - `data/`: Contains database files
-   - `.vlog` files: Value log files
-   - `.sst` files: Static sorted tables
-   - System files: `DISCARD`, `KEYREGISTRY`, `MANIFEST`
+ - `data/`: Contains database files
+   - `.vlog` files: Value log files
+   - `.sst` files: Static sorted tables
+   - System files: `DISCARD`, `KEYREGISTRY`, `MANIFEST`
🧰 Tools
🪛 LanguageTool

[uncategorized] ~240-~240: Loose punctuation mark.
Context: ...ctories and file types: - config.toml: Node configuration settings - data/: ...

(UNLIKELY_OPENING_PUNCTUATION)


[duplication] ~241-~241: Possible typo: you repeated a word.
Context: ...n settings - data/: Contains database files - .vlog files: Value log files storing actual data ...

(ENGLISH_WORD_REPEAT_RULE)


261-266: Fix list indentation under “Advanced Key management with cel-key
The two list items are indented by one space, which violates markdownlint (MD007). Align them to the parent level:

-  - Create, import, and manage keys.
-  - Backup, verify and select the active key used by your node.
+ - Create, import, and manage keys.
+ - Backup, verify and select the active key used by your node.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

265-265: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


266-266: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 41f085b and f97940a.

📒 Files selected for processing (1)
  • how-to-guides/quick-start.md (6 hunks)
🧰 Additional context used
🪛 LanguageTool
how-to-guides/quick-start.md

[uncategorized] ~88-~88: “ti” (solmization) seems less likely than “to
Context: ...23456) 1. Set Header.TrustedHashti the trusted hash (e.g.TrustedHash = "...

(AI_HYDRA_LEO_CPT_TI_TO)


[uncategorized] ~240-~240: Loose punctuation mark.
Context: ...ctories and file types: - config.toml: Node configuration settings - data/: ...

(UNLIKELY_OPENING_PUNCTUATION)


[duplication] ~241-~241: Possible typo: you repeated a word.
Context: ...n settings - data/: Contains database files - .vlog files: Value log files storing actual data ...

(ENGLISH_WORD_REPEAT_RULE)

🪛 markdownlint-cli2 (0.17.2)
how-to-guides/quick-start.md

265-265: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


266-266: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)

Comment on lines +86 to 89
1. Open your `config.toml` at `~/.celestia-light-{{ constants.mochaChainId }}/config.toml`
1. Set `DASer.SampleFrom` to the trusted height (e.g. `SampleFrom = 123456`)
1. Set `Header.TrustedHash` ti the trusted hash (e.g. `TrustedHash = "71BDED03E16EC34A6548388ADBAF3BA679FD5C1AAC3587A7F5F843741856D839"` )

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix numbering, typo, and improve clarity in config.toml setup steps
The nested “1.” steps are confusing and there’s a typo (“ti” → “to”). It’s clearer to use a flat list:

-  1. Open your `config.toml` at `~/.celestia-light-{{ constants.mochaChainId }}/config.toml`
-  1. Set `DASer.SampleFrom` to the trusted height (e.g. `SampleFrom = 123456`)
-  1. Set `Header.TrustedHash` ti the trusted hash (e.g. `TrustedHash = "…"`)
+  1. Open your `config.toml` at `~/.celestia-light-{{ constants.mochaChainId }}/config.toml`
+  2. Under `[DASer]`, set:
+     ```toml
+     SampleFrom = <TRUSTED_HEIGHT>
+     ```
+  3. Under `[Header]`, set:
+     ```toml
+     TrustedHash = "<TRUSTED_HASH>"
+     ```

This corrects the typo and makes each step explicit.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~88-~88: “ti” (solmization) seems less likely than “to
Context: ...23456) 1. Set Header.TrustedHashti the trusted hash (e.g.TrustedHash = "...

(AI_HYDRA_LEO_CPT_TI_TO)

@jcstein jcstein assigned jcstein and gbarros and unassigned jcstein May 12, 2025
Comment thread how-to-guides/quick-start.md Outdated
Copy link
Copy Markdown
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's update the trusted hash guide too with this UX in another PR #2033 read -r TRUSTED_HEIGHT TRUSTED_HASH <<<"$(curl -s https://rpc-mocha.pops.one/header | jq -r '.result.header | "\(.height) \(.last_block_id.hash)"')" && export TRUSTED_HEIGHT TRUSTED_HASH && echo "Height: $TRUSTED_HEIGHT" && echo "Hash: $TRUSTED_HASH"

@jcstein jcstein merged commit 52f6598 into main May 13, 2025
6 of 7 checks passed
@jcstein jcstein deleted the gb/onboarding-feedback branch May 13, 2025 13:49
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

♻️ Duplicate comments (1)
how-to-guides/quick-start.md (1)

86-88: ⚠️ Potential issue

Fix typo in trusted hash configuration step
There's a small typo that could confuse readers: ti should be to.

Apply this diff:

-    1. Set `Header.TrustedHash` ti the trusted hash (e.g. `TrustedHash = "E8BD0C48260C496BB7A4D8D1E7BDBF1F26A2FE3CF5714DECE1741B2FFB3C095C"` )
+    1. Set `Header.TrustedHash` to the trusted hash (e.g. `TrustedHash = "E8BD0C48260C496BB7A4D8D1E7BDBF1F26A2FE3CF5714DECE1741B2FFB3C095C"` )
🧹 Nitpick comments (4)
how-to-guides/quick-start.md (4)

119-119: Suggest clearer phrasing for sync-tip
You can tighten the wording for readability. For example:

-If you want to see that your node is synced, use the `celestia das sampling-stats` command to check it in another terminal.
+To verify your node is synced, run `celestia das sampling-stats` in another terminal.

218-218: Capitalize and stylize Celenium Explorer link
“celenium explorer” should be capitalized as it’s a proper noun. For consistency and clarity:

-You can also inspect this example on celenium explorer [here](https://mocha.celenium.io/blob?...)
+You can also inspect this example on the Celenium Explorer [here](https://mocha.celenium.io/blob?...)

234-250: Review Node store contents section for clarity
The new section is informative, but consider:

  • Quoting the section title in the link for consistency:
    Initialize the light node instead of plain text.
  • Adding a blank line before the list for better markdown rendering.
  • Ensuring list items don’t have stray trailing punctuation if they’re fragments.

These tweaks will improve readability and maintain a uniform style.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~240-~240: Loose punctuation mark.
Context: ...ctories and file types: - config.toml: Node configuration settings - data/: ...

(UNLIKELY_OPENING_PUNCTUATION)


[duplication] ~241-~241: Possible typo: you repeated a word.
Context: ...n settings - data/: Contains database files - .vlog files: Value log files storing actual data ...

(ENGLISH_WORD_REPEAT_RULE)


265-266: Fix list indentation under cel-key section
Markdown lint flags the odd indent. Remove the leading space so items align with the margin:

- - Create, import, and manage keys.
- - Backup, verify and select the active key used by your node
+ - Create, import, and manage keys.
+ - Backup, verify and select the active key used by your node
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

265-265: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


266-266: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f97940a and 44f55b7.

📒 Files selected for processing (1)
  • how-to-guides/quick-start.md (6 hunks)
🧰 Additional context used
🪛 LanguageTool
how-to-guides/quick-start.md

[uncategorized] ~240-~240: Loose punctuation mark.
Context: ...ctories and file types: - config.toml: Node configuration settings - data/: ...

(UNLIKELY_OPENING_PUNCTUATION)


[duplication] ~241-~241: Possible typo: you repeated a word.
Context: ...n settings - data/: Contains database files - .vlog files: Value log files storing actual data ...

(ENGLISH_WORD_REPEAT_RULE)

🪛 markdownlint-cli2 (0.17.2)
how-to-guides/quick-start.md

265-265: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)


266-266: Unordered list indentation
Expected: 0; Actual: 1

(MD007, ul-indent)

🔇 Additional comments (2)
how-to-guides/quick-start.md (2)

82-82: Approve streamlined hash retrieval command
The one-liner to fetch, export, and display both TRUSTED_HEIGHT and TRUSTED_HASH is a solid improvement for reducing errors.


99-101: Approve simplified node start command
Removing the redundant --headers.trusted-hash flag is correct now that it's configured in config.toml. The new celestia light start invocation looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants