Skip to content

fix: core version for arabica#2035

Merged
rootulp merged 1 commit intomainfrom
rp/core-version-on-arabica
May 14, 2025
Merged

fix: core version for arabica#2035
rootulp merged 1 commit intomainfrom
rp/core-version-on-arabica

Conversation

@rootulp
Copy link
Copy Markdown
Contributor

@rootulp rootulp commented May 14, 2025

Addresses #2034 (comment)

Context in #2034 (comment)

Summary by CodeRabbit

  • Chores
    • Updated the latest core version and commit information for Arabica.

@rootulp rootulp requested a review from jcstein May 14, 2025 18:40
@rootulp rootulp self-assigned this May 14, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented May 14, 2025

Walkthrough

The arabicaVersions object in .vitepress/constants/arabica_versions.js was updated to reflect a new core latest version tag and its associated commit SHA. No other changes were made to the object structure or exports.

Changes

File(s) Change Summary
.vitepress/constants/arabica_versions.js Updated core-latest-tag and core-latest-sha values in the arabicaVersions object.

Possibly related PRs

Suggested reviewers

  • jcstein

Poem

A hop, a skip, a version hop anew,
The core tag’s changed, the SHAs are fresh too!
In the garden of constants, the numbers align,
Rabbits rejoice—release notes in rhyme.
🐇✨

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rootulp rootulp enabled auto-merge May 14, 2025 18:40
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a4858f4 and 26b03ca.

📒 Files selected for processing (1)
  • .vitepress/constants/arabica_versions.js (1 hunks)

Comment on lines +4 to +5
"core-latest-tag": "v1.53.0-tm-v0.38.17",
"core-latest-sha": "4acfd99c3893123775c533465f164f771d3a6f15",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Confirm updated core version tag and SHA values
Please verify that the tag v1.53.0-tm-v0.38.17 exists in the celestia-core repository and that it points to commit 4acfd99c3893123775c533465f164f771d3a6f15.


🏁 Script executed:

#!/usr/bin/env bash
REPO="https://github.com/celestia-core/celestia-core.git"
TAG="v1.53.0-tm-v0.38.17"
EXPECTED="4acfd99c3893123775c533465f164f771d3a6f15"
# Fetch the commit SHA for the tag without cloning
RES=$(git ls-remote "$REPO" "refs/tags/$TAG" | awk '{print $1}')
echo "Tag $TAG -> $RES"
if [ "$RES" != "$EXPECTED" ]; then
  echo "ERROR: SHA mismatch for $TAG (expected $EXPECTED)"
  exit 1
else
  echo "✅ SHA matches expected value"
fi

Length of output: 706


Let's verify against both possible GitHub org paths to locate the tag and SHA:


🏁 Script executed:

#!/usr/bin/env bash
TAG="v1.53.0-tm-v0.38.17"
EXPECTED="4acfd99c3893123775c533465f164f771d3a6f15"

for ORG in "celestia-core" "celestia"; do
  REPO="https://github.com/$ORG/celestia-core.git"
  echo "Checking $REPO..."
  SHA=$(git ls-remote "$REPO" "refs/tags/$TAG" 2>/dev/null | awk '{print $1}')
  if [ -z "$SHA" ]; then
    echo "  – Tag not found in $REPO"
  else
    echo "  – Tag $TAG$SHA"
    if [ "$SHA" = "$EXPECTED" ]; then
      echo "    ✅ SHA matches expected in $REPO"
    else
      echo "    ❌ SHA mismatch in $REPO (expected $EXPECTED)"
    fi
  fi
done

Length of output: 1101


Tag v1.53.0-tm-v0.38.17 not found – please correct core version and SHA
We attempted to locate v1.53.0-tm-v0.38.17 in both celestia-core/celestia-core and celestia/celestia-core, but the tag does not exist in either repo. Please verify that the correct repository, tag name, and commit SHA are being used and update the values accordingly.

• File: .vitepress/constants/arabica_versions.js
Lines: 4–5

  "core-latest-tag": "v1.53.0-tm-v0.38.17",
  "core-latest-sha": "4acfd99c3893123775c533465f164f771d3a6f15",

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 14, 2025

PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-05-14 19:01 UTC

@jcstein
Copy link
Copy Markdown
Member

jcstein commented May 14, 2025

Thank you, LGTM. FWIW we don't use these core variables so note to self to remove them eventually

@rootulp rootulp merged commit 0423205 into main May 14, 2025
7 checks passed
@rootulp rootulp deleted the rp/core-version-on-arabica branch May 14, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants