feat: add CI linting and formatting checks to prevent bypass via GitHub UI#2061
Merged
feat: add CI linting and formatting checks to prevent bypass via GitHub UI#2061
Conversation
Co-authored-by: jcstein <46639943+jcstein@users.noreply.github.com>
Co-authored-by: jcstein <46639943+jcstein@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] feat: ensure formatting and linting checks done on local development are required for PRs to pass
feat: add CI linting and formatting checks to prevent bypass via GitHub UI
Jun 3, 2025
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
jcstein
approved these changes
Jun 3, 2025
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive linting and formatting checks to the GitHub Actions build workflow to ensure code quality standards are enforced for all pull requests, regardless of how they are created.
Problem
Previously, linting and formatting checks were only enforced locally through Husky pre-commit hooks. This meant that:
Solution
Added the following CI checks to
.github/workflows/build.yml:yarn eslint) - Fails on linting issuesyarn prettier --check) - Fails if files aren't properly formattedyarn lint:md) - Shows issues withcontinue-on-error: trueto handle existing issuesAll checks run before the build step, ensuring code quality is verified before deployment.
Key Features
continue-on-errorTesting
Verified that:
This ensures that all future PRs will maintain consistent code quality and formatting standards, preventing the issues described in the original report.
Fixes #1399.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.