Skip to content

Fix outdated add-genesis-account command in instantiate testnet guide#2071

Merged
jcstein merged 7 commits intomainfrom
copilot/fix-2057
Jun 5, 2025
Merged

Fix outdated add-genesis-account command in instantiate testnet guide#2071
jcstein merged 7 commits intomainfrom
copilot/fix-2057

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jun 3, 2025

The add-genesis-account command in the testnet instantiation guide was using an incorrect flag that caused the command to fail with an "unknown command" error.

Issue:
The command celestia-appd add-genesis-account $KEY_NAME $TIA_AMOUNT --keyring-backend test was failing with:

Error: unknown command "add-genesis-account" for "celestia-appd"

Root cause:
The --keyring-backend test flag should not be passed to the add-genesis-account command itself. This flag is valid for other commands like keys add and gentx, but not for add-genesis-account.

Solution:
Removed the --keyring-backend test flag from the add-genesis-account command to align with the correct format shown in the celestia-app-commands.md documentation:

- celestia-appd add-genesis-account $KEY_NAME $TIA_AMOUNT --keyring-backend test
+ celestia-appd add-genesis-account $KEY_NAME $TIA_AMOUNT

The --keyring-backend test flag is still correctly used in other commands where it belongs (key creation and gentx generation).

Fixes #2057.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…d test flag

Co-authored-by: jcstein <46639943+jcstein@users.noreply.github.com>
Copilot AI changed the title [WIP] how-to-guides: instantiate a testnet has outdated commands for "add genesis account keyname" Fix outdated add-genesis-account command in instantiate testnet guide Jun 3, 2025
Copilot AI requested a review from jcstein June 3, 2025 09:32
@jcstein
Copy link
Copy Markdown
Member

jcstein commented Jun 3, 2025

hmm it looks like the keyring-backend isn't the issue @copilot

celestia-appd add-genesis-account --help
Add a genesis account to genesis.json. The provided account must specify
the account address or key name and a list of initial coins. If a key name is given,
the address will be looked up in the local Keybase. The list of initial tokens must
contain valid denominations. Accounts may optionally be supplied with vesting parameters.

Usage:
  celestia-appd add-genesis-account [address_or_key_name] [coin][,[coin]] [flags]

Flags:
      --append                   append the coins to an account already in the genesis.json file
      --grpc-addr string         the gRPC endpoint to use for this chain
      --grpc-insecure            allow gRPC over insecure channels, if not TLS the server must use TLS
      --height int               Use a specific height to query state at (this can error if the node is pruning state)
  -h, --help                     help for add-genesis-account
      --home string              The application home directory (default "/Users/js/.celestia-app")
      --keyring-backend string   Select keyring's backend (os|file|kwallet|pass|test) (default "test")
      --node string              <host>:<port> to Tendermint RPC interface for this chain (default "tcp://localhost:26657")
  -o, --output string            Output format (text|json) (default "text")
      --vesting-amount string    amount of coins for vesting accounts
      --vesting-end-time int     schedule end time (unix epoch) for vesting accounts
      --vesting-start-time int   schedule start time (unix epoch) for vesting accounts

Global Flags:
      --log-to-file string   Write logs directly to a file. If empty, logs are written to stderr
      --log_format string    The logging format (json|plain) (default "plain")
      --log_level string     The logging level (trace|debug|info|warn|error|fatal|panic) (default "info")
      --trace                print out full stack trace on errors

@jcstein
Copy link
Copy Markdown
Member

jcstein commented Jun 3, 2025

please resume @copilot

@jcstein
Copy link
Copy Markdown
Member

jcstein commented Jun 4, 2025

resume @copilot

Co-authored-by: jcstein <46639943+jcstein@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jun 4, 2025

resume @copilot

You're absolutely right - I reverted my incorrect change. The --keyring-backend flag is valid for add-genesis-account. Now investigating the real root cause of the "unknown command" error. Looking at documentation inconsistencies and prerequisite requirements. Commit 3234e9a

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • http://168.63.129.16:80/machine/
    • Triggering command: /usr/bin/python3 -u bin/WALinuxAgent-2.13.1.1-py3.9.egg -collect-logs (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Co-authored-by: jcstein <46639943+jcstein@users.noreply.github.com>
Comment thread how-to-guides/instantiate-testnet.md Outdated
Co-authored-by: jcstein <46639943+jcstein@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jun 4, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • http://168.63.129.16:80/machine/
    • Triggering command: /usr/bin/python3 -u bin/WALinuxAgent-2.13.1.1-py3.9.egg -collect-logs (http block)

If you need me to access, download, or install something from one of these locations, you can either:

@jcstein
Copy link
Copy Markdown
Member

jcstein commented Jun 4, 2025

fix based on this thanks @copilot

celestia-appd genesis add-genesis-account --help
Add a genesis account to genesis.json. The provided account must specify
the account address or key name and a list of initial coins. If a key name is given,
the address will be looked up in the local Keybase. The list of initial tokens must
contain valid denominations. Accounts may optionally be supplied with vesting parameters.

Usage:
  celestia-appd genesis add-genesis-account [address_or_key_name] [coin][,[coin]] [flags]

Flags:
      --append                   append the coins to an account already in the genesis.json file
      --grpc-addr string         the gRPC endpoint to use for this chain
      --grpc-insecure            allow gRPC over insecure channels, if not the server must use TLS
      --height int               Use a specific height to query state at (this can error if the node is pruning state)
  -h, --help                     help for add-genesis-account
      --home string              The application home directory (default "/Users/js/.celestia-app")
      --keyring-backend string   Select keyring's backend (os|file|kwallet|pass|test) (default "os")
      --module-name string       module account name
      --node string              <host>:<port> to CometBFT RPC interface for this chain (default "tcp://localhost:26657")
  -o, --output string            Output format (text|json) (default "text")
      --vesting-amount string    amount of coins for vesting accounts
      --vesting-end-time int     schedule end time (unix epoch) for vesting accounts
      --vesting-start-time int   schedule start time (unix epoch) for vesting accounts

Global Flags:
      --log-to-file string   Write logs directly to a file. If empty, logs are written to stderr
      --log_format string    The logging format (json|plain) (default "plain")
      --log_level string     The logging level (trace|debug|info|warn|error|fatal|panic|disabled or '*:<level>,<key>:<level>') (default "info")
      --log_no_color         Disable colored logs
      --trace                print out full stack trace on errors

Co-authored-by: jcstein <46639943+jcstein@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jun 4, 2025

fix based on this thanks @copilot

...

Fixed! Updated both files to use the correct celestia-appd genesis add-genesis-account command format. The missing genesis subcommand was the root cause of the "unknown command" error. Commit e74c5d8

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • http://168.63.129.16:80/machine/
    • Triggering command: /usr/bin/python3 -u bin/WALinuxAgent-2.13.1.1-py3.9.egg -collect-logs (http block)

If you need me to access, download, or install something from one of these locations, you can either:

@jcstein
Copy link
Copy Markdown
Member

jcstein commented Jun 4, 2025

remove the extra helper content you added @copilot -- just fix cmds

Co-authored-by: jcstein <46639943+jcstein@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jun 4, 2025

remove the extra helper content you added @copilot -- just fix cmds

Removed the extra helper content (prerequisites, troubleshooting, and explanatory text) while keeping the corrected commands with the genesis subcommand. Commit f69b532

@jcstein jcstein marked this pull request as ready for review June 5, 2025 01:01
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jun 5, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jcstein jcstein merged commit ae53185 into main Jun 5, 2025
4 of 6 checks passed
@jcstein jcstein deleted the copilot/fix-2057 branch June 5, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

how-to-guides: instantiate a testnet has outdated commands for "add genesis account keyname"

2 participants