docs: Explain necessary RPC to expose, and document it#2085
Conversation
Co-authored-by: jcstein <46639943+jcstein@users.noreply.github.com>
|
resume and resolve conflicts @copilot |
Co-authored-by: jcstein <46639943+jcstein@users.noreply.github.com>
Work resumed and completed! I've successfully addressed all the requirements from issue #2025:
Commit df727d5 contains all the changes. The documentation now provides clear guidance on which ports need external exposure and explains the difference between app-level (Cosmos SDK) and core-level (Tendermint) endpoints. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
|
fix formatting and why are there so many changes to package-lock?? @copilot |
Co-authored-by: jcstein <46639943+jcstein@users.noreply.github.com>
... Fixed both issues in commit 7184992:
The extensive package-lock.json changes occurred because I ran Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| **Ports that typically need external exposure:** | ||
|
|
||
| - **Port 2121**: Required for P2P connectivity with other nodes in the network | ||
| - **Port 9090**: Needed if your node will serve gRPC clients (like bridge nodes) |
There was a problem hiding this comment.
I don't think this should be exposed globally, that would allow anyone on the internet to call the gRPC.
There was a problem hiding this comment.
The default is localhost (see here) but this statement seems correct if the bridge node isn't running locally
- Port 9090: Needed if your node will serve gRPC clients (like bridge nodes)
There was a problem hiding this comment.
I don't have a concrete recommendation here. If we want to remove this line then maybe we can say:
"consensus node operators should run the bridge node locally and not expose the GRPC globally"?
There was a problem hiding this comment.
Presumably an operator that runs two nodes on different machines would be sophisticated enough to assign things like static IPs to them, so only the static IP of the bridge node machine would need to be listened to. Something like that. Listening globally will allow such a bridge node machine to connect, sure, but would also allow any other machine in the world to connect. Which is bad.
Co-authored-by: jcstein <46639943+jcstein@users.noreply.github.com>
…json from .gitignore (#2137) * Initial plan * Revert PR #2085 changes to .gitignore and celestia-app.md Co-authored-by: jcstein <46639943+jcstein@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jcstein <46639943+jcstein@users.noreply.github.com>
Fixes #2025.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.