Skip to content

[GH Action] Update release tags and commit SHAs for mocha #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcstein merged 1 commit into from
Jul 2, 2025
Merged

[GH Action] Update release tags and commit SHAs for mocha #2130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .vitepress/constants/mocha_versions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const mochaVersions = Object.freeze({
"app-latest-tag": "v4.0.6-mocha",
"app-latest-sha": "b95a0c9fb34beba47f802cdba2de690dc6f50711",
"app-latest-tag": "v4.0.7-mocha",
"app-latest-sha": "5e388903a058a7dfd8532a841a23f9764aa234c4",
Comment on lines +2 to +3
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change is correct, the flat structure of this object using string keys like "app-latest-tag" can become difficult to maintain as more components are added.

For better long-term maintainability and scalability, consider refactoring this object to use a nested structure in a follow-up PR. This would group related constants and improve readability.

For example:

const mochaVersions = Object.freeze({
  app: {
    latest: {
      tag: "v4.0.7-mocha",
      sha: "5e388903a058a7dfd8532a841a23f9764aa234c4"
    }
  },
  node: {
    latest: {
      tag: "v0.23.2-mocha",
      sha: "13f44136b2d3c8d46acf9a94de4dec3837253799"
    }
  }
});

This change would require updating the component(s) that consume these values.

"node-latest-tag": "v0.23.2-mocha",
"node-latest-sha": "13f44136b2d3c8d46acf9a94de4dec3837253799",
});
Expand Down
Loading