Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @jcstein, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on updating the project's documentation to include a critical piece of information: the specific upgrade height for the Mainnet Beta network. This ensures that users and operators have the most accurate and up-to-date details for participating in or tracking network upgrades, particularly for Lotus.
Highlights
- Documentation Update: Updated the network upgrade process documentation to specify the Mainnet Beta upgrade height.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
did this while in a call before seeing #2161 |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation to specify the mainnet upgrade height. My review focuses on improving the clarity of this update. I've suggested providing an estimated time for the upgrade or adding a note to explain why it's listed as 'TBD', to avoid confusion and maintain consistency with other information in the table.
| | Arabica | arabica-11 | 2025/05/16 07:51:35 UTC | 5975265 | 1 day | | ||
| | Mocha | mocha-4 | 2025/07/01 11:51:58 UTC | 6915786 | 2 days | | ||
| | Mainnet Beta | celestia | TBD | TBD | 7 days | | ||
| | Mainnet Beta | celestia | TBD | 6680339 | 7 days | |
There was a problem hiding this comment.
With the Upgrade Height now defined, leaving the Upgrade Time as TBD creates an inconsistency with the other network entries in this table and may be confusing for readers, as other networks have specific timestamps.
To improve clarity, please consider updating the Upgrade Time as well.
- If an exact time is not yet known, providing an estimate (e.g.,
~YYYY-MM-DD HH:MM UTC) would be helpful. - If the upgrade is strictly height-based and the time is intentionally not specified, adding a footnote to clarify this would prevent confusion.
For example, you could add a footnote like this:
| Mainnet Beta | celestia | TBD [1] | 6680339 | 7 days |
... and elsewhere in the file ...
[1]: Upgrade time is dependent on block height.
|
1 participant
Overview