Skip to content

docs: update heights for v5#2188

Merged
jcstein merged 2 commits intocelestiaorg:mainfrom
rootulp:rp/update-heights
Aug 7, 2025
Merged

docs: update heights for v5#2188
jcstein merged 2 commits intocelestiaorg:mainfrom
rootulp:rp/update-heights

Conversation

@rootulp
Copy link
Copy Markdown
Contributor

@rootulp rootulp commented Aug 6, 2025

Update the heights for v5 activation

Screenshot

Screenshot 2025-08-06 at 10 14 20 AM

@rootulp rootulp self-assigned this Aug 6, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @rootulp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've updated the documentation related to network upgrade processes, specifically focusing on the activation details for the upcoming v5 network upgrade. This ensures that the published information reflects the most current upgrade heights and dates for various networks.

Highlights

  • Documentation Update: Updated the how-to-guides/network-upgrade-process.md file to reflect the latest network upgrade information.
  • V5 Network Upgrade Details: Included specific activation dates and upgrade heights for the v5 network upgrade on Mocha and Mainnet Beta networks.
  • V4 Network Upgrade Details: Adjusted the estimated date for the v4 Mainnet Beta network upgrade.
  • Documentation Formatting: Standardized the formatting of markdown tables throughout the document for improved readability.
  • Document Structure: Reordered the "Upcoming Upgrades" warning section within the document.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

|--------------|------------|-------------------------|----------------|--------------|
| Arabica | arabica-11 | 2025/05/16 07:51:35 UTC | 5975265 | 1 day |
| Mocha | mocha-4 | 2025/07/01 11:51:58 UTC | 6915786 | 2 days |
| Mainnet Beta | celestia | 2025/07/28 13:46:27 UTC | 6680339 | 7 days |
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also updated this v4 time

@rootulp rootulp requested a review from Bidon15 August 6, 2025 14:15
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the network upgrade documentation, primarily to add the final heights and dates for the v5 upgrade. The changes include updating several tables with new data, improving markdown table formatting for consistency, and restructuring the document to correctly place the 'Upcoming Upgrades' section. The changes are generally good and improve the documentation. I have one minor suggestion to improve the grammatical tense consistency in the description of the v5 upgrade.

#### v5 network upgrade

The v5 network upgrade includes a fix to restore IBC support which was broken in v4.
The v5 network upgrade included a fix to restore IBC support which was broken in v4.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Good job changing this to the past tense. To maintain consistency, the following paragraph (line 88) should also be updated to use the past tense, as this is now a past upgrade. The current text uses 'will use' and 'will automatically activate'. You could model the tense on the 'Lotus network upgrade' section to ensure consistency across all past upgrades.

@rootulp rootulp requested a review from jcstein August 6, 2025 17:47
Copy link
Copy Markdown
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @rootulp - this LGTM

@jcstein jcstein merged commit c2cc4da into celestiaorg:main Aug 7, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants