Skip to content

Update node versions to v0.25.3 in arabica, mainnet, and mocha constants #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcstein merged 2 commits into from
Sep 2, 2025
Merged

Update node versions to v0.25.3 in arabica, mainnet, and mocha constants #2221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca106a3
Update node versions to v0.25.3 in arabica, mainnet, and mocha constants
gbarros Sep 2, 2025
9a7e03d
Merge branch 'main' into gb/v0.25.3
jcstein Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .vitepress/constants/arabica_versions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const arabicaVersions = Object.freeze({
"app-latest-tag": "v5.0.3-arabica",
"app-latest-sha": "85b61e09b8bacb778d190113621a67feaab8c4c4",
"node-latest-tag": "v0.25.2-arabica",
"node-latest-sha": "37c99f21098b785e174c44f0ef3e2b0dbd0049d5",
"node-latest-tag": "v0.25.3-arabica",
"node-latest-sha": "f28297bad87d1116973807a5f5c0f002fd608321",
});
export default arabicaVersions;
4 changes: 2 additions & 2 deletions .vitepress/constants/mainnet_versions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const mainnetVersions = Object.freeze({
"app-latest-tag": "v5.0.2",
"app-latest-sha": "323dda499ade71437a9855d99ca034d4e4869d66",
"node-latest-tag": "v0.24.1",
"node-latest-sha": "fb95d459d5c7ff14ebf697792287ca1cfd0848fa",
"node-latest-tag": "v0.25.3",
"node-latest-sha": "8bee349fb74ebb8fdcbe68fad4c9dae750a91807",
});
export default mainnetVersions;
4 changes: 2 additions & 2 deletions .vitepress/constants/mocha_versions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const mochaVersions = Object.freeze({
"app-latest-tag": "v5.0.2-mocha",
"app-latest-sha": "323dda499ade71437a9855d99ca034d4e4869d66",
"node-latest-tag": "v0.25.2-mocha",
"node-latest-sha": "37c99f21098b785e174c44f0ef3e2b0dbd0049d5",
"node-latest-tag": "v0.25.3-mocha",
"node-latest-sha": "f28297bad87d1116973807a5f5c0f002fd608321",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

I've noticed this SHA is also used in .vitepress/constants/arabica_versions.js. To improve maintainability and prevent potential inconsistencies during future updates, it would be beneficial to extract duplicated constants into a shared file.

For instance, you could create a common_versions.js file:

// .vitepress/constants/common_versions.js
export const shas = {
  NODE_LATEST_ARABICA_MOCHA: 'f28297bad87d1116973807a5f5c0f002fd608321',
  // other shared values can be added here
};

Then, you could import and use this constant in both mocha_versions.js and arabica_versions.js. This would centralize the value, making it easier and safer to update.

});
export default mochaVersions;
Loading