delete paragraph about long block times#2233
Conversation
Obsolete since halving 12 seconds to 6 seconds in the Ginger upgrade. Paragraph makes no sense now. 5c630b4
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @dynst, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the integrate-celestia.md tutorial by removing a section that described Celestia's block times as a 'notable exception' due to their length. This information became obsolete after the Ginger update, which standardized block times to 6 seconds, a duration now common in the Cosmos ecosystem. The change ensures the documentation accurately reflects the current state of the network.
Highlights
- Documentation Update: Removed an outdated paragraph from the
integrate-celestia.mdtutorial that discussed Celestia's 'long block times'. - Accuracy Improvement: The removed section was no longer relevant following the Ginger update, which established a 6-second block time, now considered common among Tendermint-based chains.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly removes an outdated section from the integrate-celestia.md tutorial. The removed paragraph described Celestia's block time as being 'significantly longer' than other chains, which is no longer accurate as the current block time is standard. This change improves the accuracy of the documentation for developers and service providers.
2 participants
Overview
docs/tutorials/integrate-celestia.md
Line 71 in 1ce4b22
Since 5c630b4 & #2052 this section makes no sense. The pre-Ginger block time of 12s was very unusual, but 6s is an extremely common block time - e.g. used by Cosmos Hub.