Skip to content

This branch adds the Twinkle guide and fixes a mismatch with fonts#2276

Merged
jcstein merged 1 commit intodocs-glow-upfrom
add-twinkle
Oct 27, 2025
Merged

This branch adds the Twinkle guide and fixes a mismatch with fonts#2276
jcstein merged 1 commit intodocs-glow-upfrom
add-twinkle

Conversation

@lukecd
Copy link
Copy Markdown
Contributor

@lukecd lukecd commented Oct 27, 2025

this pr adds a guide for using twinkle to post data and also fixes a small font mis-match problem

@lukecd lukecd requested a review from jcstein October 27, 2025 09:03
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @lukecd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new, detailed guide for integrating with the Twinkle API to manage data blobs on Celestia, providing step-by-step instructions for posting and retrieving data. Concurrently, it addresses a font inconsistency issue by standardizing font file formats to WOFF2 and reconfiguring the application's typography to ensure a cohesive visual experience.

Highlights

  • New Twinkle Guide: A comprehensive guide has been added for interacting with Celestia's data availability layer using the Twinkle API, covering detailed steps for blob posting and retrieval.
  • Font Standardization: Font file formats have been updated from TTF/OTF to WOFF2 for 'UntitledSans' and 'Youth' fonts, improving web performance and compatibility.
  • Font Mismatch Fix: The application's typography has been reconfigured by swapping the primary body font to 'UntitledSans' and heading fonts to 'Youth', resolving previous inconsistencies.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a guide for using Twinkle to post data and fixes a font mismatch. The guide provides instructions on how to use the Twinkle API to interact with Celestia's data availability layer. The font mismatch fix involves updating font file paths and applying the correct font families to different HTML elements. I have identified a few areas for improvement, primarily concerning code clarity and potential issues in the guide's instructions.

Comment thread app/fonts.css
Comment on lines 30 to +32
h1, h2, h3, h4, h5, h6 {
font-family: 'UntitledSans', sans-serif;
font-weight: 500;
font-family: 'Youth', sans-serif;
font-weight: 400;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The font-weight for h1, h2, h3, h4, h5, h6 is set to 400, which might not be ideal for headings. Consider using a bolder font-weight (e.g., 500 or 600) to make the headings stand out more.

Suggested change
h1, h2, h3, h4, h5, h6 {
font-family: 'UntitledSans', sans-serif;
font-weight: 500;
font-family: 'Youth', sans-serif;
font-weight: 400;
h1, h2, h3, h4, h5, h6 {
font-family: 'Youth', sans-serif;
font-weight: 500; /* Or another appropriate value */
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think we need this @lukecd ?

Comment thread app/globals.css
Comment on lines 22 to 25
body {
background: var(--background);
color: var(--foreground);
font-family: Arial, Helvetica, sans-serif;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The font-family declaration is removed from the body selector here, but it's already declared in app/fonts.css. Removing it here is correct, to avoid conflicts or overrides. However, ensure that the font declared in app/fonts.css is intended as the global font for the entire application. If not, this change might lead to unexpected font rendering issues.

@jcstein jcstein merged commit 6de46b5 into docs-glow-up Oct 27, 2025
1 check passed
@jcstein jcstein deleted the add-twinkle branch October 27, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants