Skip to content

Adhere to specs and hash the nid in leaf#47

Merged
liamsi merged 1 commit intomasterfrom
ismail/hash_nid_in_leaf
Sep 7, 2021
Merged

Adhere to specs and hash the nid in leaf#47
liamsi merged 1 commit intomasterfrom
ismail/hash_nid_in_leaf

Conversation

@liamsi
Copy link
Copy Markdown
Member

@liamsi liamsi commented Sep 7, 2021

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 7, 2021

Codecov Report

Merging #47 (95c972a) into master (02cdbfd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files           7        7           
  Lines         307      307           
=======================================
  Hits          291      291           
  Misses         11       11           
  Partials        5        5           
Impacted Files Coverage Δ
hasher.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02cdbfd...95c972a. Read the comment docs.

Copy link
Copy Markdown
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM!

thanks for updating this 👍

@liamsi liamsi merged commit d8fd217 into master Sep 7, 2021
@liamsi liamsi deleted the ismail/hash_nid_in_leaf branch September 7, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change NMT Leaf Node to Hash the NID

3 participants