Conversation
🦋 Changeset detectedLatest commit: a776591 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Closed
nicolasbrugneaux
force-pushed
the
fix-ci-caching
branch
from
1ec7733 to
026be72
Compare
yarn --cwd packages/sdk/contractkit test
aaronmgdr
force-pushed
the
fix-ci-caching
branch
from
026be72 to
bcd1c99
Compare
Contributor
|
Looks good, let's see if it passes tests once #35 is merged in this branch |
nicolasbrugneaux
approved these changes
Jan 10, 2024
* use setup node instead of container * cant set cache yarn yet * use yarn * node yarn then configure * ok it needs lock file so checkout first * sync yarn * must set the shell * checkout then sync * FIX LOCATION * use same path as social connect yarn --cwd packages/sdk/contractkit test * it worked the commit before this. so hopefully this just removes superfluous things * did it fix it? no but these are help to have * we actually do need 18.17 for the repo * fix: use runner differently * wip: tslint->eslint in CLI * wip: tslint->eslint in sdk/base * wip: tslint->eslint in sdk/connect * wip: tslint->eslint in sdk/contractkit * wip: tslint->eslint in sdk/cryptographic-utils * wip: tslint->eslint in sdk/explorer * wip: tslint->eslint in sdk/governance * wip: tslint->eslint in sdk/keystores * wip: tslint->eslint in sdk/network-utils * wip: tslint->eslint in sdk/transactions-uri * wip: tslint->eslint in sdk/phone-utils * wip: tslint->eslint in sdk/utils * wip: refactor * wip: tslint->eslint in sdk/wallets/wallet-base * wip: tslint->eslint in sdk/wallets/wallet-hsm * wip: tslint->eslint in sdk/wallets/wallet-hsm-aws * wip: tslint->eslint in sdk/wallets/wallet-hsm-azure * wip: tslint->eslint in sdk/wallets/wallet-hsm-gcp * wip: tslint->eslint in sdk/wallets/wallet-ledger * wip: tslint->eslint in sdk/wallets/wallet-local * wip: tslint->eslint in sdk/wallets/wallet-remote * wip: tslint->eslint in sdk/wallets/wallet-rpc * chore: cleanup * chore: cleanup and PR feedback * chore: remove unecessary command args * fix: build * dont ignore the eslint configs * dont merge check * chore: remove releasegold * chore: remove the yarn run lint:do-not-merge * fix: celocli tests --------- Co-authored-by: Aaron <aaron.deruvo@clabs.co>
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: tslint@5.20.1, tslint-config-prettier@1.18.0, tslint-eslint-rules@5.4.0, tslint-microsoft-contrib@6.2.0, tslint-react@4.2.0, tslint-react-hooks@2.2.2 |
lvpeschke
reviewed
Jan 10, 2024
aaronmgdr
added a commit
that referenced
this pull request
Jan 11, 2024
* upgrade all oclif related packages to latest * fix oclif docs regneration * Fix ci caching (#26) --------- Co-authored-by: Aaron <aaron.deruvo@clabs.co>
Merged
aaronmgdr
added a commit
that referenced
this pull request
Jan 11, 2024
* initial upgrade * enable corepack * yarn berry doesnt support most pre and post scripts https://typicode.github.io/husky/getting-started.html#yarn-2 * WIP * use yarn 4 * Oclif upgrade (#52) * upgrade all oclif related packages to latest * fix oclif docs regneration * Fix ci caching (#26) --------- Co-authored-by: Aaron <aaron.deruvo@clabs.co> --------- Co-authored-by: Aaron <aaron.deruvo@clabs.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what?
The Waterfall
There is a cascading situation of prs here as follows
#21 < #25 < This