Derivation Warnings #389

aaronmgdr · 2024-10-10T09:51:21Z

Description

Add warnings about the derivation path default changing in the future. as per https://forum.celo.org/t/deprecating-the-celo-derivation-path/9229

Other changes

add derivationPath to the output

Tested

yes new account:new tests

https://app.warp.dev/block/bYdy5uQ3WsAUT7rj1bT19l

Related issues

Prework for #352

Backwards compatibility

yes unless you count the output of the command which we do not as it is designed for humans to read.

Documentation

improved!

PR-Codex overview

This PR focuses on updates to the @celo/celocli and @celo/cryptographic-utils packages, including the addition of a warning about the new default ETH derivation path, improvements to the NewAccount command, and modifications to key generation functions.

Detailed summary

@celo/celocli: Allow account:new command to run without a node.
Added warning about default ETH derivation path in future versions.
Updated generateKeys, generateSeed, and related functions with parameter documentation.
Adjusted NewAccount command to reflect new derivation path logic.
Updated test cases to verify new behavior with derivation paths.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2024-10-10T09:51:25Z

🦋 Changeset detected

Latest commit: f1a4188

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@celo/cryptographic-utils	Patch
@celo/celocli	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2024-10-10T10:00:11Z

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.49%. Comparing base (576f902) to head (f1a4188).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
packages/sdk/cryptographic-utils/src/account.ts	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
+ Coverage   67.22%   67.49%   +0.27%     
==========================================
  Files         291      291              
  Lines       10972    10977       +5     
  Branches     1534     1536       +2     
==========================================
+ Hits         7376     7409      +33     
- Misses       3507     3536      +29     
+ Partials       89       32      -57

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gitguardian · 2024-10-10T11:44:32Z

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
14107624	Triggered	Generic High Entropy Secret	`c488f8f`	packages/cli/src/commands/account/new.test.ts	View secret
14107625	Triggered	Generic High Entropy Secret	`c488f8f`	packages/cli/src/commands/account/new.test.ts	View secret
14107626	Triggered	Generic High Entropy Secret	`c488f8f`	packages/cli/src/commands/account/new.test.ts	View secret
14107627	Triggered	Generic High Entropy Secret	`c488f8f`	packages/cli/src/commands/account/new.test.ts	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

packages/cli/src/commands/account/new.test.ts

@aaronmgdr

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated. ⚠️

⚠️

⚠️ `master` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `master`. ⚠️

⚠️

⚠️ # Releases ## @celo/celocli@6.0.0-beta.0 ### Major Changes - [#339](#339) [`87223ba`](87223ba) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Remove support for reserve:\* commands. As foretold by <https://forum.celo.org/t/sunset-of-reserve-commands/8454> - [#343](#343) [`54741cc`](54741cc) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Remove commands identity:identifier, identity:get-attestations See <https://forum.celo.org/t/rfc-deprecation-of-celocli-identity-commands/8676> ### Patch Changes - [#389](#389) [`5a0a922`](5a0a922) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Add warning that ETH derivation path will be the default in a future major breaking change. - [#395](#395) [`693f6e7`](693f6e7) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect message where the transfered token was used as gas token in the messaging but not in actuality - [#395](#395) [`693f6e7`](693f6e7) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix Transfering, exchanging cusd (and other fee tokens) and or using gasCurrency flag with ledger devices prior to 1.2 - [#389](#389) [`5a0a922`](5a0a922) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix: account:new can now be called without a node - Updated dependencies \[[`693f6e7`](693f6e7), [`5a0a922`](5a0a922), [`33ad4aa`](33ad4aa), [`4ef76eb`](4ef76eb), [`33ad4aa`](33ad4aa)]: - @celo/wallet-ledger@6.0.2-beta.0 - @celo/cryptographic-utils@5.1.1-beta.0 - @celo/contractkit@9.0.0-beta.0 - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 - @celo/metadata-claims@1.0.0-beta.0 - @celo/explorer@5.0.13-beta.0 - @celo/governance@5.1.4-beta.0 - @celo/connect@6.0.3-beta.0 - @celo/phone-utils@6.0.4-beta.0 - @celo/wallet-hsm-azure@6.0.2-beta.0 - @celo/wallet-local@6.0.2-beta.0 ## @celo/base@7.0.0-beta.0 ### Major Changes - [#228](#228) [`4ef76eb`](4ef76eb) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - remove deprecated functions and consts exported from ./contacts and ./displayformating. ./currencies and ./phonenumbers. If these are used by your app we recommend to inline the functions from the previous release. - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/contacts.ts> - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/displayFormatting.ts> - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/phoneNumbers.ts> <https://github.com/celo-org/developer-tooling/tree/%40celo/wallet-base%406.0.1/packages/sdk/base/src> Full List of removed exports -- ContactPhoneNumber, MinimalContact, getContactPhoneNumber, isContact, CURRENCY_ENUM, Currency, CURRENCIES, resolveCurrency, SHORT_CURRENCIES, currencyToShortMap | getErrorMessage | anonymizedPhone | getContactNameHash ## @celo/contractkit@9.0.0-beta.0 ### Major Changes - [#340](#340) [`33ad4aa`](33ad4aa) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Removes all exports under the lib/identity folder. These have been move to a new @celo/metadata-claims package and should be imported from there. Note that folder structure is also flattened slightly. so replace `@celo/contractkit/lib/identity/claims/` with `@celo/metadata-claims/lib/` example ```diff - import { createAccountClaim } from '@celo/contractkit/lib/identity/claims/account' + import { createAccountClaim } from '@celo/metadata-claims/lib/account' ``` ```diff - import { ContractKit, IdentityMetadataWrapper, newKitFromWeb3 } from '@celo/contractkit' - import { ClaimTypes } from '@celo/contractkit/lib/identity' + import { ContractKit, newKitFromWeb3 } from '@celo/contractkit' + import { ClaimTypes, IdentityMetadataWrapper } from '@celo/metadata-claims' ``` Note that Contractkit is Not a dependency. Instead when using `IdentityMetadataWrapper` you should make an object that satisfis the `AccountMetadataSignerGetters` type ```typescript import { AccountMetadataSignerGetters } from '@celo/metadata-claims/lib/types' ``` using viem it would be like ```typescript const accountsMetaDataSignerGetters: AccountMetadataSignerGetters = { isAccount: async (address: string) => accounts.read.isAccount([address as Address]), getValidatorSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), getVoteSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), getAttestationSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), } ``` ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 - @celo/connect@6.0.3-beta.0 - @celo/wallet-local@6.0.2-beta.0 ## @celo/metadata-claims@1.0.0-beta.0 ### Major Changes - [#340](#340) [`33ad4aa`](33ad4aa) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Introducing @celo/metadata-claims These are a series of functions extracted from @celo/contractkit since they didnt strictly need depend on contractkit itsefl. Developers can now use IdentityMetadataWrapper with any js rpc library like ethers or viem or web3js without being forced to import ContractKit. Instead when using `IdentityMetadataWrapper` you should make an object that satisfis the `AccountMetadataSignerGetters` type ```typescript import { AccountMetadataSignerGetters } from '@celo/metadata-claims/lib/types' ``` using viem it would be like ```typescript const accountsMetaDataSignerGetters: AccountMetadataSignerGetters = { isAccount: async (address: string) => accounts.read.isAccount([address as Address]), getValidatorSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), getVoteSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), getAttestationSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), } ``` ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 ## @celo/utils@8.0.0-beta.0 ### Major Changes - [#228](#228) [`4ef76eb`](4ef76eb) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - remove deprecated functions and consts exported from ./contacts and ./displayformating. ./currencies and ./phonenumbers. If these are used by your app we recommend to inline the functions from the previous release. - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/contacts.ts> - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/displayFormatting.ts> - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/phoneNumbers.ts> <https://github.com/celo-org/developer-tooling/tree/%40celo/wallet-base%406.0.1/packages/sdk/base/src> Full List of removed exports -- ContactPhoneNumber, MinimalContact, getContactPhoneNumber, isContact, CURRENCY_ENUM, Currency, CURRENCIES, resolveCurrency, SHORT_CURRENCIES, currencyToShortMap | getErrorMessage | anonymizedPhone | getContactNameHash ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 ## @celo/viem-account-ledger@1.0.0-beta.0 ### Major Changes - [#344](#344) [`6bba5e3`](6bba5e3) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Initial release ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 ## @celo/dev-utils@0.0.6-beta.0 ### Patch Changes - Updated dependencies \[]: - @celo/connect@6.0.3-beta.0 ## @celo/connect@6.0.3-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 ## @celo/cryptographic-utils@5.1.1-beta.0 ### Patch Changes - [#389](#389) [`5a0a922`](5a0a922) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Add warning that ETH derivation path will be the default in a future major breaking change. - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 ## @celo/explorer@5.0.13-beta.0 ### Patch Changes - Updated dependencies \[[`33ad4aa`](33ad4aa), [`4ef76eb`](4ef76eb)]: - @celo/contractkit@9.0.0-beta.0 - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 - @celo/connect@6.0.3-beta.0 ## @celo/governance@5.1.4-beta.0 ### Patch Changes - Updated dependencies \[[`33ad4aa`](33ad4aa), [`4ef76eb`](4ef76eb)]: - @celo/contractkit@9.0.0-beta.0 - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 - @celo/explorer@5.0.13-beta.0 - @celo/connect@6.0.3-beta.0 ## @celo/keystores@5.0.12-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/utils@8.0.0-beta.0 - @celo/wallet-local@6.0.2-beta.0 ## @celo/phone-utils@6.0.4-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 ## @celo/transactions-uri@5.0.12-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 - @celo/connect@6.0.3-beta.0 ## @celo/wallet-base@6.0.2-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 - @celo/connect@6.0.3-beta.0 ## @celo/wallet-hsm@6.0.2-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 ## @celo/wallet-hsm-aws@6.0.2-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/utils@8.0.0-beta.0 - @celo/connect@6.0.3-beta.0 - @celo/wallet-base@6.0.2-beta.0 - @celo/wallet-hsm@6.0.2-beta.0 - @celo/wallet-remote@6.0.2-beta.0 ## @celo/wallet-hsm-azure@6.0.2-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 - @celo/connect@6.0.3-beta.0 - @celo/wallet-base@6.0.2-beta.0 - @celo/wallet-hsm@6.0.2-beta.0 - @celo/wallet-remote@6.0.2-beta.0 ## @celo/wallet-hsm-gcp@6.0.2-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/utils@8.0.0-beta.0 - @celo/connect@6.0.3-beta.0 - @celo/wallet-base@6.0.2-beta.0 - @celo/wallet-hsm@6.0.2-beta.0 - @celo/wallet-remote@6.0.2-beta.0 ## @celo/wallet-ledger@6.0.2-beta.0 ### Patch Changes - [#395](#395) [`693f6e7`](693f6e7) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix issue where ledger running celo firmware app 1.1.10 could not send fee token transactions or perform and interactions with those contracts - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 - @celo/connect@6.0.3-beta.0 - @celo/wallet-base@6.0.2-beta.0 - @celo/wallet-remote@6.0.2-beta.0 ## @celo/wallet-local@6.0.2-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 - @celo/connect@6.0.3-beta.0 - @celo/wallet-base@6.0.2-beta.0 ## @celo/wallet-remote@6.0.2-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/utils@8.0.0-beta.0 - @celo/connect@6.0.3-beta.0 - @celo/wallet-base@6.0.2-beta.0  --- ## PR-Codex overview This PR focuses on updating various Celo SDK packages to their beta versions, enhancing dependency management and incorporating new features. It includes significant version bumps and updates to changelogs across multiple packages. ### Detailed summary - Updated `@celo/base` to `7.0.0-beta.0` - Updated `@celo/connect` to `6.0.3-beta.0` - Updated `@celo/utils` to `8.0.0-beta.0` - Updated `@celo/dev-utils` to `0.0.6-beta.0` - Added multiple changelog entries for various packages - Introduced new `@celo/metadata-claims` package at `1.0.0-beta.0` - Updated `@celo/contractkit` to `9.0.0-beta.0` - Updated versions in `CHANGELOG.md` files across several packages > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`  Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

@aaronmgdr

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated. # Releases ## @celo/celocli@6.0.0 ### Major Changes - [#407](#407) [`3890220`](3890220) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Remove transfer:gold -- this was an old alias for transfer:celo which has the same functionality - [#412](#412) [`23d36cc`](23d36cc) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Remove `celocli validator:force-deaffiliate` This command was only ever usable pre mainnet launch. The force deaffiliate method it would call is only callable by one of the whitelisted Slasher Contracts. To force removal of validator with poor uptime use `celocli validator:downtime-slash` or to sever association with a validator from your group use `celocli validator:deaffiliate` - [#339](#339) [`87223ba`](87223ba) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Remove support for reserve:\* commands. As foretold by <https://forum.celo.org/t/sunset-of-reserve-commands/8454> - [#407](#407) [`3890220`](3890220) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Remove account:recover-old This was meant to be a temporary command for migrating account from a beta version of Valora to the release version. Please use a previous version of celocli if you need to make this one time recovery. - [#343](#343) [`54741cc`](54741cc) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Remove commands identity:identifier, identity:get-attestations See <https://forum.celo.org/t/rfc-deprecation-of-celocli-identity-commands/8676> ### Minor Changes - [#420](#420) [`fb08485`](fb08485) Thanks [@shazarre](https://github.com/shazarre)! - Adds support for safe integration for L2 hotfix security council approvals - [#429](#429) [`5b02036`](5b02036) Thanks [@shazarre](https://github.com/shazarre)! - Removes L2 BLS keys support for account:authorize - [#447](#447) [`7bc05c2`](7bc05c2) Thanks [@shazarre](https://github.com/shazarre)! - validator:signed-blocks not supported on L2 anymore, fixes validator:status L2 - [#471](#471) [`26b9779`](26b9779) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - For `account:new` command add alias "celoLegacy" to the `--derivationPath` flag - [#459](#459) [`0e559c7`](0e559c7) Thanks [@shazarre](https://github.com/shazarre)! - Introduces a new command `account:claim-rpc-url` allowing to claim RPC URLs - [`76045eb`](76045eb) Thanks [@shazarre](https://github.com/shazarre)! - BLS keys are now optional as being deprecated on L2, validator:register and releasecelo:authorize no longer require them in L2 context ### Patch Changes - [#421](#421) [`7d42a05`](7d42a05) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - fix governance:build-proposal with contracts from mento or which use solidity 0.8 - [#463](#463) [`eba89a3`](eba89a3) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Add GovernanceSlasher to RegisteredContractsEnum - [#389](#389) [`5a0a922`](5a0a922) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Add warning that ETH derivation path will be the default in a future major breaking change. - [#425](#425) [`952bc81`](952bc81) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - deprecates the flags --whitelisters and --nonwhitelisters from the governance:show command - [#456](#456) [`d5c9204`](d5c9204) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Fix rewards:show for L2 - [#472](#472) [`1df8688`](1df8688) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Dont show flags for privateKey, gasCurrency, useLedger, and related flags in help for commands which dont actually make use of them. - [#395](#395) [`693f6e7`](693f6e7) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect message where the transfered token was used as gas token in the messaging but not in actuality - [#395](#395) [`693f6e7`](693f6e7) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix Transfering, exchanging cusd (and other fee tokens) and or using gasCurrency flag with ledger devices prior to 1.2 - [#471](#471) [`26b9779`](26b9779) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - when account:new is called it displays the full bip44 derivation path in the output. Before it would miss the last 2 positions. - [#480](#480) [`b83d8c4`](b83d8c4) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Recommended node version is now node 20 - [#452](#452) [`2283374`](2283374) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Show deprecated warning on flags which will be removed after cel2 launch - [#389](#389) [`5a0a922`](5a0a922) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix: account:new can now be called without a node - [#449](#449) [`97f0a53`](97f0a53) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Show --node and --useLedger flags when --help is called. Show aliases for networks in --node help - [#452](#452) [`2283374`](2283374) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - use onchain values instead of static for lock requirements - [#450](#450) [`9558b56`](9558b56) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Gracefully throw if --estimate wasnt passed on L1 - [#427](#427) [`ee33677`](ee33677) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Change a dependency to use npm rather than github - Updated dependencies \[[`eba89a3`](eba89a3), [`43e8474`](43e8474), [`693f6e7`](693f6e7), [`7d42a05`](7d42a05), [`c4b9c6d`](c4b9c6d), [`7bc05c2`](7bc05c2), [`5a0a922`](5a0a922), [`0e559c7`](0e559c7), [`33ad4aa`](33ad4aa), [`d988d31`](d988d31), [`42d091f`](42d091f), [`b83d8c4`](b83d8c4), [`36c4369`](36c4369), [`4ef76eb`](4ef76eb), [`76045eb`](76045eb), [`38fe4d0`](38fe4d0), [`26b9779`](26b9779), [`33ad4aa`](33ad4aa), [`b366827`](b366827), [`a23246e`](a23246e), [`fb08485`](fb08485), [`7d42a05`](7d42a05), [`ee33677`](ee33677), [`d5c9204`](d5c9204)]: - @celo/contractkit@9.0.0 - @celo/governance@5.1.4 - @celo/wallet-ledger@6.0.4 - @celo/wallet-hsm-azure@6.0.4 - @celo/wallet-local@6.0.4 - @celo/cryptographic-utils@5.1.1 - @celo/metadata-claims@1.0.0 - @celo/base@7.0.0 - @celo/utils@8.0.0 - @celo/connect@6.1.0 - @celo/explorer@5.0.13 - @celo/phone-utils@6.0.4 ## @celo/base@7.0.0 ### Major Changes - [#228](#228) [`4ef76eb`](4ef76eb) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - remove deprecated functions and consts exported from ./contacts and ./displayformating. ./currencies and ./phonenumbers. If these are used by your app we recommend to inline the functions from the previous release. - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/contacts.ts> - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/displayFormatting.ts> - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/phoneNumbers.ts> <https://github.com/celo-org/developer-tooling/tree/%40celo/wallet-base%406.0.1/packages/sdk/base/src> Full List of removed exports -- ContactPhoneNumber, MinimalContact, getContactPhoneNumber, isContact, CURRENCY_ENUM, Currency, CURRENCIES, resolveCurrency, SHORT_CURRENCIES, currencyToShortMap | getErrorMessage | anonymizedPhone | getContactNameHash ### Minor Changes - [#471](#471) [`26b9779`](26b9779) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - add DerivationPathAliases export ## @celo/contractkit@9.0.0 ### Major Changes - [#340](#340) [`33ad4aa`](33ad4aa) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Removes all exports under the lib/identity folder. These have been move to a new @celo/metadata-claims package and should be imported from there. Note that folder structure is also flattened slightly. so replace `@celo/contractkit/lib/identity/claims/` with `@celo/metadata-claims/lib/` example ```diff - import { createAccountClaim } from '@celo/contractkit/lib/identity/claims/account' + import { createAccountClaim } from '@celo/metadata-claims/lib/account' ``` ```diff - import { ContractKit, IdentityMetadataWrapper, newKitFromWeb3 } from '@celo/contractkit' - import { ClaimTypes } from '@celo/contractkit/lib/identity' + import { ContractKit, newKitFromWeb3 } from '@celo/contractkit' + import { ClaimTypes, IdentityMetadataWrapper } from '@celo/metadata-claims' ``` Note that Contractkit is Not a dependency. Instead when using `IdentityMetadataWrapper` you should make an object that satisfis the `AccountMetadataSignerGetters` type ```typescript import { AccountMetadataSignerGetters } from '@celo/metadata-claims/lib/types' ``` using viem it would be like ```typescript const accountsMetaDataSignerGetters: AccountMetadataSignerGetters = { isAccount: async (address: string) => accounts.read.isAccount([address as Address]), getValidatorSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), getVoteSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), getAttestationSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), } ``` ### Minor Changes - [#447](#447) [`7bc05c2`](7bc05c2) Thanks [@shazarre](https://github.com/shazarre)! - Exposes EpochManager.getElectedSigners contract method - [`76045eb`](76045eb) Thanks [@shazarre](https://github.com/shazarre)! - ValidatorsWrapper: add registerValidatorNoBls to allow registration without BLS keys which are not supported in L2 ### Patch Changes - [#463](#463) [`eba89a3`](eba89a3) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Add GovernanceSlasher to RegisteredContractsEnum - [#467](#467) [`43e8474`](43e8474) Thanks [@shazarre](https://github.com/shazarre)! - fix: add transferOwnership() to proxy abi list - [#446](#446) [`42d091f`](42d091f) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Bump @celo/abis-12 - [#480](#480) [`b83d8c4`](b83d8c4) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Recommended node version is now node 20 - [#455](#455) [`36c4369`](36c4369) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Mark contract wrapper methods that will not work on L2 because solidity contracts have onlyL1 modifier as deprecated. | Deprecated Contract / Method | Replacement or none | | -------------------------------------------- | ----------------------------------------- | | Validators#registerValidator | Validators#registerValidatorNoBLS | | BlockchainParams#getEpochNumberOfBlock | EpochManager#getEpochNumberOfBlock | | BlockchainParams#getFirstBlockNumberForEpoch | EpochManager#getFirstBlockAtEpoch | | Election#getCurrentValidatorSigners | EpochManager#getElectedSigners | | Election#getGroupEpochRewards | Election#getGroupEpochRewardsBasedOnScore | | GovernanceSlasher#slash | GovernanceSlasher#slashL2 | | DoubleSigningSlasher | X | | DowntimeSlasher | X | - [#400](#400) [`38fe4d0`](38fe4d0) Thanks [@shazarre](https://github.com/shazarre)! - Renames `getElected` and its usages to `getElectedAccounts` for `EpochManagerWrapper` - [#456](#456) [`d5c9204`](d5c9204) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Backwards compat for some methods using epoch's block numbers - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`d988d31`](d988d31), [`4ef76eb`](4ef76eb), [`26b9779`](26b9779), [`fb08485`](fb08485)]: - @celo/wallet-local@6.0.4 - @celo/base@7.0.0 - @celo/utils@8.0.0 - @celo/connect@6.1.0 ## @celo/metadata-claims@1.0.0 ### Major Changes - [#340](#340) [`33ad4aa`](33ad4aa) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Introducing @celo/metadata-claims These are a series of functions extracted from @celo/contractkit since they didnt strictly need depend on contractkit itsefl. Developers can now use IdentityMetadataWrapper with any js rpc library like ethers or viem or web3js without being forced to import ContractKit. Instead when using `IdentityMetadataWrapper` you should make an object that satisfis the `AccountMetadataSignerGetters` type ```typescript import { AccountMetadataSignerGetters } from '@celo/metadata-claims/lib/types' ``` using viem it would be like ```typescript const accountsMetaDataSignerGetters: AccountMetadataSignerGetters = { isAccount: async (address: string) => accounts.read.isAccount([address as Address]), getValidatorSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), getVoteSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), getAttestationSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), } ``` ### Minor Changes - [#459](#459) [`0e559c7`](0e559c7) Thanks [@shazarre](https://github.com/shazarre)! - Add support for RPC_URL claim type ### Patch Changes - [#475](#475) [`b366827`](b366827) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Publish lib instead of src - Updated dependencies \[[`4ef76eb`](4ef76eb), [`26b9779`](26b9779)]: - @celo/base@7.0.0 - @celo/utils@8.0.0 ## @celo/utils@8.0.0 ### Major Changes - [#228](#228) [`4ef76eb`](4ef76eb) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - remove deprecated functions and consts exported from ./contacts and ./displayformating. ./currencies and ./phonenumbers. If these are used by your app we recommend to inline the functions from the previous release. - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/contacts.ts> - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/displayFormatting.ts> - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/phoneNumbers.ts> <https://github.com/celo-org/developer-tooling/tree/%40celo/wallet-base%406.0.1/packages/sdk/base/src> Full List of removed exports -- ContactPhoneNumber, MinimalContact, getContactPhoneNumber, isContact, CURRENCY_ENUM, Currency, CURRENCIES, resolveCurrency, SHORT_CURRENCIES, currencyToShortMap | getErrorMessage | anonymizedPhone | getContactNameHash ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb), [`26b9779`](26b9779)]: - @celo/base@7.0.0 ## @celo/viem-account-ledger@1.0.0 ### Major Changes - [#344](#344) [`6bba5e3`](6bba5e3) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Initial release ### Patch Changes - [#443](#443) [`a23246e`](a23246e) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Safer handling of v from device - [#427](#427) [`ee33677`](ee33677) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Change a dependency to use npm rather than github - Updated dependencies \[[`4ef76eb`](4ef76eb), [`26b9779`](26b9779)]: - @celo/base@7.0.0 ## @celo/connect@6.1.0 ### Minor Changes - [#420](#420) [`fb08485`](fb08485) Thanks [@shazarre](https://github.com/shazarre)! - Now CeloProvider can be wrapped in EIP-1193 partially compatible object (request + args) ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb), [`26b9779`](26b9779)]: - @celo/base@7.0.0 - @celo/utils@8.0.0 ## @celo/dev-utils@0.0.7 ### Patch Changes - [#400](#400) [`38fe4d0`](38fe4d0) Thanks [@shazarre](https://github.com/shazarre)! - Upgrades to latest devchain - [#446](#446) [`42d091f`](42d091f) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Bump @celo/abis-12 - [#420](#420) [`fb08485`](fb08485) Thanks [@shazarre](https://github.com/shazarre)! - Adds actual Celo chain id when running anvil - Updated dependencies \[[`fb08485`](fb08485)]: - @celo/connect@6.1.0 ## @celo/cryptographic-utils@5.1.1 ### Patch Changes - [#389](#389) [`5a0a922`](5a0a922) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Add warning that ETH derivation path will be the default in a future major breaking change. - Updated dependencies \[[`4ef76eb`](4ef76eb), [`26b9779`](26b9779)]: - @celo/base@7.0.0 - @celo/utils@8.0.0 ## @celo/explorer@5.0.13 ### Patch Changes - Updated dependencies \[[`eba89a3`](eba89a3), [`43e8474`](43e8474), [`7bc05c2`](7bc05c2), [`33ad4aa`](33ad4aa), [`42d091f`](42d091f), [`b83d8c4`](b83d8c4), [`36c4369`](36c4369), [`4ef76eb`](4ef76eb), [`76045eb`](76045eb), [`38fe4d0`](38fe4d0), [`26b9779`](26b9779), [`fb08485`](fb08485), [`d5c9204`](d5c9204)]: - @celo/contractkit@9.0.0 - @celo/base@7.0.0 - @celo/utils@8.0.0 - @celo/connect@6.1.0 ## @celo/governance@5.1.4 ### Patch Changes - [#463](#463) [`eba89a3`](eba89a3) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Add GovernanceSlasher to RegisteredContractsEnum - [#421](#421) [`7d42a05`](7d42a05) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - minor update to inquirer lib - [#446](#446) [`42d091f`](42d091f) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Bump @celo/abis-12 - [#421](#421) [`7d42a05`](7d42a05) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix being unable to use 08 and mento contracts with proposal builder - Updated dependencies \[[`eba89a3`](eba89a3), [`43e8474`](43e8474), [`7bc05c2`](7bc05c2), [`33ad4aa`](33ad4aa), [`42d091f`](42d091f), [`b83d8c4`](b83d8c4), [`36c4369`](36c4369), [`4ef76eb`](4ef76eb), [`76045eb`](76045eb), [`38fe4d0`](38fe4d0), [`26b9779`](26b9779), [`fb08485`](fb08485), [`d5c9204`](d5c9204)]: - @celo/contractkit@9.0.0 - @celo/base@7.0.0 - @celo/utils@8.0.0 - @celo/connect@6.1.0 - @celo/explorer@5.0.13 ## @celo/keystores@5.0.12 ### Patch Changes - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`d988d31`](d988d31), [`4ef76eb`](4ef76eb)]: - @celo/wallet-local@6.0.4 - @celo/utils@8.0.0 ## @celo/phone-utils@6.0.4 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb), [`26b9779`](26b9779)]: - @celo/base@7.0.0 - @celo/utils@8.0.0 ## @celo/transactions-uri@5.0.12 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb), [`26b9779`](26b9779), [`fb08485`](fb08485)]: - @celo/base@7.0.0 - @celo/connect@6.1.0 ## @celo/wallet-base@6.0.4 ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - [#408](#408) [`d988d31`](d988d31) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Improve support for celo-legacy and modern txs within ledger - Updated dependencies \[[`4ef76eb`](4ef76eb), [`26b9779`](26b9779), [`fb08485`](fb08485)]: - @celo/base@7.0.0 - @celo/utils@8.0.0 - @celo/connect@6.1.0 ## @celo/wallet-hsm@6.0.4 ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - Updated dependencies \[[`4ef76eb`](4ef76eb), [`26b9779`](26b9779)]: - @celo/base@7.0.0 ## @celo/wallet-hsm-aws@6.0.4 ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`d988d31`](d988d31), [`4ef76eb`](4ef76eb), [`fb08485`](fb08485)]: - @celo/wallet-remote@6.0.4 - @celo/wallet-base@6.0.4 - @celo/wallet-hsm@6.0.4 - @celo/utils@8.0.0 - @celo/connect@6.1.0 ## @celo/wallet-hsm-azure@6.0.4 ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`d988d31`](d988d31), [`4ef76eb`](4ef76eb), [`26b9779`](26b9779), [`fb08485`](fb08485)]: - @celo/wallet-remote@6.0.4 - @celo/wallet-base@6.0.4 - @celo/wallet-hsm@6.0.4 - @celo/base@7.0.0 - @celo/utils@8.0.0 - @celo/connect@6.1.0 ## @celo/wallet-hsm-gcp@6.0.4 ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`d988d31`](d988d31), [`4ef76eb`](4ef76eb), [`fb08485`](fb08485)]: - @celo/wallet-remote@6.0.4 - @celo/wallet-base@6.0.4 - @celo/wallet-hsm@6.0.4 - @celo/utils@8.0.0 - @celo/connect@6.1.0 ## @celo/wallet-ledger@6.0.4 ### Patch Changes - [#395](#395) [`693f6e7`](693f6e7) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix issue where ledger running celo firmware app 1.1.10 could not send fee token transactions or perform and interactions with those contracts - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - [#408](#408) [`d988d31`](d988d31) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Improve support for celo-legacy and modern txs within ledger - [#443](#443) [`a23246e`](a23246e) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Safer handling of v from device - [#427](#427) [`ee33677`](ee33677) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Change a dependency to use npm rather than github - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`d988d31`](d988d31), [`4ef76eb`](4ef76eb), [`26b9779`](26b9779), [`fb08485`](fb08485)]: - @celo/wallet-remote@6.0.4 - @celo/wallet-base@6.0.4 - @celo/base@7.0.0 - @celo/utils@8.0.0 - @celo/connect@6.1.0 ## @celo/wallet-local@6.0.4 ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - [#408](#408) [`d988d31`](d988d31) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Improve support for celo-legacy and modern txs within ledger - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`d988d31`](d988d31), [`4ef76eb`](4ef76eb), [`26b9779`](26b9779), [`fb08485`](fb08485)]: - @celo/wallet-base@6.0.4 - @celo/base@7.0.0 - @celo/utils@8.0.0 - @celo/connect@6.1.0 ## @celo/wallet-remote@6.0.4 ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`d988d31`](d988d31), [`4ef76eb`](4ef76eb), [`fb08485`](fb08485)]: - @celo/wallet-base@6.0.4 - @celo/utils@8.0.0 - @celo/connect@6.1.0  --- ## PR-Codex overview This PR primarily focuses on updating the versions of various `@celo` packages from beta versions to stable releases, along with some minor dependency updates and changelog entries for new features and fixes. ### Detailed summary - Deleted multiple `.changeset` files. - Updated versions for `@celo/base`, `@celo/utils`, `@celo/connect`, `@celo/contractkit`, and several wallet packages from beta to stable. - Added changelog entries for patch updates in various packages. - Improved support for ledger transactions and fixed bugs related to wallet interactions. > The following files were skipped due to too many changes: `yarn.lock` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`  Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

aaronmgdr added 2 commits October 9, 2024 16:54

warn about derivations

1ecddb0

Displsy derivationPath info when generating accounts

c6ec7f5

aaronmgdr requested a review from a team as a code owner October 10, 2024 09:51

aaronmgdr marked this pull request as draft October 10, 2024 09:55

Add tests for account:new

c488f8f

aaronmgdr marked this pull request as ready for review October 10, 2024 11:47

shazarre reviewed Oct 10, 2024

View reviewed changes

packages/cli/src/commands/account/new.test.ts Outdated Show resolved Hide resolved

packages/cli/src/commands/account/new.test.ts Show resolved Hide resolved

aaronmgdr added 3 commits October 10, 2024 14:57

changeset for not requiring node to generated account

784c3f3

spelling

cd574e4

docs

f1a4188

shazarre approved these changes Oct 11, 2024

View reviewed changes

aaronmgdr merged commit 5a0a922 into master Oct 11, 2024

aaronmgdr deleted the aaronmgdr/derivation-warning branch October 11, 2024 10:57

github-actions bot mentioned this pull request Oct 11, 2024

Version Packages (beta) #355

Merged

github-actions bot mentioned this pull request Dec 11, 2024

Version Packages #485

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Derivation Warnings #389

Derivation Warnings #389

Uh oh!

aaronmgdr commented Oct 10, 2024 •

edited by pr-codex bot

Loading

Uh oh!

changeset-bot bot commented Oct 10, 2024 •

edited

Loading

Uh oh!

codecov bot commented Oct 10, 2024 •

edited

Loading

Uh oh!

gitguardian bot commented Oct 10, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Derivation Warnings #389

Derivation Warnings #389

Uh oh!

Conversation

aaronmgdr commented Oct 10, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Other changes

Tested

Related issues

Backwards compatibility

Documentation

PR-Codex overview

Detailed summary

Uh oh!

changeset-bot bot commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codecov bot commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gitguardian bot commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aaronmgdr commented Oct 10, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Oct 10, 2024 •

edited

Loading

codecov bot commented Oct 10, 2024 •

edited

Loading

gitguardian bot commented Oct 10, 2024 •

edited

Loading