-
Notifications
You must be signed in to change notification settings - Fork 31
Fix typos in RELEASE.md and account.md documentation #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Hey Thanks for the contribution! The files in docs/*** are autogenerated from comments in the files. so to fix you could do a find all across the repo for "beneficary" Otherwise the build will fail as the commited docs from your pr will not match the generated ones. |
|
Hi @aaronmgdr ! I reviewed the repository and performed a thorough search for the word "beneficary," but I didn’t find any instances of this typo in the code or documentation. Please let me know if there's anything else I should check. |
|
oh you need to search for the misspelling benficiary |
|
@aaronmgdr Fixed |
Pull request was closed
Pull request was closed
|
i had to re open here #440 we have a ci steps which gets a specific version of foundry and something about the permissions dont work on forks right now |
|
@cypherpepe oh I didnt realize you would be penalized for me closing the pr. Ill try to work with dev rel to repeal that strike |
… others. but prs from outside cant access vars. so hardcode it in just one place
|
Hi @aaronmgdr thank you for flagging this to me. I'll reach out to the Scout Game. This repository should not have been added to the game. Will sort it out. |
### Description Corrected minor spelling errors in documentation files. These changes improve the clarity and accuracy of the content. #### Other changes Fixed the typo in the RELEASE.md file: corrected "significant" to the correct spelling. Fixed the typo in the docs/command-line-interface/account.md file: corrected "beneficary" to "beneficiary". ### Related issues - replaces #433 -- some of our ci seems to not run on forked requests namely foundry <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on correcting typographical errors related to the word "beneficiary" across various files, ensuring consistency and clarity in documentation and code comments. ### Detailed summary - Corrected "benficiary" to "beneficiary" in comments and descriptions in: - `packages/sdk/contractkit/src/wrappers/Accounts.ts` - `packages/cli/src/commands/account/register-data-encryption-key.ts` - `packages/cli/src/commands/account/delete-payment-delegation.ts` - `packages/sdk/explorer/fixtures/contract.metadata.json` - `docs/sdk/contractkit/classes/wrappers_Accounts.AccountsWrapper.md` - `RELEASE.md` - `docs/command-line-interface/account.md` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> --------- Co-authored-by: Cypher Pepe <125112044+cypherpepe@users.noreply.github.com>
|
replaced with #440 please give the submitter credit @GigaHierz |
Description
Corrected minor spelling errors in documentation files. These changes improve the clarity and accuracy of the content.
Other changes
RELEASE.mdfile: corrected "significant" to the correct spelling.docs/command-line-interface/account.mdfile: corrected "beneficary" to "beneficiary".PR-Codex overview
This PR focuses on correcting the spelling of the word
beneficiaryin multiple places across the codebase and updating the description of thedeletePaymentDelegationfunctionality for clarity.Detailed summary
benficiarytobeneficiaryin comments and documentation.Accounts.ts,register-data-encryption-key.ts,delete-payment-delegation.ts, and other related files for consistency.AddesstoAddressin command flags documentation.RELEASE.mdfor clarity and grammar.