Skip to content

Conversation

@cypherpepe
Copy link
Contributor

@cypherpepe cypherpepe commented Nov 13, 2024

Description

Corrected minor spelling errors in documentation files. These changes improve the clarity and accuracy of the content.

Other changes

  • Fixed the typo in the RELEASE.md file: corrected "significant" to the correct spelling.
  • Fixed the typo in the docs/command-line-interface/account.md file: corrected "beneficary" to "beneficiary".

PR-Codex overview

This PR focuses on correcting the spelling of the word beneficiary in multiple places across the codebase and updating the description of the deletePaymentDelegation functionality for clarity.

Detailed summary

  • Corrected spelling of benficiary to beneficiary in comments and documentation.
  • Updated descriptions in Accounts.ts, register-data-encryption-key.ts, delete-payment-delegation.ts, and other related files for consistency.
  • Fixed the spelling of Addess to Address in command flags documentation.
  • Minor updates in RELEASE.md for clarity and grammar.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@cypherpepe cypherpepe requested a review from a team as a code owner November 13, 2024 17:32
@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: 46b5dbd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aaronmgdr
Copy link
Member

Hey Thanks for the contribution!

The files in docs/*** are autogenerated from comments in the files. so to fix you could do a find all across the repo for "beneficary"

Otherwise the build will fail as the commited docs from your pr will not match the generated ones.

@cypherpepe
Copy link
Contributor Author

Hi @aaronmgdr !

I reviewed the repository and performed a thorough search for the word "beneficary," but I didn’t find any instances of this typo in the code or documentation. Please let me know if there's anything else I should check.

@aaronmgdr
Copy link
Member

oh you need to search for the misspelling benficiary

@cypherpepe
Copy link
Contributor Author

@aaronmgdr Fixed

@aaronmgdr aaronmgdr enabled auto-merge (squash) November 15, 2024 08:22
@aaronmgdr aaronmgdr closed this Nov 15, 2024
auto-merge was automatically disabled November 15, 2024 08:52

Pull request was closed

@aaronmgdr aaronmgdr reopened this Nov 15, 2024
@aaronmgdr aaronmgdr enabled auto-merge (squash) November 15, 2024 08:55
@aaronmgdr aaronmgdr closed this Nov 15, 2024
auto-merge was automatically disabled November 15, 2024 08:58

Pull request was closed

@aaronmgdr
Copy link
Member

i had to re open here #440

we have a ci steps which gets a specific version of foundry and something about the permissions dont work on forks right now

@aaronmgdr aaronmgdr reopened this Nov 15, 2024
@aaronmgdr
Copy link
Member

@cypherpepe oh I didnt realize you would be penalized for me closing the pr. Ill try to work with dev rel to repeal that strike

… others. but prs from outside cant access vars. so hardcode it in just one place
@GigaHierz
Copy link

Hi @aaronmgdr thank you for flagging this to me. I'll reach out to the Scout Game. This repository should not have been added to the game. Will sort it out.

aaronmgdr added a commit that referenced this pull request Nov 18, 2024
### Description

Corrected minor spelling errors in documentation files. These changes
improve the clarity and accuracy of the content.



#### Other changes

Fixed the typo in the RELEASE.md file: corrected "significant" to the
correct spelling.
Fixed the typo in the docs/command-line-interface/account.md file:
corrected "beneficary" to "beneficiary".

### Related issues

- replaces #433 -- some of our ci seems to not run on forked requests
namely foundry


<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on correcting typographical errors related to the word
"beneficiary" across various files, ensuring consistency and clarity in
documentation and code comments.

### Detailed summary
- Corrected "benficiary" to "beneficiary" in comments and descriptions
in:
  - `packages/sdk/contractkit/src/wrappers/Accounts.ts`
  - `packages/cli/src/commands/account/register-data-encryption-key.ts`
  - `packages/cli/src/commands/account/delete-payment-delegation.ts`
  - `packages/sdk/explorer/fixtures/contract.metadata.json`
  - `docs/sdk/contractkit/classes/wrappers_Accounts.AccountsWrapper.md`
  - `RELEASE.md`
  - `docs/command-line-interface/account.md`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`

<!-- end pr-codex -->

---------

Co-authored-by: Cypher Pepe <125112044+cypherpepe@users.noreply.github.com>
@aaronmgdr
Copy link
Member

replaced with #440 please give the submitter credit @GigaHierz

@aaronmgdr aaronmgdr closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants