Skip to content

upgrades @azure/* to latest #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronmgdr merged 3 commits into from
Jan 29, 2024
Merged

upgrades @azure/* to latest #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0704e0
upgrades azure/* to latest
aaronmgdr Jan 25, 2024
b397efa
add changeset
aaronmgdr Jan 25, 2024
1aa1a74
add changeset
aaronmgdr Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/funny-feet-suffer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
'@celo/wallet-hsm-azure': patch
---

Bump all @azure packages to latest versions. These includes several major bumps which should not affect use in this library. For More details
* https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/identity/identity/CHANGELOG.md
* https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/identity/identity/BREAKING_CHANGES.md
* https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/keyvault/keyvault-secrets/CHANGELOG.md
* https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/keyvault/keyvault-keys/CHANGELOG.md
10 changes: 5 additions & 5 deletions packages/sdk/wallets/wallet-hsm-azure/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,17 @@
"sdk"
],
"scripts": {
"build": "tsc -b .",
"clean": "tsc -b . --clean",
"build": "yarn run --top-level tsc -b .",
"clean": "yarn run --top-level tsc -b . --clean",
"docs": "yarn run --top-level typedoc",
"test": "yarn run --top-level jest --runInBand",
"lint": "yarn run --top-level eslint -c .eslintrc.js ",
"prepublishOnly": "yarn build"
},
"dependencies": {
"@azure/identity": "^1.1.0",
"@azure/keyvault-keys": "^4.1.0",
"@azure/keyvault-secrets": "^4.1.0",
"@azure/identity": "^4.0.1",
"@azure/keyvault-keys": "^4.7.2",
"@azure/keyvault-secrets": "^4.7.0",
"@celo/base": "^6.0.0",
"@celo/connect": "^5.1.1",
"@celo/utils": "^5.0.6",
Expand Down
6 changes: 1 addition & 5 deletions packages/sdk/wallets/wallet-hsm-azure/src/azure-key-vault-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,7 @@ export class AzureKeyVaultClient {
}
const signingAlgorithm = SIGNING_ALGORITHM_FOR[curve]
const cryptographyClient = await this.getCryptographyClient(keyName)
const signResult = await cryptographyClient.sign(
// @ts-ignore-next-line (ECDSA256 is not included in the client enum but is valid)
signingAlgorithm,
new Uint8Array(message)
)
const signResult = await cryptographyClient.sign(signingAlgorithm, new Uint8Array(message))
// The output of this will be a 64 byte array.
// The first 32 are the value for R and the rest is S
if (
Expand Down
Loading