Skip to content

TA-3749: Define Content CLI foundation#198

Merged
Zgjim Haziri (ZgjimHaziri) merged 30 commits into
content-cli-v2-refactoringfrom
TA-3749-seperate-foundation
May 16, 2025
Merged

TA-3749: Define Content CLI foundation#198
Zgjim Haziri (ZgjimHaziri) merged 30 commits into
content-cli-v2-refactoringfrom
TA-3749-seperate-foundation

Conversation

@ZgjimHaziri
Copy link
Copy Markdown
Contributor

@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) commented May 13, 2025

Description

We're starting a refactoring on Content CLI with the (main) purpose of defining clear ownership and separating the functionality provided by the tool from the command-specific logic. More details can be found in the linked design doc.

  • Defined Content CLI foundation in the top level of this new branch.
  • The commands have still not been migrated in the new directory.
  • The profile command was migrated in order to test the tool and since it can be considered as part of the foundation.
  • Merged two client services into one. Will migrate its usages when migrating the commands.

Notes

  • Refactoring was based on the experimenting done on this branch.
  • The changes were all done in a base branch content-cli-v2-refactoring which provides a clean state of the repository files besides the nodeJs related files. All the subsequent changes will be merged here, until the refactoring is finished.
  • We will check if we can persist history when merging the main content-cli-v2-refactor file, since doing that in this PR on top of a "main-like" branch, seemed to bring too many deletions, especially because we still haven't migrated much of the commands code.

Checklist

  • I have self-reviewed this PR
  • I have tested the change and proved that it works in different scenarios
  • I have updated docs if needed

Relevant links

Jira issue: https://celonis.atlassian.net/browse/TA-3749
Design doc

Comment thread src/content-cli-refactor/content-cli-refactored.ts Outdated
Comment thread src/content-cli-refactor/content-cli-refactored.ts Outdated
Comment thread src/content-cli-refactor/core/command/cli-context.ts Outdated
@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) changed the base branch from master to content-cli-v2 May 14, 2025 08:38
@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) changed the base branch from content-cli-v2 to content-cli-v2-refactoring May 14, 2025 08:49
Comment thread src/commands/profile/profile-module.ts Outdated
Comment thread src/content-cli.ts
Comment thread src/core/command/module-handler.ts Outdated
Comment thread src/commands/profile/question.service.ts
Comment thread src/core/http/http-client.ts Outdated
Comment thread src/core/command/module-handler.ts Outdated
@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) merged commit fd55a1e into content-cli-v2-refactoring May 16, 2025
1 check passed
@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) deleted the TA-3749-seperate-foundation branch May 16, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants