Skip to content

TA-3770: Migrate CPM4 commands#204

Merged
Zgjim Haziri (ZgjimHaziri) merged 46 commits into
content-cli-v2-refactoringfrom
TA-3770-migrate-cpm4-commands
May 22, 2025
Merged

TA-3770: Migrate CPM4 commands#204
Zgjim Haziri (ZgjimHaziri) merged 46 commits into
content-cli-v2-refactoringfrom
TA-3770-migrate-cpm4-commands

Conversation

@ZgjimHaziri
Copy link
Copy Markdown
Contributor

Description

  • Migrated the CPM4 push ctp command into the new structure.
  • The code logic is copy-pasted, besides some things like restructuring, command definition format.
  • Removed profile management logic from the services.
  • Removed profile management logic from manager and manager-factory. This is now provided by the tool.
    • Will keep the existing pattern here and leave it to the command owners to decide if they want to change it.

Relevant links

Jira issue: https://celonis.atlassian.net/browse/TA-3770

Notes

I would suggest to review the code along with some functional testing of the command. This will make easier reviewing the large number of added lines here.

Checklist

  • I have self-reviewed this PR
  • I have tested the change and proved that it works in different scenarios
  • I have updated docs if needed

@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) requested a review from a team as a code owner May 20, 2025 16:50
@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) requested a review from a team May 21, 2025 09:16
Base automatically changed from TA-3769-migrate-existing-analysis-commands to content-cli-v2-refactoring May 22, 2025 14:02
@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) requested a review from a team May 22, 2025 14:02
@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) merged commit 5cf37d1 into content-cli-v2-refactoring May 22, 2025
1 check passed
@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) deleted the TA-3770-migrate-cpm4-commands branch May 22, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants