Skip to content

TA-3751: Migrate Pacman commands#207

Merged
Jeta (jetakasabaqi) merged 10 commits into
TA-3768-setup-test-configfrom
TA-3751-migrate-pacman-commands
May 23, 2025
Merged

TA-3751: Migrate Pacman commands#207
Jeta (jetakasabaqi) merged 10 commits into
TA-3768-setup-test-configfrom
TA-3751-migrate-pacman-commands

Conversation

@ZgjimHaziri
Copy link
Copy Markdown
Contributor

@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) commented May 22, 2025

Description

  • Migrated Pacman commands into the new structure, based on this doc.
  • The code logic is copy-pasted, besides some things like e.g. restructuring, command definition format.
  • Migrated existing tests as they are, with only some minor changes in the test config setup to fit the new test config of the tool.
  • Some renaming, especially in used Studio service/api variables.
  • Created separate services for variableService, which was previously in Studio and contained all variable functionality regardless if Studio or Pacman.
  • Changed some static mocking that was done to verify calls to Studio APIs, to verify directly the API call with httpClient.

Relevant links

Jira issue: https://celonis.atlassian.net/browse/TA-3751

Notes

I would suggest to review the code along with some functional testing of the commands. This will make easier reviewing the large number of added lines here.

Checklist

  • I have self-reviewed this PR
  • I have tested the change and proved that it works in different scenarios
  • I have updated docs if needed

@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) marked this pull request as ready for review May 22, 2025 13:14
@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) requested a review from a team as a code owner May 22, 2025 13:14
Base automatically changed from TA-3768-migrate-action-flows to TA-3768-setup-test-config May 23, 2025 11:29
@jetakasabaqi Jeta (jetakasabaqi) requested a review from a team as a code owner May 23, 2025 11:29
@jetakasabaqi Jeta (jetakasabaqi) merged commit 4950af9 into TA-3768-setup-test-config May 23, 2025
@jetakasabaqi Jeta (jetakasabaqi) deleted the TA-3751-migrate-pacman-commands branch May 23, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants