TA-3794: Handle outstanding issues in refactor#209
Merged
Meris Nici (promeris) merged 8 commits intoMay 30, 2025
Merged
Conversation
Meris Nici (promeris)
requested review from
a team,
Dusan Radosavljevic (Dusan-r),
Ekta Dubey (EktaCelonis),
Ivan Gandacov (IvanGandacov) and
Oleg Goras (gorasoCelonis)
as code owners
Jeta (jetakasabaqi)
approved these changes
May 28, 2025
Buqeta (Buqeta)
approved these changes
May 28, 2025
Laberion Ajvazi (LaberionAjvazi)
approved these changes
May 28, 2025
Kastriot Salihu (ksalihu)
approved these changes
May 28, 2025
Meris Nici (promeris)
merged commit b0bc472
into
content-cli-v2-refactoring
1 check passed
Comment on lines
+86
to
+91
| const contentType = body instanceof FormData | ||
| ? "multipart/form-data" | ||
| : "application/json;charset=utf-8"; | ||
| const requestBody = typeof body === "string" || body instanceof String || body instanceof FormData | ||
| ? body | ||
| : JSON.stringify(body) |
Contributor
There was a problem hiding this comment.
This methods was design to work only with application/json and the postFile method here to be used for form-data. Did we try only changing the usage to postFile instead of post before modifying this? Asking to know if there was any issue with the postFile implementation.
Contributor
Author
There was a problem hiding this comment.
Didn't test it. I compared the implementations between old and refactor code base, and this method looked pretty much what was required, and left it as is because it fixed the issue. We can also go back to it and use proper method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pull packagecommand to use correct http client methodChecklist