Conversation
- Replaced unsafe `unwrap()` calls with safe error handling in parser and executor modules. - Refactored `GroupExecutor` to avoid double-dispatching aggregates. - Improved idiomaticity in `Option` handling (e.g., using `map_or` instead of `is_none || unwrap`). - Addressed TODO in `catalog/mod.rs` regarding schema resolution. - Removed redundant computations in `eval_having_expr`. Co-authored-by: celsowm <369336+celsowm@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR refactors the
tsql_corecrate to address several Rust anti-patterns:.unwrap()that could cause panics with proper error propagation usingDbError.GroupExecutor, aggregate functions were being dispatched twice (once for existence check and once for evaluation). This is now handled in a single step usingif let.OptionandResultmethods likemap_orandok_or_elseto make the code more readable and safe.PR created automatically by Jules for task 4190186289147152766 started by @celsowm