Skip to content

Conversation

@neebyA
Copy link
Contributor

@neebyA neebyA commented May 24, 2025

Various minor improvements to the macOS UI:

  • Allow creating app shortcuts on Mac, similar to Linux and Windows
  • Move the 'About' and 'General settings' menu items to where they would typically be found on Mac
    • Another copy of the existing 'General settings' menu item is still there in its original location
  • Add ⌘, keybinding for Settings, same as for other macOS apps
  • Add MoltenVK to list of used libraries

Cemu menu:
Screenshot 2025-05-24 at 1 18 47 AM
App appearance in Launchpad:
Screenshot 2025-05-24 at 1 36 36 AM

Create shortcuts on macOS

Move Mac menu bar items

Add MoltenVK to About menu
@emiyl
Copy link
Contributor

emiyl commented May 24, 2025

very nice :) with moving general settings, my only concern is that older guides, which haven't been updated, that may instruct the user to go to "Options -> General settings" would now be confusing for mac users. it may also complicate things, if the process is different depending on the platform. maybe i'm just overthinking things though.

@neebyA
Copy link
Contributor Author

neebyA commented May 25, 2025

older guides, which haven't been updated, that may instruct the user to go to "Options -> General settings" would now be confusing for mac users. it may also complicate things, if the process is different depending on the platform.

I thought about this too and felt that being consistent with other apps would be more intuitive, but I tried a few more things and it's possible to both keep the existing entry under "Options -> General settings", AND add a new one under "Cemu -> Settings...". Although, having the same settings window accessible from two different tabs might also cause confusion.

That, or just don't create the new "Cemu -> Settings... " entry but still apply the + , keybinding to the old one

@schm1dtmac
Copy link

older guides, which haven't been updated, that may instruct the user to go to "Options -> General settings" would now be confusing for mac users. it may also complicate things, if the process is different depending on the platform.

I thought about this too and felt that being consistent with other apps would be more intuitive, but I tried a few more things and it's possible to both keep the existing entry under "Options -> General settings", AND add a new one under "Cemu -> Settings...". Although, having the same settings window accessible from two different tabs might also cause confusion.

That, or just don't create the new "Cemu -> Settings... " entry but still apply the + , keybinding to the old one

I'd probably try and keep to macOS UI convention (and what the Apple HIG states explicitly here: https://developer.apple.com/design/human-interface-guidelines/settings) and toss out the old entry, given someone using Cemu on Mac will be more likely to intuitively seek out Settings in the menu bar, like in other Mac apps, than to read an old guide IMO.

@Exzap
Copy link
Member

Exzap commented May 27, 2025

It's more important that users find what they are looking for right away. In that sense having the option duplicated is better.

@Exzap
Copy link
Member

Exzap commented May 27, 2025

Looks mostly good to me. The only nitpick is that for file reading and writing the convention for new code is to use the FileStream utility class (found at Common/FileStream.h) and to avoid fstream or wxWidget's file functions

@Exzap Exzap merged commit a184a04 into cemu-project:main Jun 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants