Multiple fixes#26
Merged
CendioMartin merged 9 commits intocendio:masterfrom Jan 23, 2023
Thulium-Drake:master
Merged
Conversation
CendioMartin
suggested changes
Jan 12, 2023
Contributor
CendioMartin
left a comment
CendioMartin
left a comment
There was a problem hiding this comment.
Thank you for the PR! Please see my comments on 855f749
CendioMartin
suggested changes
Jan 12, 2023
Contributor
CendioMartin
left a comment
CendioMartin
left a comment
There was a problem hiding this comment.
There are problems with many of the commit messages. Try to keep the subject lines consist and short, and leave a blank line between the subject and body of your commit messages.
* Reworked templates to handle true/false bools set by users
…ible style (note: FQCN are not yet in place)
…le style (note: FQCN are not yet in place)
Contributor
Author
|
@CendioMartin I have reworked the commit messages :-) |
* Added check for installed software * Reworked all ansible_* facts to 'new' naming scheme ansible_facts['*']
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed that #24 also fixes some of the things I addressed in this PR.
However, I still felt it might be usefull to submit :-)
I tried adding some extra resilience when configuring it and rewrote some of the code to be more consistent and conform the 'new' style that's been used in Ansible (the one-liner style is considered deprecated and might break in the future)
I also noticed that for some reason not all services were properly started on my test system, so I added a few tasks to ensure that they do (with toggles for each to allow fine-tuning).