changed role to give it more flexibility#5
changed role to give it more flexibility#5MichaelTrip wants to merge 2 commits intocendio:masterfrom
Conversation
…e option to choose if you want a cluster or not
|
Maybe this also solves the problem for #1 |
CendioOssman
left a comment
CendioOssman
left a comment
There was a problem hiding this comment.
Thank you for your contribution. I have some questions about your scenario first though.
| thinlinc_agent_hostname: null | ||
|
|
||
| # Define if this is a standalone thinlinc environment or a cluster | ||
| thinlinc_use_cluster: false |
There was a problem hiding this comment.
What does your scenario look like here? How is this different from just having a single agent specified?
There was a problem hiding this comment.
Hi Pierre,
I am using thinlinc on a single server only. When i tried to run the playbook for the first time on multiple servers (i have 2 servers running thinlinc) the hostnames of the servers were added to the two config files. Because the host is a master and a agent.
There was a problem hiding this comment.
Ah, I see. In that case I think your suggestion here is more of a workaround than a fix. If you try to deploy two multi-machine clusters then things would still break.
So I think we need to look at a proper fix for #1. :/
| tlconfig: | ||
| param: /vsmagent/agent_hostname | ||
| value: "{{ thinlinc_agent_hostname or ansible_fqdn }}" | ||
| value: "{{ thinlinc_agent_hostname or ansible_hostname }}" |
There was a problem hiding this comment.
ansible_hostname is not always an externally valid name, so I think we're just trading one issue for another here.
What scenario are you trying to fix here?
There was a problem hiding this comment.
Maybe this was a bit overdone, ansible_fqdn was returning wrong values so i changed it to ansible_hostname.
The Web Access part of this was written by Michael Trip in PR #5. Co-authored-by: Samuel Mannehed <samuel@cendio.se>
|
I broke out the Web Access port-part of this PR to #40. |
3 participants
Hello,
I added some features to the role to be more flexible in deployment.