This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Use the same copts as ABSL.#11
Merged
g-easy merged 1 commit intocensus-instrumentation:masterfrom Jan 22, 2018
Merged
Conversation
Contributor
Author
|
What do you folks think? The motivation for this change is to silence the "warning: comparison between signed and unsigned integer expressions [-Wsign-compare]" If we decide to go ahead with this, I need to add copts=... to every target in every BUILD file. This is unfortunate, but it's how ABSL already does it. |
isturdy
reviewed
Jan 17, 2018
| # OpenCensus C++ Stats library: Example usage. | ||
| # | ||
| # Copyright 2017, OpenCensus Authors | ||
| # Copyright 2017, 2018, OpenCensus Authors |
Contributor
There was a problem hiding this comment.
Are we supposed to be updating these dates? Abseil is not.
Contributor
Author
There was a problem hiding this comment.
Looks like the answer is no.
isturdy
approved these changes
Jan 17, 2018
Contributor
isturdy
left a comment
isturdy
left a comment
There was a problem hiding this comment.
lgtm. Inconvenient, but better than wading through the compiler warnings.
Vizerai
approved these changes
Jan 20, 2018
Contributor
Vizerai
left a comment
Vizerai
left a comment
There was a problem hiding this comment.
LGTM
- Lets make the build have as few warnings as possible.
In particular, -Wno-sign-compare as Google style does not use unsigned integers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, -Wno-sign-compare as Google style does not use unsigned
integers.