This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Add DeltaProducer harvesting.#114
Merged
isturdy merged 1 commit intocensus-instrumentation:masterfrom Mar 27, 2018
Merged
Conversation
isturdy
force-pushed
the
deltaproducer-harvester
branch
from
d1e63f4 to
1d05a06
Compare
g-easy
reviewed
Mar 22, 2018
| ExperimentalDeltaProducerRecord({{SecondMeasure(), 1}}); | ||
| DeltaProducer::Get()->Flush(); | ||
| EXPECT_TRUE(view.GetData().int_data().empty()); | ||
| EXPECT_THAT(view.GetData().int_data(), ::testing::ElementsAre()); |
Contributor
There was a problem hiding this comment.
Doesn't the .empty() check imply this?
| const uint64_t index = MeasureRegistryImpl::IdToIndex(descriptor.measure_id_); | ||
| // We need to call this outside of the locked portion to avoid a deadlock when | ||
| // the DeltaProducer flushes the old delta. We call it before adding the view | ||
| // to avoid errors from the old delta not having a hsitogram for the new view. |
isturdy
force-pushed
the
deltaproducer-harvester
branch
2 times, most recently
from
0fc4a31 to
3e365a0
Compare
g-easy
approved these changes
Mar 27, 2018
isturdy
force-pushed
the
deltaproducer-harvester
branch
from
3e365a0 to
f9e07f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on previous PRs.